From mboxrd@z Thu Jan 1 00:00:00 1970 From: aq Subject: Re: [PATCH] 1 of 2: default ssid to 0 Date: Sun, 26 Jun 2005 19:07:40 +0900 Message-ID: <9cde8bff0506260307a91e65e@mail.gmail.com> References: <200506260249.18338.mark.williamson@cl.cam.ac.uk> <9cde8bff05062519186af4a17@mail.gmail.com> <200506260324.27847.mark.williamson@cl.cam.ac.uk> Reply-To: aq Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <200506260324.27847.mark.williamson@cl.cam.ac.uk> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Mark Williamson Cc: xen-devel@lists.xensource.com, Stefan Berger List-Id: xen-devel@lists.xenproject.org On 6/26/05, Mark Williamson wrote: > > i think it is very bad idea to have 2 coding styles for code in kernel > > and out of kernel. because people work on all those code must always > > remember to adjust the editor configuration, depend on the code in or > > out of kernel, which is a nightmare :-( >=20 > Yes, it's an extra thing to think about. It also means that code importe= d > from Linux needs adjusting to fit with the Xen coding convention. >=20 > OTOH, we don't just work with the Linux kernel any more, so there will be > multiple coding conventions anyhow. I just set up emacs so I can type "M= -x > xen-c-mode" or "M-x linux-c-mode". >=20 > > how about this simple guide? > > - C code complies Linux kernel coding style >=20 > I don't think this is likely to happen any time soon - it'd require patch= es to > all of Xen and the tools :-( (and probably to some of the Linux code but > that's arguably desirable) >=20 yes, that is too bad. but at least if we have an official style, we can enforce the rules *from now on*. the old code can be fix later (if possible). regards, aq