All of lore.kernel.org
 help / color / mirror / Atom feed
From: aq <aquynh@gmail.com>
To: xen-devel <xen-devel@lists.xensource.com>
Subject: [PATCH] balloon bugfix on -TESTING
Date: Mon, 18 Jul 2005 15:24:42 +0900	[thread overview]
Message-ID: <9cde8bff05071723241e6f944b@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]

This patch is for -testing, to fix some wrong calculates of max_pages
and max_memkb. Now balloon problem goes away (on *testing*).

Unfortunately i cannot confirm the similar fix to -unstable yesterday
is able to fix balloon problem, since i got some troubles creating
domU with the latest -unstable.

Demonstration:

$ xm list
Name              Id  Mem(MB)  CPU  State  Time(s)  Console
Domain-0           0       92    0  r----     44.3        
tty                1       40    0  -b---      0.9    9601

$ xm balloon tty 45
bun@dewey2:~/projects/myxen$ xm list
Name              Id  Mem(MB)  CPU  State  Time(s)  Console
Domain-0           0       92    0  r----     45.3        
tty                1       45    0  -b---      0.9    9601

bun@dewey2:~/projects/myxen$ xm balloon tty 35
bun@dewey2:~/projects/myxen$ xm list
Name              Id  Mem(MB)  CPU  State  Time(s)  Console
Domain-0           0       92    0  r----     46.1        
tty                1       35    0  -b---      0.9    9601


Signed-off-by: Nguyen Anh Quynh <aquynh@gmail.com>


$ diffstat balloon.patch 
 tools/libxc/xc_domain.c |    2 +-
 xen/common/dom0_ops.c   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

[-- Attachment #2: balloon.patch --]
[-- Type: application/octet-stream, Size: 987 bytes --]

diff -r 1cf15df7acf7 tools/libxc/xc_domain.c
--- a/tools/libxc/xc_domain.c	Sat Jul 16 16:44:39 2005
+++ b/tools/libxc/xc_domain.c	Mon Jul 18 15:06:38 2005
@@ -107,7 +107,7 @@
             DOMFLAGS_SHUTDOWNMASK;
 
         info->nr_pages = op.u.getdomaininfo.tot_pages;
-        info->max_memkb = op.u.getdomaininfo.max_pages<<(PAGE_SHIFT);
+        info->max_memkb = op.u.getdomaininfo.max_pages<<(PAGE_SHIFT-10);
         info->shared_info_frame = op.u.getdomaininfo.shared_info_frame;
         info->cpu_time = op.u.getdomaininfo.cpu_time;
 
diff -r 1cf15df7acf7 xen/common/dom0_ops.c
--- a/xen/common/dom0_ops.c	Sat Jul 16 16:44:39 2005
+++ b/xen/common/dom0_ops.c	Mon Jul 18 15:06:38 2005
@@ -477,7 +477,7 @@
         if ( d != NULL )
         {
             d->max_pages = 
-                (op->u.setdomainmaxmem.max_memkb+PAGE_SIZE-1)>> PAGE_SHIFT;
+                (op->u.setdomainmaxmem.max_memkb)>> (PAGE_SHIFT-10);
             put_domain(d);
             ret = 0;
         }

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

             reply	other threads:[~2005-07-18  6:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-18  6:24 aq [this message]
2005-07-18  7:52 ` [PATCH] balloon bugfix on -TESTING aq
2005-07-19  7:17   ` xuehai zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9cde8bff05071723241e6f944b@mail.gmail.com \
    --to=aquynh@gmail.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.