From mboxrd@z Thu Jan 1 00:00:00 1970 From: aq Subject: Re: execve() in reboot.c ? Date: Tue, 26 Jul 2005 02:41:31 +0900 Message-ID: <9cde8bff050725104174d9314b@mail.gmail.com> References: Reply-To: aq Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_6938_21306657.1122313291569" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Pratt Cc: xen-devel List-Id: xen-devel@lists.xenproject.org ------=_Part_6938_21306657.1122313291569 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On 7/25/05, Ian Pratt wrote: > > Domain kernel has arch/xen/kernel/reboot.c, which executes > > shutdown and halt on request. But one problem is that we have > > the path and command options fixed in the kernel, like this: > > > > > > static char *restart_argv[] =3D { "/sbin/shutdown", "-r", > > "now", NULL }; > > static char *poweroff_argv[] =3D { "/sbin/halt", "-p", > > NULL }; > > > > > > That is kind of violating the rule: kernel should never > > enforce the policy to the user. We can see the problem if for > > example domU uses busybox instead of sysvinit: busybox doesnt > > support "halt -p", so "xm shutdown" cannot shutdown the domU. >=20 > Would 'telinit 1' / 'telinit 6' work on busybox ? >=20 Unfortunately telinit is not available in busybox.=20 Here are 2 patches (for -testing and -unstable), in which i replaced shutdown and halt with poweroff and reboot, and executes those without any options. This patch confirms to work with both sysvinit (on Ubuntu) and busybox (ttylinux - without these patch i couldnt shutdown ttylinux with "xm shutdown"). Please apply. Signed-off-by: Nguyen Anh Quynh $ diffstat shutdown.testing.patch=20 reboot.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) $ diffstat shutdown.unstable.patch=20 reboot.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) ------=_Part_6938_21306657.1122313291569 Content-Type: application/octet-stream; name="shutdown.unstable.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="shutdown.unstable.patch" ZGlmZiAtciA0OGFlZDE0MDNmZTMgbGludXgtMi42LXhlbi1zcGFyc2UvYXJjaC94ZW4va2VybmVs L3JlYm9vdC5jCi0tLSBhL2xpbnV4LTIuNi14ZW4tc3BhcnNlL2FyY2gveGVuL2tlcm5lbC9yZWJv b3QuYwlGcmkgSnVsIDIyIDE2OjQ0OjMzIDIwMDUKKysrIGIvbGludXgtMi42LXhlbi1zcGFyc2Uv YXJjaC94ZW4va2VybmVsL3JlYm9vdC5jCVR1ZSBKdWwgMjYgMDI6MjI6MzQgMjAwNQpAQCAtMTcy LDggKzE3Miw4IEBACiB7CiAgICAgc3RhdGljIGNoYXIgKmVudnBbXSA9IHsgIkhPTUU9LyIsICJU RVJNPWxpbnV4IiwgCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIlBBVEg9L3NiaW46L3Vz ci9zYmluOi9iaW46L3Vzci9iaW4iLCBOVUxMIH07Ci0gICAgc3RhdGljIGNoYXIgKnJlc3RhcnRf YXJndltdICA9IHsgIi9zYmluL3NodXRkb3duIiwgIi1yIiwgIm5vdyIsIE5VTEwgfTsKLSAgICBz dGF0aWMgY2hhciAqcG93ZXJvZmZfYXJndltdID0geyAiL3NiaW4vaGFsdCIsICAgICAiLXAiLCAg ICAgICAgTlVMTCB9OworICAgIHN0YXRpYyBjaGFyICpyZXN0YXJ0X2FyZ3ZbXSAgPSB7ICIvc2Jp bi9yZWJvb3QiLCBOVUxMIH07CisgICAgc3RhdGljIGNoYXIgKnBvd2Vyb2ZmX2FyZ3ZbXSA9IHsg Ii9zYmluL3Bvd2Vyb2ZmIiwgTlVMTCB9OwogCiAgICAgZXh0ZXJuIGFzbWxpbmthZ2UgbG9uZyBz eXNfcmVib290KGludCBtYWdpYzEsIGludCBtYWdpYzIsCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBjbWQsIHZvaWQgKmFyZyk7CkBAIC0xODcsNyAr MTg3LDcgQEAKICAgICBzd2l0Y2ggKCBzaHV0dGluZ19kb3duICkKICAgICB7CiAgICAgY2FzZSBD TVNHX1NIVVRET1dOX1BPV0VST0ZGOgotICAgICAgICBpZiAoIGV4ZWN2ZSgiL3NiaW4vaGFsdCIs IHBvd2Vyb2ZmX2FyZ3YsIGVudnApIDwgMCApCisgICAgICAgIGlmICggZXhlY3ZlKCIvc2Jpbi9w b3dlcm9mZiIsIHBvd2Vyb2ZmX2FyZ3YsIGVudnApIDwgMCApCiAgICAgICAgIHsKICAgICAgICAg ICAgIHN5c19yZWJvb3QoTElOVVhfUkVCT09UX01BR0lDMSwKICAgICAgICAgICAgICAgICAgICAg ICAgTElOVVhfUkVCT09UX01BR0lDMiwKQEAgLTE5Nyw3ICsxOTcsNyBAQAogICAgICAgICBicmVh azsKIAogICAgIGNhc2UgQ01TR19TSFVURE9XTl9SRUJPT1Q6Ci0gICAgICAgIGlmICggZXhlY3Zl KCIvc2Jpbi9zaHV0ZG93biIsIHJlc3RhcnRfYXJndiwgZW52cCkgPCAwICkKKyAgICAgICAgaWYg KCBleGVjdmUoIi9zYmluL3JlYm9vdCIsIHJlc3RhcnRfYXJndiwgZW52cCkgPCAwICkKICAgICAg ICAgewogICAgICAgICAgICAgc3lzX3JlYm9vdChMSU5VWF9SRUJPT1RfTUFHSUMxLAogICAgICAg ICAgICAgICAgICAgICAgICBMSU5VWF9SRUJPT1RfTUFHSUMyLAo= ------=_Part_6938_21306657.1122313291569 Content-Type: application/octet-stream; name="shutdown.testing.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="shutdown.testing.patch" ZGlmZiAtciAwMjY0MzZlYmQ5OWMgbGludXgtMi42LjExLXhlbi1zcGFyc2UvYXJjaC94ZW4va2Vy bmVsL3JlYm9vdC5jCi0tLSBhL2xpbnV4LTIuNi4xMS14ZW4tc3BhcnNlL2FyY2gveGVuL2tlcm5l bC9yZWJvb3QuYwlNb24gSnVsIDE4IDA3OjQ1OjQxIDIwMDUKKysrIGIvbGludXgtMi42LjExLXhl bi1zcGFyc2UvYXJjaC94ZW4va2VybmVsL3JlYm9vdC5jCVR1ZSBKdWwgMjYgMDI6MjQ6MzggMjAw NQpAQCAtMTU5LDggKzE1OSw4IEBACiB7CiAgICAgc3RhdGljIGNoYXIgKmVudnBbXSA9IHsgIkhP TUU9LyIsICJURVJNPWxpbnV4IiwgCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIlBBVEg9 L3NiaW46L3Vzci9zYmluOi9iaW46L3Vzci9iaW4iLCBOVUxMIH07Ci0gICAgc3RhdGljIGNoYXIg KnJlc3RhcnRfYXJndltdICA9IHsgIi9zYmluL3NodXRkb3duIiwgIi1yIiwgIm5vdyIsIE5VTEwg fTsKLSAgICBzdGF0aWMgY2hhciAqcG93ZXJvZmZfYXJndltdID0geyAiL3NiaW4vaGFsdCIsICAg ICAiLXAiLCAgICAgICAgTlVMTCB9OworICAgIHN0YXRpYyBjaGFyICpyZXN0YXJ0X2FyZ3ZbXSAg PSB7ICIvc2Jpbi9yZWJvb3QiLCBOVUxMIH07CisgICAgc3RhdGljIGNoYXIgKnBvd2Vyb2ZmX2Fy Z3ZbXSA9IHsgIi9zYmluL3Bvd2Vyb2ZmIiwgTlVMTCB9OwogCiAgICAgZXh0ZXJuIGFzbWxpbmth Z2UgbG9uZyBzeXNfcmVib290KGludCBtYWdpYzEsIGludCBtYWdpYzIsCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBjbWQsIHZvaWQgKmFyZyk7CkBA IC0xNzQsNyArMTc0LDcgQEAKICAgICBzd2l0Y2ggKCBzaHV0dGluZ19kb3duICkKICAgICB7CiAg ICAgY2FzZSBDTVNHX1NIVVRET1dOX1BPV0VST0ZGOgotICAgICAgICBpZiAoIGV4ZWN2ZSgiL3Ni aW4vaGFsdCIsIHBvd2Vyb2ZmX2FyZ3YsIGVudnApIDwgMCApCisgICAgICAgIGlmICggZXhlY3Zl KCIvc2Jpbi9wb3dlcm9mZiIsIHBvd2Vyb2ZmX2FyZ3YsIGVudnApIDwgMCApCiAgICAgICAgIHsK ICAgICAgICAgICAgIHN5c19yZWJvb3QoTElOVVhfUkVCT09UX01BR0lDMSwKICAgICAgICAgICAg ICAgICAgICAgICAgTElOVVhfUkVCT09UX01BR0lDMiwKQEAgLTE4NCw3ICsxODQsNyBAQAogICAg ICAgICBicmVhazsKIAogICAgIGNhc2UgQ01TR19TSFVURE9XTl9SRUJPT1Q6Ci0gICAgICAgIGlm ICggZXhlY3ZlKCIvc2Jpbi9zaHV0ZG93biIsIHJlc3RhcnRfYXJndiwgZW52cCkgPCAwICkKKyAg ICAgICAgaWYgKCBleGVjdmUoIi9zYmluL3JlYm9vdCIsIHJlc3RhcnRfYXJndiwgZW52cCkgPCAw ICkKICAgICAgICAgewogICAgICAgICAgICAgc3lzX3JlYm9vdChMSU5VWF9SRUJPT1RfTUFHSUMx LAogICAgICAgICAgICAgICAgICAgICAgICBMSU5VWF9SRUJPT1RfTUFHSUMyLAo= ------=_Part_6938_21306657.1122313291569 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel ------=_Part_6938_21306657.1122313291569--