From mboxrd@z Thu Jan 1 00:00:00 1970 From: aq Subject: Re: [PATCH] Convert balloon driver to xenstore Date: Wed, 3 Aug 2005 12:45:50 +0900 Message-ID: <9cde8bff05080220456cf22b3b@mail.gmail.com> References: <9cde8bff0508020311157b4463@mail.gmail.com> <1123031513.7228.6.camel@localhost.localdomain> <42F02851.4050905@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <42F02851.4050905@us.ibm.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Anthony Liguori Cc: Dan Smith , Rusty Russell , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 8/3/05, Anthony Liguori wrote: > Rusty Russell wrote: >=20 > >On Tue, 2005-08-02 at 06:51 -0700, Dan Smith wrote: > > > > > >Generally, you will want to do a module_init() and initialize your > >driver. If it's in domain 0, it needs to be initialized later (the > >store isn't up yet): the standard way of doing this is a notifier chain. > > > >Something like the following: > > > >static struct notifier_block store_notify =3D > >{ > > .notifier_call =3D balloon_setup, > >}; > > > >static int balloon_init() > >{ > > if (!xen_start_info.store_evtchn) > > register_xenstore_notifier(&store_notify); > > else > > balloon_setup(&store_notify, 0, NULL); > > return 0; > >} > > > > > How does this look? >=20 looks nice to me. why didnt you provice also the patch for balloon ;-) =20 regards, aq