All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David Hildenbrand (Red Hat)" <david@kernel.org>
To: Luiz Capitulino <luizcap@redhat.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: ryan.roberts@arm.com, akpm@linux-foundation.org,
	lorenzo.stoakes@oracle.com
Subject: Re: [RFC 03/10] drivers: dax: use pgtable_has_pmd_leaves()
Date: Mon, 17 Nov 2025 18:28:26 +0100	[thread overview]
Message-ID: <9ce40155-2731-4dec-8c18-e27f13bf1872@kernel.org> (raw)
In-Reply-To: <1456ba4c025e9ea01abcadb8c3714c7ef84e0198.1762464515.git.luizcap@redhat.com>

On 06.11.25 22:28, Luiz Capitulino wrote:
> dav_align_valid() uses has_transparent_hugepage() to check if PMD-sized
> pages are supported, use pgtable_has_pmd_leaves() instead.
> 
> Signed-off-by: Luiz Capitulino <luizcap@redhat.com>
> ---
>   drivers/dax/dax-private.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dax/dax-private.h b/drivers/dax/dax-private.h
> index 0867115aeef2..10aeaec9e789 100644
> --- a/drivers/dax/dax-private.h
> +++ b/drivers/dax/dax-private.h
> @@ -117,7 +117,7 @@ static inline bool dax_align_valid(unsigned long align)
>   {
>   	if (align == PUD_SIZE && IS_ENABLED(CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD))

As discussed offlist, it would be great to later also have this be

if (align == PUD_SIZE && pgtable_has_pud_leaves()

Acked-by: David Hildenbrand (Red Hat) <david@kernel.org>

-- 
Cheers

David


  reply	other threads:[~2025-11-17 17:28 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-06 21:28 [RFC 00/10] mm: thp: always enable mTHP support Luiz Capitulino
2025-11-06 21:28 ` [RFC 01/10] docs: tmpfs: remove implementation detail reference Luiz Capitulino
2025-11-17 17:26   ` David Hildenbrand (Red Hat)
2025-11-06 21:28 ` [RFC 02/10] mm: introduce pgtable_has_pmd_leaves() Luiz Capitulino
2025-11-06 21:28 ` [RFC 03/10] drivers: dax: use pgtable_has_pmd_leaves() Luiz Capitulino
2025-11-17 17:28   ` David Hildenbrand (Red Hat) [this message]
2025-11-06 21:28 ` [RFC 04/10] drivers: i915 selftest: " Luiz Capitulino
2025-11-17 17:29   ` David Hildenbrand (Red Hat)
2025-11-17 17:30   ` David Hildenbrand (Red Hat)
2025-11-17 18:55     ` Luiz Capitulino
2025-12-02 10:51       ` David Hildenbrand (Red Hat)
2025-12-03 13:19         ` Luiz Capitulino
2025-11-06 21:28 ` [RFC 05/10] drivers: nvdimm: " Luiz Capitulino
2025-11-17 17:32   ` David Hildenbrand (Red Hat)
2025-11-06 21:28 ` [RFC 06/10] mm: debug_vm_pgtable: " Luiz Capitulino
2025-11-17 17:40   ` David Hildenbrand (Red Hat)
2025-12-03 22:09     ` David Hildenbrand (Red Hat)
2025-11-06 21:28 ` [RFC 07/10] treewide: rename has_transparent_hugepage() to arch_has_pmd_leaves() Luiz Capitulino
2025-11-17 17:45   ` David Hildenbrand (Red Hat)
2025-11-17 19:01     ` Luiz Capitulino
2025-12-02 10:53       ` David Hildenbrand (Red Hat)
2025-11-06 21:28 ` [RFC 08/10] mm: replace thp_disabled_by_hw() with pgtable_has_pmd_leaves() Luiz Capitulino
2025-11-06 21:28 ` [RFC 09/10] mm: thp: always enable mTHP support Luiz Capitulino
2025-11-17 17:47   ` David Hildenbrand (Red Hat)
2025-11-17 19:14     ` Luiz Capitulino
2025-11-06 21:28 ` [RFC 10/10] mm: thp: x86: cleanup PSE feature bit usage Luiz Capitulino
2025-11-17 17:49   ` David Hildenbrand (Red Hat)
2025-11-17 19:15     ` Luiz Capitulino
2025-12-03 13:58 ` [RFC 00/10] mm: thp: always enable mTHP support Lorenzo Stoakes
2025-12-03 18:41   ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ce40155-2731-4dec-8c18-e27f13bf1872@kernel.org \
    --to=david@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=luizcap@redhat.com \
    --cc=ryan.roberts@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.