From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hildenbrand Subject: Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage Date: Mon, 28 Nov 2022 09:18:47 +0100 Message-ID: <9d0bf98a-3d6a-1082-e992-1338e1525935@redhat.com> References: <20221116102659.70287-1-david@redhat.com> <20221116102659.70287-17-david@redhat.com> <81fb0fa3-2e06-b765-56ac-a7d981194e59@redhat.com> <08b65ac6-6786-1080-18f8-d2be109c85fc@xs4all.nl> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669623533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ueiNL/RrPlD3vRod9MDAxJpgFwmJj0Jyg8USWk7yPz8=; b=S+oFkjKVP3mckzd7VBbvH1QuZTZol0q9wTWffdsPiXu+2nmhjaLmPhu8ziCyV0KCioRPJI 5JQ7Ka6QTT7w/TcDd4C3+oasgr3fATIDGVWRdSU8qp6A71RrRGJewLWoV59J4JHfMOQ3z1 2VHUt/gcI6faTsrG8illEYtRpXcU/30= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669623533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ueiNL/RrPlD3vRod9MDAxJpgFwmJj0Jyg8USWk7yPz8=; b=S+oFkjKVP3mckzd7VBbvH1QuZTZol0q9wTWffdsPiXu+2nmhjaLmPhu8ziCyV0KCioRPJI 5JQ7Ka6QTT7w/TcDd4C3+oasgr3fATIDGVWRdSU8qp6A71RrRGJewLWoV59J4JHfMOQ3z1 2VHUt/gcI6faTsrG8illEYtRpXcU/30= In-Reply-To: <08b65ac6-6786-1080-18f8-d2be109c85fc@xs4all.nl> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane-mx.org@lists.ozlabs.org Sender: "Linuxppc-dev" Content-Type: text/plain; charset="utf-8"; format="flowed" To: Hans Verkuil , linux-kernel@vger.kernel.org, Andrew Morton Cc: linux-ia64@vger.kernel.org, Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Nadav Amit , linux-kselftest@vger.kernel.org, sparclinux@vger.kernel.org, Shuah Khan , Marek Szyprowski , Andrea Arcangeli , linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, David Airlie , x86@kernel.org, Hugh Dickins , Matthew Wilcox , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , linux-media@vger.kernel.org, Arnd Bergmann , John Hubbard , linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, Alex William son , Peter Xu , Muchun Song On 28.11.22 09:17, Hans Verkuil wrote: > Hi David, > > On 27/11/2022 11:35, David Hildenbrand wrote: >> On 16.11.22 11:26, David Hildenbrand wrote: >>> FOLL_FORCE is really only for ptrace access. According to commit >>> 707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers are always >>> writable"), get_vaddr_frames() currently pins all pages writable as a >>> workaround for issues with read-only buffers. >>> >>> FOLL_FORCE, however, seems to be a legacy leftover as it predates >>> commit 707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers are >>> always writable"). Let's just remove it. >>> >>> Once the read-only buffer issue has been resolved, FOLL_WRITE could >>> again be set depending on the DMA direction. >>> >>> Cc: Hans Verkuil >>> Cc: Marek Szyprowski >>> Cc: Tomasz Figa >>> Cc: Marek Szyprowski >>> Cc: Mauro Carvalho Chehab >>> Signed-off-by: David Hildenbrand >>> --- >>>   drivers/media/common/videobuf2/frame_vector.c | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/media/common/videobuf2/frame_vector.c b/drivers/media/common/videobuf2/frame_vector.c >>> index 542dde9d2609..062e98148c53 100644 >>> --- a/drivers/media/common/videobuf2/frame_vector.c >>> +++ b/drivers/media/common/videobuf2/frame_vector.c >>> @@ -50,7 +50,7 @@ int get_vaddr_frames(unsigned long start, unsigned int nr_frames, >>>       start = untagged_addr(start); >>>         ret = pin_user_pages_fast(start, nr_frames, >>> -                  FOLL_FORCE | FOLL_WRITE | FOLL_LONGTERM, >>> +                  FOLL_WRITE | FOLL_LONGTERM, >>>                     (struct page **)(vec->ptrs)); >>>       if (ret > 0) { >>>           vec->got_ref = true; >> >> >> Hi Andrew, >> >> see the discussion at [1] regarding a conflict and how to proceed with >> upstreaming. The conflict would be easy to resolve, however, also >> the patch description doesn't make sense anymore with [1]. > > Might it be easier and less confusing if you post a v2 of this series > with my patch first? That way it is clear that 1) my patch has to come > first, and 2) that it is part of a single series and should be merged > by the mm subsystem. > > Less chances of things going wrong that way. > > Just mention in the v2 cover letter that the first patch was added to > make it easy to backport that fix without being hampered by merge > conflicts if it was added after your frame_vector.c patch. Yes, that's the way I would naturally do, it, however, Andrew prefers delta updates for minor changes. @Andrew, whatever you prefer! Thanks! -- Thanks, David / dhildenb From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hildenbrand Date: Mon, 28 Nov 2022 08:18:47 +0000 Subject: Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage Message-Id: <9d0bf98a-3d6a-1082-e992-1338e1525935@redhat.com> List-Id: References: <20221116102659.70287-1-david@redhat.com> <20221116102659.70287-17-david@redhat.com> <81fb0fa3-2e06-b765-56ac-a7d981194e59@redhat.com> <08b65ac6-6786-1080-18f8-d2be109c85fc@xs4all.nl> In-Reply-To: <08b65ac6-6786-1080-18f8-d2be109c85fc@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Hans Verkuil , linux-kernel@vger.kernel.org, Andrew Morton Cc: x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, Linus Torvalds , Jason Gunthorpe , John Hubbard , Peter Xu , Greg Kroah-Hartman , Andrea Arcangeli , Hugh Dickins , Nadav Amit , Vlastimil Babka , Matthew Wilcox , Mike Kravetz , Muchun Song , Shuah Khan , Lucas Stach , David Airlie , Oded Gabbay , Arnd Bergmann , Christoph Hellwig , Alex Williamson , Marek Szyprowski , Tomasz Figa , Mauro Carvalho Chehab On 28.11.22 09:17, Hans Verkuil wrote: > Hi David, > > On 27/11/2022 11:35, David Hildenbrand wrote: >> On 16.11.22 11:26, David Hildenbrand wrote: >>> FOLL_FORCE is really only for ptrace access. According to commit >>> 707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers are always >>> writable"), get_vaddr_frames() currently pins all pages writable as a >>> workaround for issues with read-only buffers. >>> >>> FOLL_FORCE, however, seems to be a legacy leftover as it predates >>> commit 707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers are >>> always writable"). Let's just remove it. >>> >>> Once the read-only buffer issue has been resolved, FOLL_WRITE could >>> again be set depending on the DMA direction. >>> >>> Cc: Hans Verkuil >>> Cc: Marek Szyprowski >>> Cc: Tomasz Figa >>> Cc: Marek Szyprowski >>> Cc: Mauro Carvalho Chehab >>> Signed-off-by: David Hildenbrand >>> --- >>>   drivers/media/common/videobuf2/frame_vector.c | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/media/common/videobuf2/frame_vector.c b/drivers/media/common/videobuf2/frame_vector.c >>> index 542dde9d2609..062e98148c53 100644 >>> --- a/drivers/media/common/videobuf2/frame_vector.c >>> +++ b/drivers/media/common/videobuf2/frame_vector.c >>> @@ -50,7 +50,7 @@ int get_vaddr_frames(unsigned long start, unsigned int nr_frames, >>>       start = untagged_addr(start); >>>         ret = pin_user_pages_fast(start, nr_frames, >>> -                  FOLL_FORCE | FOLL_WRITE | FOLL_LONGTERM, >>> +                  FOLL_WRITE | FOLL_LONGTERM, >>>                     (struct page **)(vec->ptrs)); >>>       if (ret > 0) { >>>           vec->got_ref = true; >> >> >> Hi Andrew, >> >> see the discussion at [1] regarding a conflict and how to proceed with >> upstreaming. The conflict would be easy to resolve, however, also >> the patch description doesn't make sense anymore with [1]. > > Might it be easier and less confusing if you post a v2 of this series > with my patch first? That way it is clear that 1) my patch has to come > first, and 2) that it is part of a single series and should be merged > by the mm subsystem. > > Less chances of things going wrong that way. > > Just mention in the v2 cover letter that the first patch was added to > make it easy to backport that fix without being hampered by merge > conflicts if it was added after your frame_vector.c patch. Yes, that's the way I would naturally do, it, however, Andrew prefers delta updates for minor changes. @Andrew, whatever you prefer! Thanks! -- Thanks, David / dhildenb From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFAAAC433FE for ; Mon, 28 Nov 2022 08:19:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229902AbiK1ITx (ORCPT ); Mon, 28 Nov 2022 03:19:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229629AbiK1ITx (ORCPT ); Mon, 28 Nov 2022 03:19:53 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7132B1055C for ; Mon, 28 Nov 2022 00:18:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669623533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ueiNL/RrPlD3vRod9MDAxJpgFwmJj0Jyg8USWk7yPz8=; b=S+oFkjKVP3mckzd7VBbvH1QuZTZol0q9wTWffdsPiXu+2nmhjaLmPhu8ziCyV0KCioRPJI 5JQ7Ka6QTT7w/TcDd4C3+oasgr3fATIDGVWRdSU8qp6A71RrRGJewLWoV59J4JHfMOQ3z1 2VHUt/gcI6faTsrG8illEYtRpXcU/30= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-306-gheVYTuUP0yOo7v9eOK4RQ-1; Mon, 28 Nov 2022 03:18:51 -0500 X-MC-Unique: gheVYTuUP0yOo7v9eOK4RQ-1 Received: by mail-wm1-f69.google.com with SMTP id 8-20020a05600c228800b003d0376e42deso3472971wmf.4 for ; Mon, 28 Nov 2022 00:18:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ueiNL/RrPlD3vRod9MDAxJpgFwmJj0Jyg8USWk7yPz8=; b=Io9PY8A2Iq6Ndhm/PvokcqEmIpJYCYAiCV7qzEma52ZzWjuX7K1xnuJa3zD2cGi5Tw 4MEWMEkdN6+e0RxzxbfP/IFS9H0oR7zGkliyommN//v0/4fchIz5q2Ti4NILNAuxJ253 WKtebiL7WTX8GkNU2DzWAiPNIewQAheAN0q8hqjweNAhf8hIOu/BhyRtEqJWFEj6yo75 XWYV9IOwB/Co/26rm0ySOlSjh7JERVxVCsq8Z00B2NLFdtGaFWZTk74I7bbV4MXPVKFN rLFvObApDXFHQtiTETGrkhRMCZTQYW5boGBF6BstJ6nj6iBAiKyJxlSabCZIu4mCGvDo NmDw== X-Gm-Message-State: ANoB5pmtOCRnYQeWzc9bVIyTe2bC3MESmOWsTazQpRzAwiHIdMRwSxPD oTIeCVYGng0I+JTxgR6FyGvZB8M1xTIEPNTYF/PeVYnIP5pUH2yA/kqySmouHCudXx0fU9a4BxT 5kov8B2n+foUYJsLAjQWqsJeQ4S8C X-Received: by 2002:a05:600c:3587:b0:3cf:a9c2:2b04 with SMTP id p7-20020a05600c358700b003cfa9c22b04mr36262285wmq.152.1669623530588; Mon, 28 Nov 2022 00:18:50 -0800 (PST) X-Google-Smtp-Source: AA0mqf5KFgnMS9OgeX6iNUgB1p0xskb3yOxviUW4FnLaUffslFm3du7Shktyf0rRUHCATZ7f+3nFJA== X-Received: by 2002:a05:600c:3587:b0:3cf:a9c2:2b04 with SMTP id p7-20020a05600c358700b003cfa9c22b04mr36262220wmq.152.1669623530122; Mon, 28 Nov 2022 00:18:50 -0800 (PST) Received: from ?IPV6:2003:cb:c702:9000:3d6:e434:f8b4:80cf? (p200300cbc702900003d6e434f8b480cf.dip0.t-ipconnect.de. [2003:cb:c702:9000:3d6:e434:f8b4:80cf]) by smtp.gmail.com with ESMTPSA id g14-20020a05600c310e00b003a2f2bb72d5sm22518102wmo.45.2022.11.28.00.18.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 00:18:49 -0800 (PST) Message-ID: <9d0bf98a-3d6a-1082-e992-1338e1525935@redhat.com> Date: Mon, 28 Nov 2022 09:18:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage Content-Language: en-US To: Hans Verkuil , linux-kernel@vger.kernel.org, Andrew Morton Cc: x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, Linus Torvalds , Jason Gunthorpe , John Hubbard , Peter Xu , Greg Kroah-Hartman , Andrea Arcangeli , Hugh Dickins , Nadav Amit , Vlastimil Babka , Matthew Wilcox , Mike Kravetz , Muchun Song , Shuah Khan , Lucas Stach , David Airlie , Oded Gabbay , Arnd Bergmann , Christoph Hellwig , Alex Williamson , Marek Szyprowski , Tomasz Figa , Mauro Carvalho Chehab References: <20221116102659.70287-1-david@redhat.com> <20221116102659.70287-17-david@redhat.com> <81fb0fa3-2e06-b765-56ac-a7d981194e59@redhat.com> <08b65ac6-6786-1080-18f8-d2be109c85fc@xs4all.nl> From: David Hildenbrand Organization: Red Hat In-Reply-To: <08b65ac6-6786-1080-18f8-d2be109c85fc@xs4all.nl> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 28.11.22 09:17, Hans Verkuil wrote: > Hi David, > > On 27/11/2022 11:35, David Hildenbrand wrote: >> On 16.11.22 11:26, David Hildenbrand wrote: >>> FOLL_FORCE is really only for ptrace access. According to commit >>> 707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers are always >>> writable"), get_vaddr_frames() currently pins all pages writable as a >>> workaround for issues with read-only buffers. >>> >>> FOLL_FORCE, however, seems to be a legacy leftover as it predates >>> commit 707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers are >>> always writable"). Let's just remove it. >>> >>> Once the read-only buffer issue has been resolved, FOLL_WRITE could >>> again be set depending on the DMA direction. >>> >>> Cc: Hans Verkuil >>> Cc: Marek Szyprowski >>> Cc: Tomasz Figa >>> Cc: Marek Szyprowski >>> Cc: Mauro Carvalho Chehab >>> Signed-off-by: David Hildenbrand >>> --- >>>   drivers/media/common/videobuf2/frame_vector.c | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/media/common/videobuf2/frame_vector.c b/drivers/media/common/videobuf2/frame_vector.c >>> index 542dde9d2609..062e98148c53 100644 >>> --- a/drivers/media/common/videobuf2/frame_vector.c >>> +++ b/drivers/media/common/videobuf2/frame_vector.c >>> @@ -50,7 +50,7 @@ int get_vaddr_frames(unsigned long start, unsigned int nr_frames, >>>       start = untagged_addr(start); >>>         ret = pin_user_pages_fast(start, nr_frames, >>> -                  FOLL_FORCE | FOLL_WRITE | FOLL_LONGTERM, >>> +                  FOLL_WRITE | FOLL_LONGTERM, >>>                     (struct page **)(vec->ptrs)); >>>       if (ret > 0) { >>>           vec->got_ref = true; >> >> >> Hi Andrew, >> >> see the discussion at [1] regarding a conflict and how to proceed with >> upstreaming. The conflict would be easy to resolve, however, also >> the patch description doesn't make sense anymore with [1]. > > Might it be easier and less confusing if you post a v2 of this series > with my patch first? That way it is clear that 1) my patch has to come > first, and 2) that it is part of a single series and should be merged > by the mm subsystem. > > Less chances of things going wrong that way. > > Just mention in the v2 cover letter that the first patch was added to > make it easy to backport that fix without being hampered by merge > conflicts if it was added after your frame_vector.c patch. Yes, that's the way I would naturally do, it, however, Andrew prefers delta updates for minor changes. @Andrew, whatever you prefer! Thanks! -- Thanks, David / dhildenb From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87B27C433FE for ; Mon, 28 Nov 2022 08:19:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xRwnNPQ4uPakKuFp8WxI+BSzU8vhcOB8zMpcZXjfHUE=; b=X0fNwgU5gFyNej l643Q+C9gB3zn6kVQKTl7AvwEUEcoFYF6ZHoL8NKlT2R8anaMBtF3bDiuet1id7rManxLW5qxDdn9 MG+IKNer+t+r/Yd1W+NhjEy1fIbnyJL7uQ531nuQ9M+PIP0OFkJikxnLF/7Hc7284fQVFTJJUaiP9 nZ36iIVER3t7McSR+UwGW/v1fNmF7NgUo4EGvxJtk3dj5/3Dl8FIrEup/aF1BDeRDRnVtK3Nl5avg 4tfa42PYED8yJqrHedgy1wmQ2D5Q1Y/Wl2XtDBQHw7SMa8lglJ3a/eEE9o/Q21RRV3GajFD1vNR+y RBCYVaupxl6dbRjkF9jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozZMC-0009KI-PR; Mon, 28 Nov 2022 08:19:16 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozZLr-00097I-T7 for linux-um@lists.infradead.org; Mon, 28 Nov 2022 08:19:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669623533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ueiNL/RrPlD3vRod9MDAxJpgFwmJj0Jyg8USWk7yPz8=; b=S+oFkjKVP3mckzd7VBbvH1QuZTZol0q9wTWffdsPiXu+2nmhjaLmPhu8ziCyV0KCioRPJI 5JQ7Ka6QTT7w/TcDd4C3+oasgr3fATIDGVWRdSU8qp6A71RrRGJewLWoV59J4JHfMOQ3z1 2VHUt/gcI6faTsrG8illEYtRpXcU/30= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-70-kpzA0OpRODKmP3S2TrwH8w-1; Mon, 28 Nov 2022 03:18:51 -0500 X-MC-Unique: kpzA0OpRODKmP3S2TrwH8w-1 Received: by mail-wm1-f71.google.com with SMTP id v188-20020a1cacc5000000b003cf76c4ae66so8275581wme.7 for ; Mon, 28 Nov 2022 00:18:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ueiNL/RrPlD3vRod9MDAxJpgFwmJj0Jyg8USWk7yPz8=; b=JktD0PmPwXWD9vuVA9/v9rBePvWjc+L4BY9TMw3q+PQJ/IS0ldZuBnGacLxpMqkfWQ oX0wBlVaSOz4I3zUWv1Hno8NFoyG7HCMR2IR2Enl4jzOL6pQUFjV697d3b5cQMZVC1Xu IOFJ1YC8q2/gmEXeFEDIUhRJrKQx9tn/RYXW+a0gHaFxvoCcwEhAE5frTvrAmjErlJJX secT9PD0iOlUaZPnt5Lqc353VEHBshH69A74ZBOjzv/pQmZVFU7UYt6JcyO0im/Ehqh2 XoXzLL2a4GHA7RM9YN6hk7FCKgBE3JEezJh09YRSHsuxv1WJdwT4BVl/1ZeBDuntK5V/ 4XKw== X-Gm-Message-State: ANoB5pk5jQZIe3a1xwZk2tAKaIk2g7YHBK29Xb0hgvjjf/suiqQmPGGi cFTS1poDSZprk1aRMvlGbzuc6HZxA9Viz3H7Yd/tFjdovNyCHNVPBt2PmvjgwXrf7jnmj0GYVtW Lmr22dCx27KMwRbv+KXSxcy1u X-Received: by 2002:a05:600c:3587:b0:3cf:a9c2:2b04 with SMTP id p7-20020a05600c358700b003cfa9c22b04mr36262275wmq.152.1669623530577; Mon, 28 Nov 2022 00:18:50 -0800 (PST) X-Google-Smtp-Source: AA0mqf5KFgnMS9OgeX6iNUgB1p0xskb3yOxviUW4FnLaUffslFm3du7Shktyf0rRUHCATZ7f+3nFJA== X-Received: by 2002:a05:600c:3587:b0:3cf:a9c2:2b04 with SMTP id p7-20020a05600c358700b003cfa9c22b04mr36262220wmq.152.1669623530122; Mon, 28 Nov 2022 00:18:50 -0800 (PST) Received: from ?IPV6:2003:cb:c702:9000:3d6:e434:f8b4:80cf? (p200300cbc702900003d6e434f8b480cf.dip0.t-ipconnect.de. [2003:cb:c702:9000:3d6:e434:f8b4:80cf]) by smtp.gmail.com with ESMTPSA id g14-20020a05600c310e00b003a2f2bb72d5sm22518102wmo.45.2022.11.28.00.18.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 00:18:49 -0800 (PST) Message-ID: <9d0bf98a-3d6a-1082-e992-1338e1525935@redhat.com> Date: Mon, 28 Nov 2022 09:18:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage To: Hans Verkuil , linux-kernel@vger.kernel.org, Andrew Morton Cc: x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, Linus Torvalds , Jason Gunthorpe , John Hubbard , Peter Xu , Greg Kroah-Hartman , Andrea Arcangeli , Hugh Dickins , Nadav Amit , Vlastimil Babka , Matthew Wilcox , Mike Kravetz , Muchun Song , Shuah Khan , Lucas Stach , David Airlie , Oded Gabbay , Arnd Bergmann , Christoph Hellwig , Alex Williamson , Marek Szyprowski , Tomasz Figa , Mauro Carvalho Chehab References: <20221116102659.70287-1-david@redhat.com> <20221116102659.70287-17-david@redhat.com> <81fb0fa3-2e06-b765-56ac-a7d981194e59@redhat.com> <08b65ac6-6786-1080-18f8-d2be109c85fc@xs4all.nl> From: David Hildenbrand Organization: Red Hat In-Reply-To: <08b65ac6-6786-1080-18f8-d2be109c85fc@xs4all.nl> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221128_001856_162516_458FDA55 X-CRM114-Status: GOOD ( 24.79 ) X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org T24gMjguMTEuMjIgMDk6MTcsIEhhbnMgVmVya3VpbCB3cm90ZToKPiBIaSBEYXZpZCwKPiAKPiBP biAyNy8xMS8yMDIyIDExOjM1LCBEYXZpZCBIaWxkZW5icmFuZCB3cm90ZToKPj4gT24gMTYuMTEu MjIgMTE6MjYsIERhdmlkIEhpbGRlbmJyYW5kIHdyb3RlOgo+Pj4gRk9MTF9GT1JDRSBpcyByZWFs bHkgb25seSBmb3IgcHRyYWNlIGFjY2Vzcy4gQWNjb3JkaW5nIHRvIGNvbW1pdAo+Pj4gNzA3OTQ3 MjQ3ZTk1ICgibWVkaWE6IHZpZGVvYnVmMi12bWFsbG9jOiBnZXRfdXNlcnB0cjogYnVmZmVycyBh cmUgYWx3YXlzCj4+PiB3cml0YWJsZSIpLCBnZXRfdmFkZHJfZnJhbWVzKCkgY3VycmVudGx5IHBp bnMgYWxsIHBhZ2VzIHdyaXRhYmxlIGFzIGEKPj4+IHdvcmthcm91bmQgZm9yIGlzc3VlcyB3aXRo IHJlYWQtb25seSBidWZmZXJzLgo+Pj4KPj4+IEZPTExfRk9SQ0UsIGhvd2V2ZXIsIHNlZW1zIHRv IGJlIGEgbGVnYWN5IGxlZnRvdmVyIGFzIGl0IHByZWRhdGVzCj4+PiBjb21taXQgNzA3OTQ3MjQ3 ZTk1ICgibWVkaWE6IHZpZGVvYnVmMi12bWFsbG9jOiBnZXRfdXNlcnB0cjogYnVmZmVycyBhcmUK Pj4+IGFsd2F5cyB3cml0YWJsZSIpLiBMZXQncyBqdXN0IHJlbW92ZSBpdC4KPj4+Cj4+PiBPbmNl IHRoZSByZWFkLW9ubHkgYnVmZmVyIGlzc3VlIGhhcyBiZWVuIHJlc29sdmVkLCBGT0xMX1dSSVRF IGNvdWxkCj4+PiBhZ2FpbiBiZSBzZXQgZGVwZW5kaW5nIG9uIHRoZSBETUEgZGlyZWN0aW9uLgo+ Pj4KPj4+IENjOiBIYW5zIFZlcmt1aWwgPGh2ZXJrdWlsQHhzNGFsbC5ubD4KPj4+IENjOiBNYXJl ayBTenlwcm93c2tpIDxtLnN6eXByb3dza2lAc2Ftc3VuZy5jb20+Cj4+PiBDYzogVG9tYXN6IEZp Z2EgPHRmaWdhQGNocm9taXVtLm9yZz4KPj4+IENjOiBNYXJlayBTenlwcm93c2tpIDxtLnN6eXBy b3dza2lAc2Ftc3VuZy5jb20+Cj4+PiBDYzogTWF1cm8gQ2FydmFsaG8gQ2hlaGFiIDxtY2hlaGFi QGtlcm5lbC5vcmc+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBEYXZpZCBIaWxkZW5icmFuZCA8ZGF2aWRA cmVkaGF0LmNvbT4KPj4+IC0tLQo+Pj4gIMKgIGRyaXZlcnMvbWVkaWEvY29tbW9uL3ZpZGVvYnVm Mi9mcmFtZV92ZWN0b3IuYyB8IDIgKy0KPj4+ICDCoCAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRp b24oKyksIDEgZGVsZXRpb24oLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZWRpYS9j b21tb24vdmlkZW9idWYyL2ZyYW1lX3ZlY3Rvci5jIGIvZHJpdmVycy9tZWRpYS9jb21tb24vdmlk ZW9idWYyL2ZyYW1lX3ZlY3Rvci5jCj4+PiBpbmRleCA1NDJkZGU5ZDI2MDkuLjA2MmU5ODE0OGM1 MyAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvbWVkaWEvY29tbW9uL3ZpZGVvYnVmMi9mcmFtZV92 ZWN0b3IuYwo+Pj4gKysrIGIvZHJpdmVycy9tZWRpYS9jb21tb24vdmlkZW9idWYyL2ZyYW1lX3Zl Y3Rvci5jCj4+PiBAQCAtNTAsNyArNTAsNyBAQCBpbnQgZ2V0X3ZhZGRyX2ZyYW1lcyh1bnNpZ25l ZCBsb25nIHN0YXJ0LCB1bnNpZ25lZCBpbnQgbnJfZnJhbWVzLAo+Pj4gIMKgwqDCoMKgwqAgc3Rh cnQgPSB1bnRhZ2dlZF9hZGRyKHN0YXJ0KTsKPj4+ICDCoCDCoMKgwqDCoMKgIHJldCA9IHBpbl91 c2VyX3BhZ2VzX2Zhc3Qoc3RhcnQsIG5yX2ZyYW1lcywKPj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIEZPTExfRk9SQ0UgfCBGT0xMX1dSSVRFIHwgRk9MTF9MT05HVEVSTSwK Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIEZPTExfV1JJVEUgfCBGT0xM X0xPTkdURVJNLAo+Pj4gIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChz dHJ1Y3QgcGFnZSAqKikodmVjLT5wdHJzKSk7Cj4+PiAgwqDCoMKgwqDCoCBpZiAocmV0ID4gMCkg ewo+Pj4gIMKgwqDCoMKgwqDCoMKgwqDCoCB2ZWMtPmdvdF9yZWYgPSB0cnVlOwo+Pgo+Pgo+PiBI aSBBbmRyZXcsCj4+Cj4+IHNlZSB0aGUgZGlzY3Vzc2lvbiBhdCBbMV0gcmVnYXJkaW5nIGEgY29u ZmxpY3QgYW5kIGhvdyB0byBwcm9jZWVkIHdpdGgKPj4gdXBzdHJlYW1pbmcuIFRoZSBjb25mbGlj dCB3b3VsZCBiZSBlYXN5IHRvIHJlc29sdmUsIGhvd2V2ZXIsIGFsc28KPj4gdGhlIHBhdGNoIGRl c2NyaXB0aW9uIGRvZXNuJ3QgbWFrZSBzZW5zZSBhbnltb3JlIHdpdGggWzFdLgo+IAo+IE1pZ2h0 IGl0IGJlIGVhc2llciBhbmQgbGVzcyBjb25mdXNpbmcgaWYgeW91IHBvc3QgYSB2MiBvZiB0aGlz IHNlcmllcwo+IHdpdGggbXkgcGF0Y2ggZmlyc3Q/IFRoYXQgd2F5IGl0IGlzIGNsZWFyIHRoYXQg MSkgbXkgcGF0Y2ggaGFzIHRvIGNvbWUKPiBmaXJzdCwgYW5kIDIpIHRoYXQgaXQgaXMgcGFydCBv ZiBhIHNpbmdsZSBzZXJpZXMgYW5kIHNob3VsZCBiZSBtZXJnZWQKPiBieSB0aGUgbW0gc3Vic3lz dGVtLgo+IAo+IExlc3MgY2hhbmNlcyBvZiB0aGluZ3MgZ29pbmcgd3JvbmcgdGhhdCB3YXkuCj4g Cj4gSnVzdCBtZW50aW9uIGluIHRoZSB2MiBjb3ZlciBsZXR0ZXIgdGhhdCB0aGUgZmlyc3QgcGF0 Y2ggd2FzIGFkZGVkIHRvCj4gbWFrZSBpdCBlYXN5IHRvIGJhY2twb3J0IHRoYXQgZml4IHdpdGhv dXQgYmVpbmcgaGFtcGVyZWQgYnkgbWVyZ2UKPiBjb25mbGljdHMgaWYgaXQgd2FzIGFkZGVkIGFm dGVyIHlvdXIgZnJhbWVfdmVjdG9yLmMgcGF0Y2guCgpZZXMsIHRoYXQncyB0aGUgd2F5IEkgd291 bGQgbmF0dXJhbGx5IGRvLCBpdCwgaG93ZXZlciwgQW5kcmV3IHByZWZlcnMgCmRlbHRhIHVwZGF0 ZXMgZm9yIG1pbm9yIGNoYW5nZXMuCgpAQW5kcmV3LCB3aGF0ZXZlciB5b3UgcHJlZmVyIQoKVGhh bmtzIQoKLS0gClRoYW5rcywKCkRhdmlkIC8gZGhpbGRlbmIKCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC11bSBtYWlsaW5nIGxpc3QKbGludXgt dW1AbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LXVtCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D35DC4332F for ; Mon, 28 Nov 2022 08:19:56 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4NLJL30XqKz3cG1 for ; Mon, 28 Nov 2022 19:19:55 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=S+oFkjKV; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=S+oFkjKV; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=david@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=S+oFkjKV; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=S+oFkjKV; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4NLJJz1gM6z2xGn for ; Mon, 28 Nov 2022 19:18:57 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669623533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ueiNL/RrPlD3vRod9MDAxJpgFwmJj0Jyg8USWk7yPz8=; b=S+oFkjKVP3mckzd7VBbvH1QuZTZol0q9wTWffdsPiXu+2nmhjaLmPhu8ziCyV0KCioRPJI 5JQ7Ka6QTT7w/TcDd4C3+oasgr3fATIDGVWRdSU8qp6A71RrRGJewLWoV59J4JHfMOQ3z1 2VHUt/gcI6faTsrG8illEYtRpXcU/30= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669623533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ueiNL/RrPlD3vRod9MDAxJpgFwmJj0Jyg8USWk7yPz8=; b=S+oFkjKVP3mckzd7VBbvH1QuZTZol0q9wTWffdsPiXu+2nmhjaLmPhu8ziCyV0KCioRPJI 5JQ7Ka6QTT7w/TcDd4C3+oasgr3fATIDGVWRdSU8qp6A71RrRGJewLWoV59J4JHfMOQ3z1 2VHUt/gcI6faTsrG8illEYtRpXcU/30= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-517-_Ftb84oTNae2uPyTh7debQ-1; Mon, 28 Nov 2022 03:18:51 -0500 X-MC-Unique: _Ftb84oTNae2uPyTh7debQ-1 Received: by mail-wm1-f72.google.com with SMTP id f1-20020a1cc901000000b003cf703a4f08so3477298wmb.2 for ; Mon, 28 Nov 2022 00:18:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ueiNL/RrPlD3vRod9MDAxJpgFwmJj0Jyg8USWk7yPz8=; b=EemMFYOJzrHcYZ77eR1njMfBqIpPZHMimFDBiHBgRnfMvGmH5nxsULMEtKiIJ2tsBy 1rhRCSiAacXq7ER4GayU42tLYx5xWYV03AUsYpTNabMoFORKs6JNR6tF5gZHEmrnlCUZ 7C6giJJKauFaOS9t3LhWPgN6TS1t5gDdYn2tnxPyL6Y/fYL7+708E5xa/rTS5VgzCcE0 ZyF5XvlIMrWeyFuiRIs1aBSjV3GqW+c86ijdC+MZDHnL8UnN0oB+cQ6TUYJNeSRCgAdo CtHgTcZRRSmDsxL7GnGIKlR4ECvQQHKYE+avGAOZRLWJoyo7kg2sHMXFpkP+FQTDyCUP sKXg== X-Gm-Message-State: ANoB5pl7KRZb5fFntye0eclhVMgOpR7ZBB8K3Y/bSHy8wOZ9SQtAJ1ni WtRPH7qG6bS3QR0DDlTWgspF8mlsMggaLOurFOw3OTnoj+BTrHQk+PVmEXMijZ2hGUGT8rrzFo5 9tH/BvI5op8ctclPAPzZXEW1Maw== X-Received: by 2002:a05:600c:3587:b0:3cf:a9c2:2b04 with SMTP id p7-20020a05600c358700b003cfa9c22b04mr36262261wmq.152.1669623530561; Mon, 28 Nov 2022 00:18:50 -0800 (PST) X-Google-Smtp-Source: AA0mqf5KFgnMS9OgeX6iNUgB1p0xskb3yOxviUW4FnLaUffslFm3du7Shktyf0rRUHCATZ7f+3nFJA== X-Received: by 2002:a05:600c:3587:b0:3cf:a9c2:2b04 with SMTP id p7-20020a05600c358700b003cfa9c22b04mr36262220wmq.152.1669623530122; Mon, 28 Nov 2022 00:18:50 -0800 (PST) Received: from ?IPV6:2003:cb:c702:9000:3d6:e434:f8b4:80cf? (p200300cbc702900003d6e434f8b480cf.dip0.t-ipconnect.de. [2003:cb:c702:9000:3d6:e434:f8b4:80cf]) by smtp.gmail.com with ESMTPSA id g14-20020a05600c310e00b003a2f2bb72d5sm22518102wmo.45.2022.11.28.00.18.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 00:18:49 -0800 (PST) Message-ID: <9d0bf98a-3d6a-1082-e992-1338e1525935@redhat.com> Date: Mon, 28 Nov 2022 09:18:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage To: Hans Verkuil , linux-kernel@vger.kernel.org, Andrew Morton References: <20221116102659.70287-1-david@redhat.com> <20221116102659.70287-17-david@redhat.com> <81fb0fa3-2e06-b765-56ac-a7d981194e59@redhat.com> <08b65ac6-6786-1080-18f8-d2be109c85fc@xs4all.nl> From: David Hildenbrand Organization: Red Hat In-Reply-To: <08b65ac6-6786-1080-18f8-d2be109c85fc@xs4all.nl> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-ia64@vger.kernel.org, Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Nadav Amit , linux-kselftest@vger.kernel.org, sparclinux@vger.kernel.org, Shuah Khan , Marek Szyprowski , Andrea Arcangeli , linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, David Airlie , x86@kernel.org, Hugh Dickins , Matthew Wilcox , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , linux-media@vger.kernel.org, Arnd Bergmann , John Hubbard , linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, Alex Williamson , Peter Xu , Muchun Song , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linuxppc-dev @lists.ozlabs.org, Oded Gabbay , linux-mips@vger.kernel.org, Tomasz Figa , linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, linux-alpha@vger.kernel.org, linux-fsdevel@vger.kernel.org, Lucas Stach , Linus Torvalds , Mike Kravetz Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 28.11.22 09:17, Hans Verkuil wrote: > Hi David, > > On 27/11/2022 11:35, David Hildenbrand wrote: >> On 16.11.22 11:26, David Hildenbrand wrote: >>> FOLL_FORCE is really only for ptrace access. According to commit >>> 707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers are always >>> writable"), get_vaddr_frames() currently pins all pages writable as a >>> workaround for issues with read-only buffers. >>> >>> FOLL_FORCE, however, seems to be a legacy leftover as it predates >>> commit 707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers are >>> always writable"). Let's just remove it. >>> >>> Once the read-only buffer issue has been resolved, FOLL_WRITE could >>> again be set depending on the DMA direction. >>> >>> Cc: Hans Verkuil >>> Cc: Marek Szyprowski >>> Cc: Tomasz Figa >>> Cc: Marek Szyprowski >>> Cc: Mauro Carvalho Chehab >>> Signed-off-by: David Hildenbrand >>> --- >>>   drivers/media/common/videobuf2/frame_vector.c | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/media/common/videobuf2/frame_vector.c b/drivers/media/common/videobuf2/frame_vector.c >>> index 542dde9d2609..062e98148c53 100644 >>> --- a/drivers/media/common/videobuf2/frame_vector.c >>> +++ b/drivers/media/common/videobuf2/frame_vector.c >>> @@ -50,7 +50,7 @@ int get_vaddr_frames(unsigned long start, unsigned int nr_frames, >>>       start = untagged_addr(start); >>>         ret = pin_user_pages_fast(start, nr_frames, >>> -                  FOLL_FORCE | FOLL_WRITE | FOLL_LONGTERM, >>> +                  FOLL_WRITE | FOLL_LONGTERM, >>>                     (struct page **)(vec->ptrs)); >>>       if (ret > 0) { >>>           vec->got_ref = true; >> >> >> Hi Andrew, >> >> see the discussion at [1] regarding a conflict and how to proceed with >> upstreaming. The conflict would be easy to resolve, however, also >> the patch description doesn't make sense anymore with [1]. > > Might it be easier and less confusing if you post a v2 of this series > with my patch first? That way it is clear that 1) my patch has to come > first, and 2) that it is part of a single series and should be merged > by the mm subsystem. > > Less chances of things going wrong that way. > > Just mention in the v2 cover letter that the first patch was added to > make it easy to backport that fix without being hampered by merge > conflicts if it was added after your frame_vector.c patch. Yes, that's the way I would naturally do, it, however, Andrew prefers delta updates for minor changes. @Andrew, whatever you prefer! Thanks! -- Thanks, David / dhildenb From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5FE7C46467 for ; Mon, 28 Nov 2022 08:20:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w1kgPM2O0RF+j75ATsYc/ct6Kf/0uxBxj8jD3YiktTA=; b=LSGOyW9YzCSpOt YxGSSbB4QvgcGHphJnbKGNFlZjB/PIUG71X+4O72OYN5EhQmIYoSExw60GlqYVKCchrDV60lyOT2U DS16RsWSIcmENhZj0HaTS1RFsxWDxL5hHQjs6/6eZwHmFaxoOWT/SfPxBE4vHFKar+uNbp4qvkeWn yB2JvPMnVP9kb+OWQfZp8eKYqzexDK8o/PMvNfBPkkm2CQGq1EuJTG4cg1ens/lqJGvyX39bEacbo K2XOFIuSLbIrV4uyELGut2M+l31DHQvEbRd+Mv3BBEK+uvNDqRS6zSu0LxIvovmdVeDp1Te0euPKE UAQC0bT6GEwsxMb2gZNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozZLy-0009Cv-8O; Mon, 28 Nov 2022 08:19:03 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozZLr-00097J-T9 for linux-arm-kernel@lists.infradead.org; Mon, 28 Nov 2022 08:18:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669623533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ueiNL/RrPlD3vRod9MDAxJpgFwmJj0Jyg8USWk7yPz8=; b=S+oFkjKVP3mckzd7VBbvH1QuZTZol0q9wTWffdsPiXu+2nmhjaLmPhu8ziCyV0KCioRPJI 5JQ7Ka6QTT7w/TcDd4C3+oasgr3fATIDGVWRdSU8qp6A71RrRGJewLWoV59J4JHfMOQ3z1 2VHUt/gcI6faTsrG8illEYtRpXcU/30= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-517-op85EPUcN96KF1nRNgdTCw-1; Mon, 28 Nov 2022 03:18:51 -0500 X-MC-Unique: op85EPUcN96KF1nRNgdTCw-1 Received: by mail-wm1-f70.google.com with SMTP id z18-20020a05600c221200b003cf7fcc286aso3478167wml.1 for ; Mon, 28 Nov 2022 00:18:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ueiNL/RrPlD3vRod9MDAxJpgFwmJj0Jyg8USWk7yPz8=; b=hi4WJfCBx4wps+uT1UEOcvBYWiiwSz5mByfuIGvUd1EGdKv/qftNc6ASPZH59QJuqn OTFG9IUK4+zbksxtidaGZaIwBuxom3mAKAKSGhJNZiaQz4wgPohCDgdqjMp3HMEKe8l/ xRGsgZ41H1gM9IONNz1gaHotatPqAbnBMDD2J0IuuSf58nDXlClQVdgp/HEKDk+rJNvG V3Mg6Qb3rx32RKhzG8oR80gOnHXntEM5GxaZ/sASuo/uaLUBD3FglOxDhqstsgj6DgW1 rZT89mANvaUbLEjFEnjzCPvUePdM8XPtNdeJuus9r0esVYek+4859v2lRM3RpSNJRb3T FqFw== X-Gm-Message-State: ANoB5pkhGk9+BiaNfdM3ilKyW5mX7efS2KSVuQb1zw7lFQ1FcxqEr/tZ Wzr+9Y1JOlAvHD8QSw+6oboM2G+YYfiF1nEH9Q1YwnI7FRn3lq7+Bfw6bcN8AXvTDwjpVMjptCg upMCSsPoUgE+NavvLIvxToI8NrWZEG+4fPn0= X-Received: by 2002:a05:600c:3587:b0:3cf:a9c2:2b04 with SMTP id p7-20020a05600c358700b003cfa9c22b04mr36262251wmq.152.1669623530544; Mon, 28 Nov 2022 00:18:50 -0800 (PST) X-Google-Smtp-Source: AA0mqf5KFgnMS9OgeX6iNUgB1p0xskb3yOxviUW4FnLaUffslFm3du7Shktyf0rRUHCATZ7f+3nFJA== X-Received: by 2002:a05:600c:3587:b0:3cf:a9c2:2b04 with SMTP id p7-20020a05600c358700b003cfa9c22b04mr36262220wmq.152.1669623530122; Mon, 28 Nov 2022 00:18:50 -0800 (PST) Received: from ?IPV6:2003:cb:c702:9000:3d6:e434:f8b4:80cf? (p200300cbc702900003d6e434f8b480cf.dip0.t-ipconnect.de. [2003:cb:c702:9000:3d6:e434:f8b4:80cf]) by smtp.gmail.com with ESMTPSA id g14-20020a05600c310e00b003a2f2bb72d5sm22518102wmo.45.2022.11.28.00.18.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 00:18:49 -0800 (PST) Message-ID: <9d0bf98a-3d6a-1082-e992-1338e1525935@redhat.com> Date: Mon, 28 Nov 2022 09:18:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage To: Hans Verkuil , linux-kernel@vger.kernel.org, Andrew Morton Cc: x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, Linus Torvalds , Jason Gunthorpe , John Hubbard , Peter Xu , Greg Kroah-Hartman , Andrea Arcangeli , Hugh Dickins , Nadav Amit , Vlastimil Babka , Matthew Wilcox , Mike Kravetz , Muchun Song , Shuah Khan , Lucas Stach , David Airlie , Oded Gabbay , Arnd Bergmann , Christoph Hellwig , Alex Williamson , Marek Szyprowski , Tomasz Figa , Mauro Carvalho Chehab References: <20221116102659.70287-1-david@redhat.com> <20221116102659.70287-17-david@redhat.com> <81fb0fa3-2e06-b765-56ac-a7d981194e59@redhat.com> <08b65ac6-6786-1080-18f8-d2be109c85fc@xs4all.nl> From: David Hildenbrand Organization: Red Hat In-Reply-To: <08b65ac6-6786-1080-18f8-d2be109c85fc@xs4all.nl> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221128_001856_110809_7A01BE05 X-CRM114-Status: GOOD ( 26.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjguMTEuMjIgMDk6MTcsIEhhbnMgVmVya3VpbCB3cm90ZToKPiBIaSBEYXZpZCwKPiAKPiBP biAyNy8xMS8yMDIyIDExOjM1LCBEYXZpZCBIaWxkZW5icmFuZCB3cm90ZToKPj4gT24gMTYuMTEu MjIgMTE6MjYsIERhdmlkIEhpbGRlbmJyYW5kIHdyb3RlOgo+Pj4gRk9MTF9GT1JDRSBpcyByZWFs bHkgb25seSBmb3IgcHRyYWNlIGFjY2Vzcy4gQWNjb3JkaW5nIHRvIGNvbW1pdAo+Pj4gNzA3OTQ3 MjQ3ZTk1ICgibWVkaWE6IHZpZGVvYnVmMi12bWFsbG9jOiBnZXRfdXNlcnB0cjogYnVmZmVycyBh cmUgYWx3YXlzCj4+PiB3cml0YWJsZSIpLCBnZXRfdmFkZHJfZnJhbWVzKCkgY3VycmVudGx5IHBp bnMgYWxsIHBhZ2VzIHdyaXRhYmxlIGFzIGEKPj4+IHdvcmthcm91bmQgZm9yIGlzc3VlcyB3aXRo IHJlYWQtb25seSBidWZmZXJzLgo+Pj4KPj4+IEZPTExfRk9SQ0UsIGhvd2V2ZXIsIHNlZW1zIHRv IGJlIGEgbGVnYWN5IGxlZnRvdmVyIGFzIGl0IHByZWRhdGVzCj4+PiBjb21taXQgNzA3OTQ3MjQ3 ZTk1ICgibWVkaWE6IHZpZGVvYnVmMi12bWFsbG9jOiBnZXRfdXNlcnB0cjogYnVmZmVycyBhcmUK Pj4+IGFsd2F5cyB3cml0YWJsZSIpLiBMZXQncyBqdXN0IHJlbW92ZSBpdC4KPj4+Cj4+PiBPbmNl IHRoZSByZWFkLW9ubHkgYnVmZmVyIGlzc3VlIGhhcyBiZWVuIHJlc29sdmVkLCBGT0xMX1dSSVRF IGNvdWxkCj4+PiBhZ2FpbiBiZSBzZXQgZGVwZW5kaW5nIG9uIHRoZSBETUEgZGlyZWN0aW9uLgo+ Pj4KPj4+IENjOiBIYW5zIFZlcmt1aWwgPGh2ZXJrdWlsQHhzNGFsbC5ubD4KPj4+IENjOiBNYXJl ayBTenlwcm93c2tpIDxtLnN6eXByb3dza2lAc2Ftc3VuZy5jb20+Cj4+PiBDYzogVG9tYXN6IEZp Z2EgPHRmaWdhQGNocm9taXVtLm9yZz4KPj4+IENjOiBNYXJlayBTenlwcm93c2tpIDxtLnN6eXBy b3dza2lAc2Ftc3VuZy5jb20+Cj4+PiBDYzogTWF1cm8gQ2FydmFsaG8gQ2hlaGFiIDxtY2hlaGFi QGtlcm5lbC5vcmc+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBEYXZpZCBIaWxkZW5icmFuZCA8ZGF2aWRA cmVkaGF0LmNvbT4KPj4+IC0tLQo+Pj4gIMKgIGRyaXZlcnMvbWVkaWEvY29tbW9uL3ZpZGVvYnVm Mi9mcmFtZV92ZWN0b3IuYyB8IDIgKy0KPj4+ICDCoCAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRp b24oKyksIDEgZGVsZXRpb24oLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZWRpYS9j b21tb24vdmlkZW9idWYyL2ZyYW1lX3ZlY3Rvci5jIGIvZHJpdmVycy9tZWRpYS9jb21tb24vdmlk ZW9idWYyL2ZyYW1lX3ZlY3Rvci5jCj4+PiBpbmRleCA1NDJkZGU5ZDI2MDkuLjA2MmU5ODE0OGM1 MyAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvbWVkaWEvY29tbW9uL3ZpZGVvYnVmMi9mcmFtZV92 ZWN0b3IuYwo+Pj4gKysrIGIvZHJpdmVycy9tZWRpYS9jb21tb24vdmlkZW9idWYyL2ZyYW1lX3Zl Y3Rvci5jCj4+PiBAQCAtNTAsNyArNTAsNyBAQCBpbnQgZ2V0X3ZhZGRyX2ZyYW1lcyh1bnNpZ25l ZCBsb25nIHN0YXJ0LCB1bnNpZ25lZCBpbnQgbnJfZnJhbWVzLAo+Pj4gIMKgwqDCoMKgwqAgc3Rh cnQgPSB1bnRhZ2dlZF9hZGRyKHN0YXJ0KTsKPj4+ICDCoCDCoMKgwqDCoMKgIHJldCA9IHBpbl91 c2VyX3BhZ2VzX2Zhc3Qoc3RhcnQsIG5yX2ZyYW1lcywKPj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIEZPTExfRk9SQ0UgfCBGT0xMX1dSSVRFIHwgRk9MTF9MT05HVEVSTSwK Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIEZPTExfV1JJVEUgfCBGT0xM X0xPTkdURVJNLAo+Pj4gIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChz dHJ1Y3QgcGFnZSAqKikodmVjLT5wdHJzKSk7Cj4+PiAgwqDCoMKgwqDCoCBpZiAocmV0ID4gMCkg ewo+Pj4gIMKgwqDCoMKgwqDCoMKgwqDCoCB2ZWMtPmdvdF9yZWYgPSB0cnVlOwo+Pgo+Pgo+PiBI aSBBbmRyZXcsCj4+Cj4+IHNlZSB0aGUgZGlzY3Vzc2lvbiBhdCBbMV0gcmVnYXJkaW5nIGEgY29u ZmxpY3QgYW5kIGhvdyB0byBwcm9jZWVkIHdpdGgKPj4gdXBzdHJlYW1pbmcuIFRoZSBjb25mbGlj dCB3b3VsZCBiZSBlYXN5IHRvIHJlc29sdmUsIGhvd2V2ZXIsIGFsc28KPj4gdGhlIHBhdGNoIGRl c2NyaXB0aW9uIGRvZXNuJ3QgbWFrZSBzZW5zZSBhbnltb3JlIHdpdGggWzFdLgo+IAo+IE1pZ2h0 IGl0IGJlIGVhc2llciBhbmQgbGVzcyBjb25mdXNpbmcgaWYgeW91IHBvc3QgYSB2MiBvZiB0aGlz IHNlcmllcwo+IHdpdGggbXkgcGF0Y2ggZmlyc3Q/IFRoYXQgd2F5IGl0IGlzIGNsZWFyIHRoYXQg MSkgbXkgcGF0Y2ggaGFzIHRvIGNvbWUKPiBmaXJzdCwgYW5kIDIpIHRoYXQgaXQgaXMgcGFydCBv ZiBhIHNpbmdsZSBzZXJpZXMgYW5kIHNob3VsZCBiZSBtZXJnZWQKPiBieSB0aGUgbW0gc3Vic3lz dGVtLgo+IAo+IExlc3MgY2hhbmNlcyBvZiB0aGluZ3MgZ29pbmcgd3JvbmcgdGhhdCB3YXkuCj4g Cj4gSnVzdCBtZW50aW9uIGluIHRoZSB2MiBjb3ZlciBsZXR0ZXIgdGhhdCB0aGUgZmlyc3QgcGF0 Y2ggd2FzIGFkZGVkIHRvCj4gbWFrZSBpdCBlYXN5IHRvIGJhY2twb3J0IHRoYXQgZml4IHdpdGhv dXQgYmVpbmcgaGFtcGVyZWQgYnkgbWVyZ2UKPiBjb25mbGljdHMgaWYgaXQgd2FzIGFkZGVkIGFm dGVyIHlvdXIgZnJhbWVfdmVjdG9yLmMgcGF0Y2guCgpZZXMsIHRoYXQncyB0aGUgd2F5IEkgd291 bGQgbmF0dXJhbGx5IGRvLCBpdCwgaG93ZXZlciwgQW5kcmV3IHByZWZlcnMgCmRlbHRhIHVwZGF0 ZXMgZm9yIG1pbm9yIGNoYW5nZXMuCgpAQW5kcmV3LCB3aGF0ZXZlciB5b3UgcHJlZmVyIQoKVGhh bmtzIQoKLS0gClRoYW5rcywKCkRhdmlkIC8gZGhpbGRlbmIKCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlz dApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 415DDC433FE for ; Mon, 28 Nov 2022 08:19:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 71EC710E2A2; Mon, 28 Nov 2022 08:19:00 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id C08D110E2A2 for ; Mon, 28 Nov 2022 08:18:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669623533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ueiNL/RrPlD3vRod9MDAxJpgFwmJj0Jyg8USWk7yPz8=; b=S+oFkjKVP3mckzd7VBbvH1QuZTZol0q9wTWffdsPiXu+2nmhjaLmPhu8ziCyV0KCioRPJI 5JQ7Ka6QTT7w/TcDd4C3+oasgr3fATIDGVWRdSU8qp6A71RrRGJewLWoV59J4JHfMOQ3z1 2VHUt/gcI6faTsrG8illEYtRpXcU/30= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-371-HNE5cGRrMYejrAP2KXVT2Q-1; Mon, 28 Nov 2022 03:18:51 -0500 X-MC-Unique: HNE5cGRrMYejrAP2KXVT2Q-1 Received: by mail-wm1-f72.google.com with SMTP id e8-20020a05600c218800b003cf634f5280so3470231wme.8 for ; Mon, 28 Nov 2022 00:18:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ueiNL/RrPlD3vRod9MDAxJpgFwmJj0Jyg8USWk7yPz8=; b=4pmaYVgl3QReLi+ke4wDQ7ofNONWUx48xQ1Tgj87siakkWuLDY+68aChgJkxOayhhZ NhuIWS/6E+PdkVL2pMR4BNPodkPo4jOejG8H5763uuwqODsa5ewMyLzI6NxZwg45nL89 Aouio3NGtcje3rAzrmCkb+nv6bNbilMCO2rNL6e3pYF+pDIEpW3IjnN7rtyhOi7H/5Un rp0129lK7rmM8y0cXGEdCJwmhmj5qpP3DGD1IxZKdl2Ku0AwI4ps+lazNI7F1e9KZJqL gK2Mvj8vLxioijFTlAFCA/PxWUW3/5Kik0gCCZ1Bg2aC5vpl16QCMiDPU7ODVTp4+95w Fadw== X-Gm-Message-State: ANoB5pnhw9Elrbt25WXBa52+EGtUEQ7IEfyfxhYYkvVcLIUvwyyU8KGd /myGBefhNi7p150qm5Ec95hhdfzYCaODaepZXTGgpteDnvJR1HMjLhKMSnW6itm6SctvVuOeUhm fjgnkdowU8Dw1w9m+xtkTJwfh8ULk X-Received: by 2002:a05:600c:3587:b0:3cf:a9c2:2b04 with SMTP id p7-20020a05600c358700b003cfa9c22b04mr36262272wmq.152.1669623530573; Mon, 28 Nov 2022 00:18:50 -0800 (PST) X-Google-Smtp-Source: AA0mqf5KFgnMS9OgeX6iNUgB1p0xskb3yOxviUW4FnLaUffslFm3du7Shktyf0rRUHCATZ7f+3nFJA== X-Received: by 2002:a05:600c:3587:b0:3cf:a9c2:2b04 with SMTP id p7-20020a05600c358700b003cfa9c22b04mr36262220wmq.152.1669623530122; Mon, 28 Nov 2022 00:18:50 -0800 (PST) Received: from ?IPV6:2003:cb:c702:9000:3d6:e434:f8b4:80cf? (p200300cbc702900003d6e434f8b480cf.dip0.t-ipconnect.de. [2003:cb:c702:9000:3d6:e434:f8b4:80cf]) by smtp.gmail.com with ESMTPSA id g14-20020a05600c310e00b003a2f2bb72d5sm22518102wmo.45.2022.11.28.00.18.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 00:18:49 -0800 (PST) Message-ID: <9d0bf98a-3d6a-1082-e992-1338e1525935@redhat.com> Date: Mon, 28 Nov 2022 09:18:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage To: Hans Verkuil , linux-kernel@vger.kernel.org, Andrew Morton References: <20221116102659.70287-1-david@redhat.com> <20221116102659.70287-17-david@redhat.com> <81fb0fa3-2e06-b765-56ac-a7d981194e59@redhat.com> <08b65ac6-6786-1080-18f8-d2be109c85fc@xs4all.nl> From: David Hildenbrand Organization: Red Hat In-Reply-To: <08b65ac6-6786-1080-18f8-d2be109c85fc@xs4all.nl> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-ia64@vger.kernel.org, Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Nadav Amit , linux-kselftest@vger.kernel.org, sparclinux@vger.kernel.org, Shuah Khan , Marek Szyprowski , Andrea Arcangeli , linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, x86@kernel.org, Hugh Dickins , Matthew Wilcox , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , linux-media@vger.kernel.org, Arnd Bergmann , John Hubbard , linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, Alex Williamson , Peter Xu , Muchun Song , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Oded Gabbay , linux-mips@vger.kernel.org, Tomasz Figa , linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, linux-alpha@vger.kernel.org, linux-fsdevel@vger.kernel.org, Linus Torvalds , Mike Kravetz Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 28.11.22 09:17, Hans Verkuil wrote: > Hi David, > > On 27/11/2022 11:35, David Hildenbrand wrote: >> On 16.11.22 11:26, David Hildenbrand wrote: >>> FOLL_FORCE is really only for ptrace access. According to commit >>> 707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers are always >>> writable"), get_vaddr_frames() currently pins all pages writable as a >>> workaround for issues with read-only buffers. >>> >>> FOLL_FORCE, however, seems to be a legacy leftover as it predates >>> commit 707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers are >>> always writable"). Let's just remove it. >>> >>> Once the read-only buffer issue has been resolved, FOLL_WRITE could >>> again be set depending on the DMA direction. >>> >>> Cc: Hans Verkuil >>> Cc: Marek Szyprowski >>> Cc: Tomasz Figa >>> Cc: Marek Szyprowski >>> Cc: Mauro Carvalho Chehab >>> Signed-off-by: David Hildenbrand >>> --- >>>   drivers/media/common/videobuf2/frame_vector.c | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/media/common/videobuf2/frame_vector.c b/drivers/media/common/videobuf2/frame_vector.c >>> index 542dde9d2609..062e98148c53 100644 >>> --- a/drivers/media/common/videobuf2/frame_vector.c >>> +++ b/drivers/media/common/videobuf2/frame_vector.c >>> @@ -50,7 +50,7 @@ int get_vaddr_frames(unsigned long start, unsigned int nr_frames, >>>       start = untagged_addr(start); >>>         ret = pin_user_pages_fast(start, nr_frames, >>> -                  FOLL_FORCE | FOLL_WRITE | FOLL_LONGTERM, >>> +                  FOLL_WRITE | FOLL_LONGTERM, >>>                     (struct page **)(vec->ptrs)); >>>       if (ret > 0) { >>>           vec->got_ref = true; >> >> >> Hi Andrew, >> >> see the discussion at [1] regarding a conflict and how to proceed with >> upstreaming. The conflict would be easy to resolve, however, also >> the patch description doesn't make sense anymore with [1]. > > Might it be easier and less confusing if you post a v2 of this series > with my patch first? That way it is clear that 1) my patch has to come > first, and 2) that it is part of a single series and should be merged > by the mm subsystem. > > Less chances of things going wrong that way. > > Just mention in the v2 cover letter that the first patch was added to > make it easy to backport that fix without being hampered by merge > conflicts if it was added after your frame_vector.c patch. Yes, that's the way I would naturally do, it, however, Andrew prefers delta updates for minor changes. @Andrew, whatever you prefer! Thanks! -- Thanks, David / dhildenb