Re: [PATCH] symbols: explicitly specify source file name for symtab

[Oleksii Kurochko <oleksii.kurochko@gmail.com>]

On 5/11/26 12:00 PM, Jan Beulich wrote:
> If there are any local symbols in an object file, GNU ld will create an
> STT_FILE symbol derived from the object file name if there is none in the
> incoming symbol table. The object file name, however, varies between
> linking passes. As a result, symbol name compression can yield different
> results if any of those local symbols need retaining (Arm [and RISC-V]
> mapping symbols are omitted, for example). If that difference in
> compression would yield a difference in the sizes of symbol_names[] or
> symbols_token_table[], the compare-symbol-tables sanity check will fail.
> 
> Fixes: d37d63d4b548 ("symbols: prefix static symbols with their source file names")
> Reported-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

I would like to note that with the current staging I can't reproduce 
this bug anymore with configs I have:

10d417b8b62e (HEAD -> staging, upstream/staging) xen/arm: skip holes in 
physical address space when setting up frametable
2611377cf9c9 xen/riscv: fix MMIO alignment check in imsic_init()
54ca0aadc821 x86/time: make do_settime() uses more accurate
4526d6763466 x86/time: make early NOW() uses slightly more precise
9f976dec039c xen: introduce CONFIG_HAS_DOMAIN_TYPE
bdb30883f352 iommu/amd-vi: do not zero IOMMU MMIO region
4f9457ece11a xsm/flask: Fix undefined behaviour in avc_dump_av()
4ff927133ebc EFI: adjust cfg file buffer freeing
96ffccef5a5f xvmalloc: adjust XVFREE() ordering
e8c1feab33cb CI: Refresh the Debian 12 cppcheck container
278953f6c155 (origin/staging, origin/HEAD) automation/gitlab: introduce 
macOS build jobs

But when I switched to origin/HEAD I can reproduce the bug and I applied 
the suggested patch on top of it and I don't see this bug anymore with 
this fix:
   Tested-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>

Thanks.

~ Oleksii