From: Damien Le Moal <dlemoal@kernel.org>
To: Niklas Cassel <cassel@kernel.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata: libata-core: remove two WDC BROKEN_HPA quirks that never match
Date: Tue, 17 Nov 2026 05:07:29 -0800 [thread overview]
Message-ID: <9d63ded7-c5a9-4bd0-9e3a-7dcb6579f900@kernel.org> (raw)
In-Reply-To: <20261117130238.3472718-2-cassel@kernel.org>
On 11/17/26 05:02, Niklas Cassel wrote:
> The second field of a __ata_dev_quirks[] entry is matched against the
> firmware revision of the device, which ata_dev_quirks() reads into a
> buffer of ATA_ID_FW_REV_LEN (8) characters. The ATA_QUIRK_BROKEN_HPA
> entries for "WDC WD3200JD-00KLB0" and "WDC WD2500JD-00HBB0" instead
> contain "WD-WCAMR1130137" and "WD-WMAL71490727", which look like drive
> serial numbers. Without wildcards, these 15 character patterns can never
> match a firmware revision, so the two entries have not applied to any
> drive since they were added in commit 16c55b038033 ("libata: implement
> BROKEN_HPA horkage and apply it to affected drives").
>
> Remove them. The quirks applied to all drives are unchanged: these
> models keep getting their quirks from the "WDC WD2500JD-*" and
> "WDC WD3200JD-*" entries.
>
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2026-11-17 13:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 13:02 [PATCH] ata: libata-core: remove two WDC BROKEN_HPA quirks that never match Niklas Cassel
2026-11-17 13:07 ` Damien Le Moal [this message]
2026-11-17 13:25 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d63ded7-c5a9-4bd0-9e3a-7dcb6579f900@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.