All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Niedermaier <cniedermaier@dh-electronics.com>
To: "Marek MV. Vasut" <marex@denx.de>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Cc: Shawn Guo <shawnguo@kernel.org>,
	Fabio Estevam <festevam@gmail.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	kernel <kernel@dh-electronics.com>
Subject: RE: [PATCH V4 06/15] ARM: dts: imx6q-dhcom: Add keys and leds to the PDK2 board
Date: Wed, 30 Jun 2021 12:16:27 +0000	[thread overview]
Message-ID: <9d662d2c215d460bb6dde4e7335249cb@dh-electronics.com> (raw)
In-Reply-To: <94d8297d-6453-cd46-8b89-c6b4c2528698@denx.de>

From: Marek Vasut [mailto:marex@denx.de]
Sent: Tuesday, June 29, 2021 5:10 PM
> On 6/29/21 3:56 PM, Christoph Niedermaier wrote:
> 
> [...]
> 
>> diff --git a/arch/arm/boot/dts/imx6q-dhcom-pdk2.dts b/arch/arm/boot/dts/imx6q-dhcom-pdk2.dts
>> index 6bb7129d0498..ff794a77c5db 100644
>> --- a/arch/arm/boot/dts/imx6q-dhcom-pdk2.dts
>> +++ b/arch/arm/boot/dts/imx6q-dhcom-pdk2.dts
> 
> [...]
> 
>> +     led {
>> +             compatible = "gpio-leds";
>> +             pinctrl-names = "default";
>> +             pinctrl-0 = <&pinctrl_leds_pdk2>;
>> +
>> +             /*
>> +              * Disable led-5, because GPIO E is
>> +              * already used as touch interrupt.
>> +              */
>> +             led-5 {
>> +                     color = <LED_COLOR_ID_GREEN>;
>> +                     function = LED_FUNCTION_INDICATOR;
>> +                     gpios = <&gpio4 5 GPIO_ACTIVE_HIGH>; /* GPIO E */
>> +                     default-state = "off";
>> +                     status = "disabled";
>> +             };
> 
> [...]
> 
>> diff --git a/arch/arm/boot/dts/imx6q-dhcom-som.dtsi b/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
>> index c5c060c6b9bf..68ac29d28f4f 100644
>> --- a/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
>> +++ b/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
>> @@ -9,6 +9,7 @@
>>   #include <dt-bindings/gpio/gpio.h>
>>   #include <dt-bindings/clock/imx6qdl-clock.h>
>>   #include <dt-bindings/input/input.h>
>> +#include <dt-bindings/leds/common.h>
> 
> The LEDs are optionally present on some of the carrier boards, so this
> header should be included in the carrier board .dts file I think.

Thanks, will fix this in version 5.

Regards
Christoph
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-30 12:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-29 13:55 [PATCH V4 01/15] ARM: dts: imx6q-dhcom: Add the parallel system bus Christoph Niedermaier
2021-06-29 13:55 ` [PATCH V4 02/15] ARM: dts: imx6q-dhcom: Add interrupt and compatible to the ethernet PHY Christoph Niedermaier
2021-06-29 13:56 ` [PATCH V4 03/15] ARM: dts: imx6q-dhcom: Fill GPIO line names on DHCOM SoM Christoph Niedermaier
2021-06-29 13:56 ` [PATCH V4 04/15] ARM: dts: imx6q-dhcom: Adding Wake pin to the PCIe pinctrl Christoph Niedermaier
2021-06-29 13:56 ` [PATCH V4 05/15] ARM: dts: imx6q-dhcom: Align stdout-path with other DHCOM SoMs Christoph Niedermaier
2021-06-29 13:56 ` [PATCH V4 06/15] ARM: dts: imx6q-dhcom: Add keys and leds to the PDK2 board Christoph Niedermaier
2021-06-29 15:10   ` Marek Vasut
2021-06-30 12:16     ` Christoph Niedermaier [this message]
2021-06-29 13:56 ` [PATCH V4 07/15] ARM: dts: imx6q-dhcom: Use 1G ethernet on " Christoph Niedermaier
2021-06-29 13:56 ` [PATCH V4 08/15] ARM: dts: imx6q-dhcom: Rework of the DHCOM GPIO pinctrls Christoph Niedermaier
2021-06-29 13:56 ` [PATCH V4 09/15] ARM: dts: imx6q-dhcom: Remove ddc-i2c-bus property Christoph Niedermaier
2021-06-29 13:56 ` [PATCH V4 10/15] ARM: dts: imx6q-dhcom: Set minimum memory size of all DHCOM i.MX6 variants Christoph Niedermaier
2021-06-29 13:56 ` [PATCH V4 11/15] ARM: dts: imx6q-dhcom: Rearrange of iomux Christoph Niedermaier
2021-06-29 13:56 ` [PATCH V4 12/15] ARM: dts: imx6q-dhcom: Cleanup of the devicetrees Christoph Niedermaier
2021-06-29 13:56 ` [PATCH V4 13/15] ARM: dts: imx6qdl-dhcom: Split SoC-independent parts of DHCOM SOM and PDK2 Christoph Niedermaier
2021-06-29 13:56 ` [PATCH V4 14/15] ARM: dts: imx6qdl-dhcom: Add DHCOM based PicoITX board Christoph Niedermaier
2021-06-29 13:56 ` [PATCH V4 15/15] ARM: dts: imx6qdl-dhcom: Add DHSOM based DRC02 board Christoph Niedermaier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d662d2c215d460bb6dde4e7335249cb@dh-electronics.com \
    --to=cniedermaier@dh-electronics.com \
    --cc=festevam@gmail.com \
    --cc=kernel@dh-electronics.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=marex@denx.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.