Re: [PATCH v6 04/15] drm/msm/a8xx: Export slice helper

[Akhil P Oommen <akhilpo@oss.qualcomm.com>]

On 11/6/2026 1:59 AM, Rob Clark wrote:
> Something we'll need from the gpu snapshot code.
> 
> Tested-by: Alexander Koskovich <akoskovich@pm.me> # Milos (Nothing Phone 3a)
> Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>

Reviewed-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>

-Akhil

> ---
>  drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 1 +
>  drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.h b/drivers/gpu/drm/msm/adreno/a6xx_gpu.h
> index e6ec85b20fb7..4a3898e58aee 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.h
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.h
> @@ -357,6 +357,7 @@ u64 a8xx_gmu_get_timestamp(struct msm_gpu *gpu);
>  u64 a8xx_gpu_busy(struct msm_gpu *gpu, unsigned long *out_sample_rate);
>  int a8xx_gpu_feature_probe(struct msm_gpu *gpu);
>  void a8xx_gpu_get_slice_info(struct msm_gpu *gpu);
> +u32 a8xx_get_first_slice(struct a6xx_gpu *a6xx_gpu);
>  int a8xx_hw_init(struct msm_gpu *gpu);
>  irqreturn_t a8xx_irq(struct msm_gpu *gpu);
>  void a8xx_llc_activate(struct a6xx_gpu *a6xx_gpu);
> diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c
> index be81f141300f..a29f8149493c 100644
> --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c
> @@ -130,7 +130,7 @@ void a8xx_gpu_get_slice_info(struct msm_gpu *gpu)
>  	}
>  }
>  
> -static u32 a8xx_get_first_slice(struct a6xx_gpu *a6xx_gpu)
> +u32 a8xx_get_first_slice(struct a6xx_gpu *a6xx_gpu)
>  {
>  	return ffs(a6xx_gpu->slice_mask) - 1;
>  }