From: Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>
To: Karol Wachowski <karol.wachowski@linux.intel.com>,
dri-devel@lists.freedesktop.org
Cc: oded.gabbay@gmail.com, jeff.hugo@oss.qualcomm.com,
maciej.falkowski@linux.intel.com, lizhi.hou@amd.com
Subject: Re: [PATCH] accel/ivpu: Fix swapped register names in pwr_island_drive functions
Date: Thu, 23 Apr 2026 09:55:09 +0200 [thread overview]
Message-ID: <9d9bd8af-c849-4de0-b6bf-800295a7355c@linux.intel.com> (raw)
In-Reply-To: <20260421093907.37304-1-karol.wachowski@linux.intel.com>
On 21-Apr-26 11:39 AM, Karol Wachowski wrote:
> pwr_island_drive_37xx and pwr_island_drive_40xx functions had incorrectly
> swapped registers definitions. Bug is purely cosmetic as those registers
> have exactly same offsets and layout in both 37XX and 40XX.
>
> Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
> ---
> drivers/accel/ivpu/ivpu_hw_ip.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/accel/ivpu/ivpu_hw_ip.c b/drivers/accel/ivpu/ivpu_hw_ip.c
> index 37f95a0551ed..81f0b1f8f5a6 100644
> --- a/drivers/accel/ivpu/ivpu_hw_ip.c
> +++ b/drivers/accel/ivpu/ivpu_hw_ip.c
> @@ -308,26 +308,26 @@ static void pwr_island_trickle_drive_40xx(struct ivpu_device *vdev, bool enable)
>
> static void pwr_island_drive_37xx(struct ivpu_device *vdev, bool enable)
> {
> - u32 val = REGV_RD32(VPU_40XX_HOST_SS_AON_PWR_ISLAND_EN0);
> + u32 val = REGV_RD32(VPU_37XX_HOST_SS_AON_PWR_ISLAND_EN0);
>
> if (enable)
> - val = REG_SET_FLD(VPU_40XX_HOST_SS_AON_PWR_ISLAND_EN0, CSS_CPU, val);
> + val = REG_SET_FLD(VPU_37XX_HOST_SS_AON_PWR_ISLAND_EN0, MSS_CPU, val);
> else
> - val = REG_CLR_FLD(VPU_40XX_HOST_SS_AON_PWR_ISLAND_EN0, CSS_CPU, val);
> + val = REG_CLR_FLD(VPU_37XX_HOST_SS_AON_PWR_ISLAND_EN0, MSS_CPU, val);
>
> - REGV_WR32(VPU_40XX_HOST_SS_AON_PWR_ISLAND_EN0, val);
> + REGV_WR32(VPU_37XX_HOST_SS_AON_PWR_ISLAND_EN0, val);
> }
>
> static void pwr_island_drive_40xx(struct ivpu_device *vdev, bool enable)
> {
> - u32 val = REGV_RD32(VPU_37XX_HOST_SS_AON_PWR_ISLAND_EN0);
> + u32 val = REGV_RD32(VPU_40XX_HOST_SS_AON_PWR_ISLAND_EN0);
>
> if (enable)
> - val = REG_SET_FLD(VPU_37XX_HOST_SS_AON_PWR_ISLAND_EN0, MSS_CPU, val);
> + val = REG_SET_FLD(VPU_40XX_HOST_SS_AON_PWR_ISLAND_EN0, CSS_CPU, val);
> else
> - val = REG_CLR_FLD(VPU_37XX_HOST_SS_AON_PWR_ISLAND_EN0, MSS_CPU, val);
> + val = REG_CLR_FLD(VPU_40XX_HOST_SS_AON_PWR_ISLAND_EN0, CSS_CPU, val);
>
> - REGV_WR32(VPU_37XX_HOST_SS_AON_PWR_ISLAND_EN0, val);
> + REGV_WR32(VPU_40XX_HOST_SS_AON_PWR_ISLAND_EN0, val);
> }
>
> static void pwr_island_enable(struct ivpu_device *vdev)
Reviewed-by: Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>
next prev parent reply other threads:[~2026-04-23 7:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 9:39 [PATCH] accel/ivpu: Fix swapped register names in pwr_island_drive functions Karol Wachowski
2026-04-23 7:55 ` Andrzej Kacprowski [this message]
2026-04-23 8:05 ` Karol Wachowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d9bd8af-c849-4de0-b6bf-800295a7355c@linux.intel.com \
--to=andrzej.kacprowski@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jeff.hugo@oss.qualcomm.com \
--cc=karol.wachowski@linux.intel.com \
--cc=lizhi.hou@amd.com \
--cc=maciej.falkowski@linux.intel.com \
--cc=oded.gabbay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.