Re: [PATCH 1/2] xen: introduce a cpumask with all bits set

[Juergen Gross <jgross@suse.com>]

On 14/03/2019 11:04, Andrew Cooper wrote:
> On 14/03/2019 09:59, Juergen Gross wrote:
>> There are several places in Xen allocating a cpumask on the stack and
>> setting all bits in it just to use it as an initial mask for allowing
>> all cpus.
>>
>> Save the stack space and omit the need for runtime initialization by
>> defining a globally accessible cpumask_all variable.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>, with one minor
> style suggestions which can be folded on commit.
> 
>> diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c
>> index daa5e9e5ff..a5344ed727 100644
>> --- a/xen/arch/x86/io_apic.c
>> +++ b/xen/arch/x86/io_apic.c
>> @@ -1892,8 +1891,7 @@ static void __init check_timer(void)
>>      vector = IRQ0_VECTOR;
>>      clear_irq_vector(0);
>>  
>> -    cpumask_setall(&mask_all);
>> -    if ((ret = bind_irq_vector(0, vector, &mask_all)))
>> +    if ((ret = bind_irq_vector(0, vector, &cpumask_all)))
> 
> Spaces, seeing as we're modifying the line.

You are aware this file originates from the Linux kernel?

I really don't mind either way, I just wanted to mention it...


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel