All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sadasivan Shaiju <sshaiju@mvista.com>
To: linux-rt-users@vger.kernel.org
Cc: shaiju_sada@yahoo.com
Subject: PATCH[2.6.32] softirq patch
Date: Mon, 11 Aug 2014 14:21:40 -0700	[thread overview]
Message-ID: <9dcf49abe0cd0e331df7b5faa37265ca@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 950 bytes --]

Hi ,

I  work for Montavista (Cavium Inc) as  a  Technical  Lead .  I want to
push some  of the kernel  patches to  rt community (2.6.32 kernel 2.6.33
rt patch)  , so  that  It  will  go  to  the  main line
These patches  are reviewed  and approved  by  our system Architect.  I
request  you to  include  in the main line .  These  issues  were
reported  by our customer CISCO.

Problem Description:
>From time to time, the following warning appears in the kernel logs on
x86, OCTEON Plus and Octeon II:

NOHZ: local_softirq_pending 08

Root Cause:
In run_ksoftirqd, _local_bh_enable() is used to enable bottom half.
This does not kick off softirq processing.

How Solved:
In run_ksoftirqd, _local_bh_enable() has been replaced with
local_bh_enable() to
enable softirq processing .

Here  I  am attaching  the  patch  for  the  above  bug .   If  any
questions  please  contact  me  at    sshaiju@mvista.com
(shaiju_sada@yahoo.com)

Regards,
Shaiju.

[-- Attachment #2: 5282-softirq-Call-do_softirq-from-run_ksoftirqd-when-need.patch --]
[-- Type: application/octet-stream, Size: 1103 bytes --]

From 2fa7121b912754f8149774d6a012becf542ffa18 Mon Sep 17 00:00:00 2001
From: Sadasivan Shaiju <sshaiju@mvista.com>
Date: Mon, 6 Feb 2012 18:54:53 -0800
Subject: [PATCH] softirq: Call do_softirq() from run_ksoftirqd() when needed

Source: MontaVista Software, LLC
MR: 47371
Type: Defect Fix
Disposition: Local
ChangeID: 3066b1f971e16b3fc22e6c4e4bba9c6786811acc
Description:

In run_ksoftirqd _local_bh_enable() has to be replaced with
local_bh_enable() to enable softirq processing.

The call to _local_bh_enable() was introduced in the merge of
RT patch-2.6.33-rt7.

Signed-off-by: Sadasivan Shaiju <sshaiju@mvista.com>
Signed-off-by: Dale Farnsworth <dfarnsworth@mvista.com>
---
 kernel/softirq.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/softirq.c b/kernel/softirq.c
index 67116c8..cdf52d2 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -1080,7 +1080,7 @@ sleep_more:
 
 			local_irq_disable();
 			per_cpu(softirq_running, cpu) &= ~softirq_mask;
-			_local_bh_enable();
+			local_bh_enable();
 			local_irq_enable();
 
 			cond_resched();
-- 
1.7.0.1


             reply	other threads:[~2014-08-11 21:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-11 21:21 Sadasivan Shaiju [this message]
2014-09-02 22:07 ` PATCH[2.6.32] softirq patch Thomas Gleixner
2014-09-02 22:41   ` Pavel Vasilyev
2014-09-02 23:00     ` Sadasivan Shaiju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9dcf49abe0cd0e331df7b5faa37265ca@mail.gmail.com \
    --to=sshaiju@mvista.com \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=shaiju_sada@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.