Re: [PATCH] erofs-utils: build: link tools with liberofs dependencies

[Gao Xiang <hsiangkao@linux.alibaba.com>]

On 2026/6/7 19:29, zhaoyifan (H) wrote:
> 
> On 2026/6/3 22:36, Gao Xiang wrote:

...

>>> +])
>> Although I admit that I'm not super happy with this approach, but it
>> seems that we have to do like this.
>>
>> My only question here is that why  ${libxxhash_LIBS},  ${libxml2_LIBS}
>> and ${libnl3_LIBS} cannot be appended directly to LIBEROFS_LIBS as
>> others.
> 
> As these flags were conditionally appended to liberofs_la_LDFLAGS in the original lib/Makefile.am code path.

Can we append them into LIBEROFS_LIBS directly?

Thanks,
Gao Xiang

> 
> 
> Thanks,
> 
> Yifan
> 
>> But I think it's fine to guard `-lpthread` with enable_multithreading
>> tho.
>>
>> Thanks,
>> Gao Xiang
>>