From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DDFA7EB64DD for ; Mon, 7 Aug 2023 09:03:52 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.577874.904960 (Exim 4.92) (envelope-from ) id 1qSw9R-00012J-3y; Mon, 07 Aug 2023 09:03:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577874.904960; Mon, 07 Aug 2023 09:03:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSw9R-00012C-1Q; Mon, 07 Aug 2023 09:03:45 +0000 Received: by outflank-mailman (input) for mailman id 577874; Mon, 07 Aug 2023 09:03:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSw9Q-0000UO-5x for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 09:03:44 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4f3b9ee5-3501-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 11:03:43 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 7250D4EE0737; Mon, 7 Aug 2023 11:03:43 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f3b9ee5-3501-11ee-b27d-6b7b168915f2 MIME-Version: 1.0 Date: Mon, 07 Aug 2023 11:03:43 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 2/6] libelf: address MISRA C:2012 Rule 5.3 In-Reply-To: References: <55624244c42297da7da954009ba0559c47fc245e.1691162261.git.nicola.vetrini@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <9deeb76dcce04de11d8085f5835bad7b@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 07/08/2023 10:11, Jan Beulich wrote: > On 04.08.2023 17:27, Nicola Vetrini wrote: >> The types u{8,16,32,64} defined in 'xen/arch/x86/include/asm/types.h' >> shadow the variables in the modified function, hence violating Rule >> 5.3. >> Therefore, the rename takes care of the shadowing. >> >> No functional changes. >> >> Signed-off-by: Nicola Vetrini >> --- >> xen/common/libelf/libelf-tools.c | 24 ++++++++++++------------ >> 1 file changed, 12 insertions(+), 12 deletions(-) >> >> diff --git a/xen/common/libelf/libelf-tools.c >> b/xen/common/libelf/libelf-tools.c >> index a9edb6a8dc..f0d5da1abf 100644 >> --- a/xen/common/libelf/libelf-tools.c >> +++ b/xen/common/libelf/libelf-tools.c >> @@ -91,10 +91,10 @@ uint64_t elf_access_unsigned(struct elf_binary * >> elf, elf_ptrval base, >> { >> elf_ptrval ptrval = base + moreoffset; >> bool need_swap = elf_swap(elf); >> - const uint8_t *u8; >> - const uint16_t *u16; >> - const uint32_t *u32; >> - const uint64_t *u64; >> + const uint8_t *uint8; >> + const uint16_t *uint16; >> + const uint32_t *uint32; >> + const uint64_t *uint64; > > While the chosen names won't collide with stdint.h's, I still consider > them odd. These all being pointers, why not simply pu as names? > > Jan lgtm. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)