Re: [PATCH] nvmet: return 'namespace not ready' for disabled namespaces

[Hannes Reinecke <hare@suse.de>]

On 8/19/24 15:17, Sagi Grimberg wrote:
> 
> 
> 
> On 19/08/2024 15:29, Hannes Reinecke wrote:
>> When a namespace is disabled from configfs returning 'path error'
>> is quite an odd choice; the actual description for that error is:
>> 'The command was not completed as a result of a controller internal
>> error that is specific to the controller processing the command.'
>> Which is not the case here; once disabled the namespace is disabled
>> for the entire subsystem, not just the controller.
>> So return 'namespace not ready' here to clarify the problem.
> 
> Hannes, can you explain what this patch is solving?
> 
> The reason why this error was selected is because this is a path
> error, which will trigger a host IO failover.

???

This is not a path error.

# echo 0 > 
/sys/kernel/config/nvmet/subsystems/<NQN>/namespaces/<NSID>/enable

will disable the namespace for all controllers. Not just the individual
path (as there is not individual path). Failover won't change anything.

Hence this change.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich