From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH] drm/bridge: analogix_dp: set the DPCD600 during disabling the psr Date: Thu, 15 Dec 2016 15:07:59 +0530 Message-ID: <9e2507fd-e5bb-40ce-a9a6-e4b978cd6d9a@codeaurora.org> References: <1481338159-7189-1-git-send-email-wxt@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul Cc: Tomeu Vizoso , Daniel Vetter , Brian Norris , Linux Kernel Mailing List , dri-devel , linux-rockchip@lists.infradead.org, Gustavo Padovan , Caesar Wang List-Id: linux-rockchip.vger.kernel.org CgpPbiAxMi8xNC8yMDE2IDAzOjMwIFBNLCBTZWFuIFBhdWwgd3JvdGU6Cj4gT24gV2VkLCBEZWMg MTQsIDIwMTYgYXQgMTI6MDMgQU0sIEFyY2hpdCBUYW5lamEgPGFyY2hpdHRAY29kZWF1cm9yYS5v cmc+IHdyb3RlOgo+PiBIaSwKPj4KPj4gT24gMTIvMTIvMjAxNiAwODoyOCBQTSwgU2VhbiBQYXVs IHdyb3RlOgo+Pj4KPj4+IE9uIEZyaSwgRGVjIDksIDIwMTYgYXQgOTo0OSBQTSwgQ2Flc2FyIFdh bmcgPHd4dEByb2NrLWNoaXBzLmNvbT4gd3JvdGU6Cj4+Pj4KPj4+PiBMb29rIGxpa2VzLCB0aGUg Qk9FIHBhbmVsIEZXIGRpZG4ndCBhY2sgdGhlIERQQ0Q2MDAgc2lnbmFsIGZyb20gdGhlIGhvc3QK Pj4+PiBkZXZpY2UsIHRoYXQgd2lsbCBjYXVzZSB0aGUgcGFuZWwgaGFuZyBvbiB0aGUgc3RhcnR1 cCBkaXNwbGF5Lgo+Pj4+IFRoZSByb290IGNhdXNlIHdlIHVzZSB0aGUgZmFzdCBsaW5rIG1vZGUg ZHVyaW5nIGVudGVyIGFuZCBleGl0IHRoZSBwc3IsCj4+Pj4gdGhpcyBpc3N1ZSBpcyBnb25lIGlm IHN3aXRjaGluZyB0aGUgZmFzdCBsaW5rIHRvIG1haW4gbGluayBtb2RlLgo+Pj4+Cj4+Pgo+Pj4g Q2M6IEFyY2hpdCBUYW5lamEgPGFyY2hpdHRAY29kZWF1cm9yYS5vcmc+Cj4+Cj4+Cj4+IERvIHdl IHdhbnQgdGhpcyBhcyBhIGZpeCBpbiA0LjEwPyBPciBpcyBpdCBva2F5IHRvIGdldCBpdCBpbiA0 LjExPwo+PiBJbiBvdGhlciB3b3Jkcywgc2hvdWxkIHRoaXMgZ28gdG8gZHJtLW1pc2MtbmV4dCBv ciBkcm0tbWlzYy1maXhlcz8KPj4KPgo+IEhpIEFyY2hpdCwKPiA0LjExIGlzIHRvdGFsbHkgZmlu ZS4KClRoYW5rcy4gUXVldWVkIGFmdGVyIHNvbWUgY29tbWl0IG1lc3NhZ2UgY2xlYW51cC4KCkFy Y2hpdAoKPgo+IFNlYW4KPgo+Cj4+IFRoYW5rcywKPj4gQXJjaGl0Cj4+Cj4+Cj4+Pgo+Pj4+IFNp Z25lZC1vZmYtYnk6IENhZXNhciBXYW5nIDx3eHRAcm9jay1jaGlwcy5jb20+Cj4+Pj4gLS0tCj4+ Pj4KPj4+PiAgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9hbmFsb2dpeF9kcF9jb3Jl LmMgfCA1ICsrKysrCj4+Pj4gIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKykKPj4+Pgo+ Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2FuYWxvZ2l4L2FuYWxvZ2l4 X2RwX2NvcmUuYwo+Pj4+IGIvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9hbmFsb2dp eF9kcF9jb3JlLmMKPj4+PiBpbmRleCA2ZTA0NDdmLi42YTUzNDdiIDEwMDY0NAo+Pj4+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXgvYW5hbG9naXhfZHBfY29yZS5jCj4+Pj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9hbmFsb2dpeF9kcF9jb3JlLmMK Pj4+PiBAQCAtMTMzLDYgKzEzMyw3IEBAIGludCBhbmFsb2dpeF9kcF9kaXNhYmxlX3BzcihzdHJ1 Y3QgZGV2aWNlICpkZXYpCj4+Pj4gIHsKPj4+PiAgICAgICAgIHN0cnVjdCBhbmFsb2dpeF9kcF9k ZXZpY2UgKmRwID0gZGV2X2dldF9kcnZkYXRhKGRldik7Cj4+Pj4gICAgICAgICBzdHJ1Y3QgZWRw X3ZzY19wc3IgcHNyX3ZzYzsKPj4+PiArICAgICAgIGludCByZXQ7Cj4+Pj4KPj4+PiAgICAgICAg IGlmICghZHAtPnBzcl9zdXBwb3J0KQo+Pj4+ICAgICAgICAgICAgICAgICByZXR1cm4gLUVJTlZB TDsKPj4+PiBAQCAtMTQ3LDYgKzE0OCwxMCBAQCBpbnQgYW5hbG9naXhfZHBfZGlzYWJsZV9wc3Io c3RydWN0IGRldmljZSAqZGV2KQo+Pj4+ICAgICAgICAgcHNyX3ZzYy5EQjAgPSAwOwo+Pj4+ICAg ICAgICAgcHNyX3ZzYy5EQjEgPSAwOwo+Pj4+Cj4+Pj4gKyAgICAgICByZXQgPSBkcm1fZHBfZHBj ZF93cml0ZWIoJmRwLT5hdXgsIERQX1NFVF9QT1dFUiwKPj4+PiBEUF9TRVRfUE9XRVJfRDApOwo+ Pj4+ICsgICAgICAgaWYgKHJldCAhPSAxKQo+Pj4+ICsgICAgICAgICAgICAgICBkZXZfZXJyKGRw LT5kZXYsICJGYWlsZWQgdG8gc2V0IERQIFBvd2VyMCAlZFxuIiwgcmV0KTsKPj4+PiArCj4+Pj4g ICAgICAgICBhbmFsb2dpeF9kcF9zZW5kX3Bzcl9zcGQoZHAsICZwc3JfdnNjKTsKPj4+PiAgICAg ICAgIHJldHVybiAwOwo+Pj4+ICB9Cj4+Pj4gLS0KPj4+PiAyLjcuNAo+Pj4+Cj4+Cj4+IC0tCj4+ IFF1YWxjb21tIElubm92YXRpb24gQ2VudGVyLCBJbmMuIGlzIGEgbWVtYmVyIG9mIENvZGUgQXVy b3JhIEZvcnVtLAo+PiBhIExpbnV4IEZvdW5kYXRpb24gQ29sbGFib3JhdGl2ZSBQcm9qZWN0Cgot LSAKUXVhbGNvbW0gSW5ub3ZhdGlvbiBDZW50ZXIsIEluYy4gaXMgYSBtZW1iZXIgb2YgQ29kZSBB dXJvcmEgRm9ydW0sCmEgTGludXggRm91bmRhdGlvbiBDb2xsYWJvcmF0aXZlIFByb2plY3QKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757483AbcLOJjI (ORCPT ); Thu, 15 Dec 2016 04:39:08 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:55254 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751701AbcLOJjD (ORCPT ); Thu, 15 Dec 2016 04:39:03 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org AF9F96134E Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=architt@codeaurora.org Subject: Re: [PATCH] drm/bridge: analogix_dp: set the DPCD600 during disabling the psr To: Sean Paul References: <1481338159-7189-1-git-send-email-wxt@rock-chips.com> Cc: Caesar Wang , Dave Airlie , Tomeu Vizoso , Gustavo Padovan , Daniel Vetter , dri-devel , Linux Kernel Mailing List , linux-rockchip@lists.infradead.org, Brian Norris , Heiko Stuebner From: Archit Taneja Message-ID: <9e2507fd-e5bb-40ce-a9a6-e4b978cd6d9a@codeaurora.org> Date: Thu, 15 Dec 2016 15:07:59 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/14/2016 03:30 PM, Sean Paul wrote: > On Wed, Dec 14, 2016 at 12:03 AM, Archit Taneja wrote: >> Hi, >> >> On 12/12/2016 08:28 PM, Sean Paul wrote: >>> >>> On Fri, Dec 9, 2016 at 9:49 PM, Caesar Wang wrote: >>>> >>>> Look likes, the BOE panel FW didn't ack the DPCD600 signal from the host >>>> device, that will cause the panel hang on the startup display. >>>> The root cause we use the fast link mode during enter and exit the psr, >>>> this issue is gone if switching the fast link to main link mode. >>>> >>> >>> Cc: Archit Taneja >> >> >> Do we want this as a fix in 4.10? Or is it okay to get it in 4.11? >> In other words, should this go to drm-misc-next or drm-misc-fixes? >> > > Hi Archit, > 4.11 is totally fine. Thanks. Queued after some commit message cleanup. Archit > > Sean > > >> Thanks, >> Archit >> >> >>> >>>> Signed-off-by: Caesar Wang >>>> --- >>>> >>>> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c >>>> b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c >>>> index 6e0447f..6a5347b 100644 >>>> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c >>>> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c >>>> @@ -133,6 +133,7 @@ int analogix_dp_disable_psr(struct device *dev) >>>> { >>>> struct analogix_dp_device *dp = dev_get_drvdata(dev); >>>> struct edp_vsc_psr psr_vsc; >>>> + int ret; >>>> >>>> if (!dp->psr_support) >>>> return -EINVAL; >>>> @@ -147,6 +148,10 @@ int analogix_dp_disable_psr(struct device *dev) >>>> psr_vsc.DB0 = 0; >>>> psr_vsc.DB1 = 0; >>>> >>>> + ret = drm_dp_dpcd_writeb(&dp->aux, DP_SET_POWER, >>>> DP_SET_POWER_D0); >>>> + if (ret != 1) >>>> + dev_err(dp->dev, "Failed to set DP Power0 %d\n", ret); >>>> + >>>> analogix_dp_send_psr_spd(dp, &psr_vsc); >>>> return 0; >>>> } >>>> -- >>>> 2.7.4 >>>> >> >> -- >> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, >> a Linux Foundation Collaborative Project -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project