Re: [PATCH v1 2/5] drm/xe/pf: Change provisioning mode under mutex

["Bernatowicz, Marcin" <marcin.bernatowicz@linux.intel.com>]

LGTM,

Reviewed-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>

On 10/27/2026 11:30 AM, Piórkowski, Piotr wrote:
> From: Michal Wajdeczko <michal.wajdeczko@intel.com>
>
> The provisioning mode is changed from the debugfs handlers, but it is
> also checked when VFs are disabled, without any locking. Since we now
> have xe_gt_sriov_pf_config_release_locked(), we can release the VFs
> configuration while holding the master mutex, and do a proper locking
> while changing the provisioning mode and while unprovisioning the VFs.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Signed-off-by: Piotr Piórkowski <piotr.piorkowski@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_sriov_pf_provision.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_sriov_pf_provision.c b/drivers/gpu/drm/xe/xe_sriov_pf_provision.c
> index 91670063f706..e713a24b8864 100644
> --- a/drivers/gpu/drm/xe/xe_sriov_pf_provision.c
> +++ b/drivers/gpu/drm/xe/xe_sriov_pf_provision.c
> @@ -56,9 +56,11 @@ static void pf_unprovision_vfs(struct xe_device *xe, unsigned int num_vfs)
>   	unsigned int id;
>   	unsigned int n;
>   
> +	lockdep_assert_held(xe_sriov_pf_master_mutex(xe));
> +
>   	for_each_gt(gt, xe, id)
>   		for (n = 1; n <= num_vfs; n++)
> -			xe_gt_sriov_pf_config_release(gt, n, true);
> +			xe_gt_sriov_pf_config_release_locked(gt, n, true);
>   }
>   
>   static void pf_unprovision_all_vfs(struct xe_device *xe)
> @@ -98,6 +100,8 @@ int xe_sriov_pf_unprovision_vfs(struct xe_device *xe, unsigned int num_vfs)
>   {
>   	xe_assert(xe, IS_SRIOV_PF(xe));
>   
> +	guard(mutex)(xe_sriov_pf_master_mutex(xe));
> +
>   	if (!pf_auto_provisioning_mode(xe))
>   		return 0;
>   
> @@ -166,6 +170,8 @@ int xe_sriov_pf_provision_set_mode(struct xe_device *xe, enum xe_sriov_provision
>   {
>   	xe_assert(xe, IS_SRIOV_PF(xe));
>   
> +	guard(mutex)(xe_sriov_pf_master_mutex(xe));
> +
>   	if (mode == xe->sriov.pf.provision.mode)
>   		return 0;
>