All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [PULL] u-boot-usb/next
Date: Thu, 1 Oct 2020 19:42:51 +0200	[thread overview]
Message-ID: <9e3a71ce-ce62-1eae-c504-ec2a6e14ae96@denx.de> (raw)
In-Reply-To: <20201001170911.GS14816@bill-the-cat>

On 10/1/20 7:09 PM, Tom Rini wrote:
> On Thu, Oct 01, 2020 at 10:29:11AM +0200, Marek Vasut wrote:
> 
>> The following changes since commit ae52e75d23ce11f36b3eae758045da95a871f263:
>>
>>   Merge tag 'for-v2021.01-next' of
>> https://gitlab.denx.de/u-boot/custodians/u-boot-i2c into next
>> (2020-09-17 09:55:01 -0400)
>>
>> are available in the Git repository at:
>>
>>   git://git.denx.de/u-boot-usb.git next
>>
>> for you to fetch changes up to 4fb50766433626f4d57e7491e638bc55d80badef:
>>
>>   usb: xhci-rcar: Add support for R8A774A1 SoC (2020-09-22 13:40:27 +0200)
>>
> 
> NAK.  Introduces a failure to build on:

Interesting, this must be new.

> rpi_4 poplar odroid-c4 odroid-n2 khadas-vim libretech-ac libretech-cc
> khadas-vim2 libretech-s905d-pc libretech-s912-pc sei510 sei610 u200
> khadas-vim3 khadas-vim3l odroid-go2 evb-px30 firefly-px30 roc-cc-rk3308
> evb-rk3308 evb-rk3328 roc-cc-rk3328 rock-pi-e-rk3328 rock64-rk3328
> such as:
> +(rpi_4) drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c: In function 'process_ep_out_intr':
> +(rpi_4) drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c:425:18: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
> +(rpi_4)   425 |  u32 epsiz_reg = (u32)&reg->out_endp[ep_num].doeptsiz;
> +(rpi_4)       |                  ^
> +(rpi_4) In file included from drivers/usb/gadget/dwc2_udc_otg.c:42:
> +(rpi_4) arch/arm/include/asm/io.h:45:28: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
> +(rpi_4)    45 | #define __arch_getl(a)   (*(volatile unsigned int *)(a))
> +(rpi_4)       |                            ^
> +(rpi_4) arch/arm/include/asm/io.h:127:31: note: in expansion of macro '__arch_getl'
> +(rpi_4)   127 | #define readl(c) ({ u32 __v = __arch_getl(c); __iormb(); __v; })
> +(rpi_4)       |                               ^~~~~~~~~~~
> +(rpi_4) drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c:447:15: note: in expansion of macro 'readl'
> +(rpi_4)   447 |      ep_tsr = readl(epsiz_reg);
> +(rpi_4)       |               ^~~~~
> +(rpi_4) cc1: all warnings being treated as errors
> +(rpi_4) make[2]: *** [drivers/usb/gadget/dwc2_udc_otg.o] Error 1
> +(rpi_4) make[1]: *** [drivers/usb/gadget] Error 2
> +(rpi_4) make: *** [sub-make] Error 2
> 
> Since you'll have to dig in here anyhow, there's also a typo in the
> commit message of:
> commit d033774655ee4dd7b3fc45bc5273b8c7a892a5b2
> Author: Chance.Yang <chance.yang@vatics.com>
> Date:   Tue Sep 22 16:48:42 2020 +0800
> 
>     usb: dwc2: Fix contorl OUT transfer issue

It would be useful to CC the author of that patch.
I will drop the patch for now and wait for a fixed one.

  reply	other threads:[~2020-10-01 17:42 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-01  8:29 [PULL] u-boot-usb/next Marek Vasut
2020-10-01 17:09 ` Tom Rini
2020-10-01 17:42   ` Marek Vasut [this message]
2020-10-01 18:09     ` Tom Rini
2020-10-01 18:38       ` Marek Vasut
  -- strict thread matches above, loose matches on Subject: below --
2026-06-03  0:40 Marek Vasut
2026-06-03 18:21 ` Tom Rini
2025-10-05 12:59 Marek Vasut
2025-10-05 17:48 ` Tom Rini
2025-09-25 23:08 Marek Vasut
2025-09-26 15:56 ` Tom Rini
2025-03-17  3:15 Marek Vasut
2025-03-18  1:14 ` Tom Rini
2024-09-09 20:20 Marek Vasut
2024-09-10  4:08 ` Tom Rini
2023-09-16 10:16 Marek Vasut
2023-09-16 22:38 ` Tom Rini
2023-09-05 13:50 Marek Vasut
2023-09-06 17:50 ` Tom Rini
2023-05-18 15:01 Marek Vasut
2023-05-18 20:09 ` Tom Rini
2023-03-03  0:05 Marek Vasut
2023-03-03 23:40 ` Tom Rini
2023-02-22 15:36 Marek Vasut
2023-02-22 18:37 ` Tom Rini
2023-02-22 22:09   ` Marek Vasut
2023-02-23  1:50     ` Tom Rini
2023-02-23  4:45       ` Marek Vasut
2023-02-23 16:36     ` Tom Rini
2020-03-30  9:32 Marek Vasut
2020-04-01 13:43 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e3a71ce-ce62-1eae-c504-ec2a6e14ae96@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.