From: Jon Smirl <jonsmirl@gmail.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [RFC: 2.6 patch] drivers/pci/: possible cleanups
Date: Fri, 18 Feb 2005 19:24:33 -0500 [thread overview]
Message-ID: <9e473391050218162438cae108@mail.gmail.com> (raw)
In-Reply-To: <20050218235419.GE4337@stusta.de>
On Sat, 19 Feb 2005 00:54:19 +0100, Adrian Bunk <bunk@stusta.de> wrote:
> This patch contains the following possible cleanups:
> - pci-acpi.c: make OSC_UUID static
> - remove the following unused functions:
> - pci-acpi.c: acpi_query_osc
> - pci-acpi.c: pci_osc_support_set
> - pci.c: pci_find_ext_capability
> - rom.c: pci_map_rom_copy
> - rom.c: pci_remove_rom
> - remove the following unneeded EXPORT_SYMBOL's:
> - pci-acpi.c: pci_osc_support_set
> - rom.c: pci_map_rom_copy
> - rom.c: pci_remove_rom
pci_map_rom_copy and pci_remove_rom are there to support boards that
can't access their hardware and their ROM at the same time. These
boards are known to exist but nobody has updated a driver yet to use
the new routines. These should be left in place as the PCI spec
explicitly allows the non-simultaneous access case.
pci_remove_rom should probably be renamed to pci_remove_rom_copy.
--
Jon Smirl
jonsmirl@gmail.com
next prev parent reply other threads:[~2005-02-19 0:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-18 23:54 [RFC: 2.6 patch] drivers/pci/: possible cleanups Adrian Bunk
2005-02-19 0:24 ` Jon Smirl [this message]
2005-02-19 14:50 ` Matthew Wilcox
2005-12-16 22:42 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e473391050218162438cae108@mail.gmail.com \
--to=jonsmirl@gmail.com \
--cc=bunk@stusta.de \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.