Re: [PATCH 1/10] fbdev: Add mode changing via sysfs

[Jon Smirl <jonsmirl@gmail.com>]

On Mon, 7 Mar 2005 18:10:44 +0000 (GMT), James Simmons
<jsimmons@www.infradead.org> wrote:
> 
> > diff -Nru a/include/linux/fb.h b/include/linux/fb.h
> > --- a/include/linux/fb.h      2005-03-05 00:18:26 +08:00
> > +++ b/include/linux/fb.h      2005-02-18 15:17:45 +08:00
> > @@ -715,8 +715,10 @@
> >       struct fb_pixmap sprite;        /* Cursor hardware mapper */
> >       struct fb_cmap cmap;            /* Current cmap */
> >       struct list_head modelist;      /* mode list */
> > +     struct fb_videomode *mode;      /* current mode */
> >       struct fb_ops *fbops;
> >       struct device *device;
> > +     struct class_device *class_device; /* sysfs per device attrs */
> >  #ifdef CONFIG_FB_TILEBLITTING
> 
> Why do we need a mode pointer when we have a function that translates the
> mode to a var?
> 

So that the sysfs attribute can display the name of the current mode. 


-- 
Jon Smirl
jonsmirl@gmail.com


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click