From: Jon Smirl <jonsmirl@gmail.com>
To: Andrew Morton <akpm@osdl.org>
Cc: adaplas@pol.net, adaplas@hotpop.com,
linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH 8/10] fbdev: Allow core fb to be built as a module
Date: Mon, 7 Mar 2005 23:50:11 -0500 [thread overview]
Message-ID: <9e47339105030720507cc34a68@mail.gmail.com> (raw)
In-Reply-To: <20050307174736.6a363b39.akpm@osdl.org>
On Mon, 7 Mar 2005 17:47:36 -0800, Andrew Morton <akpm@osdl.org> wrote:
> Jon Smirl <jonsmirl@gmail.com> wrote:
> >
> > Not sure if ppc will build since I don't have a machine to check it on.
>
> ppc seems OK.
>
> Now x86 `allmodconfig' is unhappy.
>
> *** Warning: "fb_find_logo" [drivers/video/fb.ko] undefined!
>
> diff -puN drivers/video/logo/logo.c~fbdev-allow-core-fb-to-be-built-as-a-module-fix-fix drivers/video/logo/logo.c
> --- 25/drivers/video/logo/logo.c~fbdev-allow-core-fb-to-be-built-as-a-module-fix-fix 2005-03-07 17:42:38.000000000 -0800
> +++ 25-akpm/drivers/video/logo/logo.c 2005-03-07 17:42:38.000000000 -0800
> @@ -12,6 +12,7 @@
> #include <linux/config.h>
> #include <linux/linux_logo.h>
> #include <linux/stddef.h>
> +#include <linux/module.h>
>
> #ifdef CONFIG_M68K
> #include <asm/setup.h>
> @@ -99,4 +100,4 @@ const struct linux_logo *fb_find_logo(in
> }
> return logo;
> }
> -
> +EXPORT_SYMBOL_GPL(fb_find_logo);
> _
>
>
Did you fix this or do I need to send another patch?
I didn't know about allmodconfig so I'll be sure and run it. It's
about time fb became a module, it's been built in for about ten years.
--
Jon Smirl
jonsmirl@gmail.com
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
next prev parent reply other threads:[~2005-03-08 4:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-06 0:16 [PATCH 8/10] fbdev: Allow core fb to be built as a module Antonino A. Daplas
2005-03-07 8:36 ` Andrew Morton
2005-03-07 9:39 ` Geert Uytterhoeven
2005-03-07 10:28 ` Andrew Morton
2005-03-07 18:20 ` Jon Smirl
2005-03-07 19:11 ` Jon Smirl
2005-03-07 23:43 ` Andrew Morton
2005-03-08 0:05 ` Jon Smirl
2005-03-08 0:39 ` Andrew Morton
2005-03-08 0:35 ` Jon Smirl
2005-03-08 0:48 ` Andrew Morton
2005-03-08 1:18 ` Randy.Dunlap
2005-03-08 1:47 ` Andrew Morton
2005-03-08 4:50 ` Jon Smirl [this message]
2005-03-08 4:58 ` Andrew Morton
2005-03-09 5:48 ` Antonino A. Daplas
2005-03-09 6:50 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e47339105030720507cc34a68@mail.gmail.com \
--to=jonsmirl@gmail.com \
--cc=adaplas@hotpop.com \
--cc=adaplas@pol.net \
--cc=akpm@osdl.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.