From: Jon Smirl <jonsmirl@gmail.com>
To: fbdev <linux-fbdev-devel@lists.sourceforge.net>,
"Antonino A. Daplas" <adaplas@hotpop.com>
Subject: Three fbdev bug fixes
Date: Thu, 28 Apr 2005 13:02:55 -0400 [thread overview]
Message-ID: <9e47339105042810025d35a2ad@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 432 bytes --]
#1) fbdev is missing unregister_chrdev(FB_MAJOR, "fb");
#2) rounding issues can make an acceptable mode fail
added hfreq = (hfreq + 500) / 1000 * 1000;
#3) Benh has picked this up. radeonfb is not deleting it's sysfs attributes
sysfs_remove_bin_file(&rinfo->pdev->dev.kobj, &edid1_attr);
sysfs_remove_bin_file(&rinfo->pdev->dev.kobj, &edid2_attr);
All three are in the attachment
--
Jon Smirl
jonsmirl@gmail.com
[-- Attachment #2: patch --]
[-- Type: application/octet-stream, Size: 1130 bytes --]
===== drivers/video/fbmem.c 1.160 vs edited =====
--- 1.160/drivers/video/fbmem.c 2005-03-31 06:06:52 -05:00
+++ edited/drivers/video/fbmem.c 2005-04-25 01:33:57 -04:00
@@ -1211,6 +1211,7 @@
fbmem_exit(void)
{
class_simple_destroy(fb_class);
+ unregister_chrdev(FB_MAJOR, "fb");
}
module_exit(fbmem_exit);
===== drivers/video/fbmon.c 1.22 vs edited =====
--- 1.22/drivers/video/fbmon.c 2005-03-31 06:06:52 -05:00
+++ edited/drivers/video/fbmon.c 2005-04-25 13:58:13 -04:00
@@ -1242,6 +1242,8 @@
vtotal *= 2;
hfreq = pixclock/htotal;
+ hfreq = (hfreq + 500) / 1000 * 1000;
+
vfreq = hfreq/vtotal;
return (vfreq < vfmin || vfreq > vfmax ||
===== drivers/video/aty/radeon_base.c 1.48 vs edited =====
--- 1.48/drivers/video/aty/radeon_base.c 2005-03-31 06:06:52 -05:00
+++ edited/drivers/video/aty/radeon_base.c 2005-04-28 12:56:55 -04:00
@@ -2452,6 +2452,11 @@
radeonfb_pm_exit(rinfo);
+ if (rinfo->mon1_EDID)
+ sysfs_remove_bin_file(&rinfo->pdev->dev.kobj, &edid1_attr);
+ if (rinfo->mon2_EDID)
+ sysfs_remove_bin_file(&rinfo->pdev->dev.kobj, &edid2_attr);
+
#if 0
/* restore original state
*
next reply other threads:[~2005-04-28 17:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-28 17:02 Jon Smirl [this message]
2005-04-29 1:57 ` Three fbdev bug fixes Antonino A. Daplas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e47339105042810025d35a2ad@mail.gmail.com \
--to=jonsmirl@gmail.com \
--cc=adaplas@hotpop.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.