From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Smirl Subject: Re: [PATCH] add NULL short circuit to fb_dealloc_cmap() Date: Sun, 17 Jul 2005 18:32:07 -0400 Message-ID: <9e47339105071715322c558403@mail.gmail.com> References: <200507172043.41473.jesper.juhl@gmail.com> <9e473391050717132233347d25@mail.gmail.com> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=sc8-sf-mx2.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1DuHgG-0005PC-2H for linux-fbdev-devel@lists.sourceforge.net; Sun, 17 Jul 2005 15:32:16 -0700 Received: from wproxy.gmail.com ([64.233.184.200]) by sc8-sf-mx2.sourceforge.net with esmtp (Exim 4.44) id 1DuHgE-0003OD-Sv for linux-fbdev-devel@lists.sourceforge.net; Sun, 17 Jul 2005 15:32:16 -0700 Received: by wproxy.gmail.com with SMTP id 37so915292wra for ; Sun, 17 Jul 2005 15:32:08 -0700 (PDT) In-Reply-To: Content-Disposition: inline Sender: linux-fbdev-devel-admin@lists.sourceforge.net Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: List-Post: List-Help: List-Subscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii" To: Geert Uytterhoeven Cc: Jesper Juhl , Linux Kernel Development , Linux Frame Buffer Device Development On 7/17/05, Geert Uytterhoeven wrote: > > > > struct fb_super_cmap { > > struct fb_cmap cmap; > > __u16 red[255]; > > __u16 blue[255]; > > __u16 green[255]; > > __u16 transp[255]; > ^^^ > I assume you meant 256? >=20 > > } > > > > Then adjust the code as need. Have the embedded cmap struct point to > > the fields in the super_cmap and the drivers don't have to be changed. >=20 > What if your colormap has more than 256 entries? I meant 256. Does any hardware exist that takes more that 256 entries?=20 They are __u16 values but I have never seen hardware that take more that __u8 either. --=20 Jon Smirl jonsmirl@gmail.com ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261436AbVGQWcN (ORCPT ); Sun, 17 Jul 2005 18:32:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261438AbVGQWcN (ORCPT ); Sun, 17 Jul 2005 18:32:13 -0400 Received: from wproxy.gmail.com ([64.233.184.196]:59046 "EHLO wproxy.gmail.com") by vger.kernel.org with ESMTP id S261436AbVGQWcL convert rfc822-to-8bit (ORCPT ); Sun, 17 Jul 2005 18:32:11 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=YDtoo09nggK5tO4fTz99MDvqnnTBGtwTqrAhUSrtVpmIb62nKe5R4vAvdEI30Tmh19IXJk8YgBRL9P6/uTjuoPcB59fo8TyspoL9O8DzoOzAjbON2SmiCJRf+nz8iVUcCZ1wiVpEG/n8sb5YkaDbdhJ7kqy/bQRH9tnTRo9xiI8= Message-ID: <9e47339105071715322c558403@mail.gmail.com> Date: Sun, 17 Jul 2005 18:32:07 -0400 From: Jon Smirl Reply-To: Jon Smirl To: Geert Uytterhoeven Subject: Re: [PATCH] add NULL short circuit to fb_dealloc_cmap() Cc: Jesper Juhl , Linux Kernel Development , Linux Frame Buffer Device Development In-Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Content-Disposition: inline References: <200507172043.41473.jesper.juhl@gmail.com> <9e473391050717132233347d25@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On 7/17/05, Geert Uytterhoeven wrote: > > > > struct fb_super_cmap { > > struct fb_cmap cmap; > > __u16 red[255]; > > __u16 blue[255]; > > __u16 green[255]; > > __u16 transp[255]; > ^^^ > I assume you meant 256? > > > } > > > > Then adjust the code as need. Have the embedded cmap struct point to > > the fields in the super_cmap and the drivers don't have to be changed. > > What if your colormap has more than 256 entries? I meant 256. Does any hardware exist that takes more that 256 entries? They are __u16 values but I have never seen hardware that take more that __u8 either. -- Jon Smirl jonsmirl@gmail.com