Re: PATCH: move soft_cursor into fbconsole

[Jon Smirl <jonsmirl@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2045 bytes --]

This not currently resolved.

From user space we can have two interfaces
1) the current ioctl one
2) the new stuff in sysfs. If the hardware cursor is there you get a sysfs 
attribute named cursor. write x,y to it to move the cursor around. I'll add 
the sysfs support as soon as we decide on the interface.

I'm still at OLS. Missed seeing both of you at KS. fbdev was discussed and 
Linus went with Benh's proposal to move the modesetting API to user space. 
Obviously this will have a lot of impact on fbdev.


On 7/23/05, Antonino A. Daplas <adaplas@gmail.com> wrote:
> 
> On Saturday 02 July 2005 08:56, Jon Smirl wrote:
> > Another way to think of this, let's make another member variable
> > .fb_hwcursor. When the driver has a hardware cusor is sets
> > .fb_hwcursor. If you want to use the software cursor use the exisiting
> > .fb_cursor.
> >
> > If you think about it every driver is going to have the exact same
> > assignment .fb_cursor = soft_cursor. If every driver is going to have
> > exactly the same assignment, why do we need the variable?
> >
> > It's the existence of the hardware cursor that varies from driver to
> > driver, that's the one we need the variable for.
> 
> Is this resolved? I tend to agree with Jon. Let's just remove all
> references to soft_cursor from all drivers, and let fbcon_cursor() fall 
> back
> to soft_cursor when xxxfb_cursor() is absent. It is a lot cleaner and 
> saner
> this way, and although it touches all drivers, it is a singe logical 
> change,
> so it's acceptable.
> 
> Also, I think it might be preferable to have 2 cursor hooks, one
> is fbcon-specific, and the other is for use only in userspace, which needs
> to be more comprehensive. Or if a single but comprehensive cursor API is
> preferred, then we just adapt fbcon_cursor to use the more powerful
> cursor API.
> 
> So, anyone want to propose a cursor API for fbdev, that is both usable by
> fbcon and userspace?
> 
> Tony
> 
> 
> 


-- 
Jon Smirl
jonsmirl@gmail.com

[-- Attachment #2: Type: text/html, Size: 2474 bytes --]