Re: Move softcursor out of fbdev to fbcon

[Jon Smirl <jonsmirl@gmail.com>]

On 7/27/05, Antonino A. Daplas <adaplas@gmail.com> wrote:
> The changelog says it all. This is a modification of Jon's patch, but
> I have moved softcursor.c to the console directory.  Also I removed
> the "select FB_SOFTCURSOR" from video/Kconfig and made the compilation
> of softcursor unconditional, if framebuffer console is enabled.
> 
> I don't think the fb_cursor hook is usable by other programs, so we
> should just restrict this hook for fbcon use only.  For userspace cursor
> support, we need a new one.  But instead of one function, I believe
> it's better to provide several.  Ie, something like below:
> 
> fbcursor_show()
> fbcursor_move()
> fbcursor_loadimage()
> fbcursor_loadpalette()
> fbcursor_start()
> fbcursor_stop()

What does start/stop do?

> 
> No need to pass all variables to just, say, move the cursor to x,y.
> 
> And the next step is to eliminate all fbcon-specific fields from
> fb_info to another structure, such as fb_imageblit, fb_fillrect,
> fb_cursor, fb_copyarea.  We'll have a smaller kernel size for
> if fbcon is not enabled.

It has always bugged me that there was no real interface between
fbconsole and fbdev. For example I tried to write a wrapper for DRM so
that fbconsole could use DRM for accelerated console. But fbconsole is
so tied into the fbdev data structures writing the wrapper required me
to build most of an fbdev driver. I shouldn't need to do that,
fbconsole should not be poking at fb_info, it should use an API for
making changes.

> 
> Comments?
> 
> Tony

-- 
Jon Smirl
jonsmirl@gmail.com


-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id\x16492&op=click