All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Smirl <jonsmirl@gmail.com>
To: fbdev <linux-fbdev-devel@lists.sourceforge.net>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Choosing the correct framebuffer configuration
Date: Fri, 5 Aug 2005 21:47:24 -0400	[thread overview]
Message-ID: <9e473391050805184756f055ea@mail.gmail.com> (raw)

If I understand things correctly the framebuffer config is supposed to
be controlled by the transp/red/blue/green fields of fb_var_screeninfo
during check_var. These fields are then combined to compute the
bits_per_pixel.

radeonfb is working from the other direction, it starts with bpp and
then computes ARGB. This looks wrong to me.

Radeonfb supports these four configs controlled by setting BPP:
DST_8BPP = 8BPP indexed
DST_15BPP = ARGB1555
DST_16BPP = RGB565
DST_32BPP = ARGB8888

The chips actually allow nine configs (maybe more when I get a look at
the R300 doc). It is ambiguous to set these configs based on BPP since
there are multiple configs for various BPP. These configs should
instead be set with the transp/red/blue/green fields.

4bpp Index = /4
8bpp Index = /8
16bpp aRGB 1555 = 1/5/5/5
16bpp RGB 565 = /5/6/5
16bpp aRGB 4444 = 4/4/4/4
16bpp aIndex 88 = 8/8
24bpp RGB 888 = /8/8/8
32bpp aRGB 8888 = 8/8/8/8
32bpp aRGB 2:10:10:10 = 2/10/10/10

What is the best way to fix this? The interesting hidden config is 30b color.

I can hack it in by using ARGB if BPP is zero and the old scheme if BPP is set.

Do other fbdev drivers have this problem?

BTW, Xserver is limited to six of the nine configs.

-- 
Jon Smirl
jonsmirl@gmail.com


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

             reply	other threads:[~2005-08-06  1:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-06  1:47 Jon Smirl [this message]
2005-08-06 23:12 ` Choosing the correct framebuffer configuration Petr Vandrovec
2005-08-07  9:48 ` Geert Uytterhoeven
2005-08-07 15:33   ` Jon Smirl
2005-08-07 16:00     ` Michel Dänzer
2005-08-07 16:14       ` Benjamin Herrenschmidt
2005-08-07 16:32         ` Michel Dänzer
2005-08-07 16:53           ` Jon Smirl
2005-08-07 20:34             ` Geert Uytterhoeven
2005-08-07 20:38             ` Michel Dänzer
2005-08-07 20:47             ` Antonino A. Daplas
2005-08-07 16:15       ` Jon Smirl
2005-08-07 11:00 ` Antonino A. Daplas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e473391050805184756f055ea@mail.gmail.com \
    --to=jonsmirl@gmail.com \
    --cc=benh@kernel.crashing.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.