Re: [PATCH] Don't allow softcursor use from userland

[Jon Smirl <jonsmirl@gmail.com>]

On 8/8/05, James Simmons <jsimmons@infradead.org> wrote:
> 
> 
> What is wrong with brekaing this patch into smaller pieces????????????
> I'm not getting a answer!!!!! As I said no giant patches that tocuh every
> driver.
> 
> > > has software image blit and hardware fillrect. You want to have fbcon use
> > >
> >
> > Then the driver sets fbops->fb_cursor with its own version that does
> > fillrect instead of imageblit.
> 
> No. fb_cursor is only used for a hardware cursor case.
> 
> > If you want to add userspace support for hardware cursors then you have to
> > create another API. If you don't want another API, then forget about userspace
> > support. Overloading fbops->fb_cursor is not the answer.
> 
> So fbops->fb_cursor will not be used at all for the console?

fbconsole check to see if fbops->fb_cursor is not null, if it is not
null it uses the hardware cursor. Otherwise it uses it's internal
softcursor implementation.

> 
> Look the patch I sent is small and doesn't interfere with many drivers. It
> does stop your desires either. Personally softcursor should go away.
> 
> 
> 
> -------------------------------------------------------
> SF.Net email is Sponsored by the Better Software Conference & EXPO
> September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
> Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
> Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
> _______________________________________________
> Linux-fbdev-devel mailing list
> Linux-fbdev-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel
> 


-- 
Jon Smirl
jonsmirl@gmail.com


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf