From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Smirl Subject: Re: Re: [PATCH] mach64 atari patch Date: Mon, 8 Aug 2005 15:01:24 -0400 Message-ID: <9e473391050808120111ee33ee@mail.gmail.com> References: <20050807094618.0cc4cadc.akpm@osdl.org> <42F699DC.20103@gmail.com> <9e47339105080716487e59df5c@mail.gmail.com> <9e4733910508081056714061fe@mail.gmail.com> <9e473391050808113479fa1501@mail.gmail.com> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1E2dm3-0004hb-1o for linux-fbdev-devel@lists.sourceforge.net; Tue, 09 Aug 2005 16:44:47 -0700 Received: from externalmx-1.sourceforge.net ([12.152.184.25]) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1E2dGn-0005lJ-Fj for linux-fbdev-devel@lists.sourceforge.net; Tue, 09 Aug 2005 16:12:29 -0700 Received: from wproxy.gmail.com ([64.233.184.193]) by externalmx-1.sourceforge.net with esmtp (Exim 4.41) id 1E2TyB-0004Nb-Vg for linux-fbdev-devel@lists.sourceforge.net; Tue, 09 Aug 2005 06:16:40 -0700 Received: by wproxy.gmail.com with SMTP id i17so752696wra for ; Tue, 09 Aug 2005 06:16:32 -0700 (PDT) In-Reply-To: Content-Disposition: inline Sender: linux-fbdev-devel-admin@lists.sourceforge.net Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: List-Post: List-Help: List-Subscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii" To: James Simmons Cc: linux-fbdev-devel@lists.sourceforge.net, Geert Uytterhoeven , "Antonino A. Daplas" , Andrew Morton On 8/8/05, James Simmons wrote: >=20 > > > au1100fb int nohwcursor > > > intelfb int hwcursor > > > nvidia int hwcur > > > cyberfb > > > > > > You need to remove this!!!! > > > > > > What I am arguing is that drivers with hardware cursor support should= be > > > able to turn off and on hardware cursor support. That is why the > > > HWACCEL_CURSOR flag. Your test the fb_cursor field prevents this!!! > > > > If you want fbconsole to use the software cusor instead of the > > hardware cursor, that's between you and fbconsole to decide. Control > > over that choice needs to be in fbconsole, not the base fbdev. > > > > The fbdev drivers should just unconditionally offer the hardware > > cursor if they support it. It is up to the user of the cursor to > > choose whether to use it or ignore it. >=20 > Finally you see the point I was making. I wanted it be very clear to ever= y > one here the implications of your changes. You remove the power to contro= l > the use of a hardware cursor from the driver. At this point driver writer= s > need to speak up if they have no problem with this. I'm not working on fbconsole so it did not occur to me what your issues was. My user space apps have always had control of whether they used the hardware cursor or not. You will need to ask Tony for a switch. Easiest way is to make it a module parameter on fbconsole. That way it will appear in /sys/module/fbconsole/parameters and you can use echo to set it from a script. There is no need for an ioctl. It only takes about five lines of code to implement this, something like th= is... fbconsole.c int use_hw_cursor =3D 0; module_parm(use_hw_cursor); if (fb_info->fb_cursor && use_hw_cursor) fb_info->fb_cursor(...) else softcursor >=20 > P.S > The patch still needs to broken into smaller pieces. >=20 >=20 >=20 --=20 Jon Smirl jonsmirl@gmail.com ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf