Re: Re: [PATCH] mach64 atari patch

[Jon Smirl <jonsmirl@gmail.com>]

On 8/8/05, James Simmons <jsimmons@infradead.org> wrote:
> 
> > Please, my patch (based from Jon's) is huge because it's removing > 200 lines
> > and it's moving softcursor.c from drivers/video to drivers/video/console where
> > it belongs. But it is _not_ intrusive.  In fact, the majority of the patch consists
> > of a single logical change which removes the line below from each driver
> >
> > - .fb_cursor = softcursor;
> >
> > and removes the line below from drivers/video/Kconfig.
> >
> > - select FB_SOFT_CURSOR
> >
> > Our proposal aims to make complex code simpler and big code smaller. Your patch,
> > on the other hand, although small, introduces another flag  FB_HWCURSOR_SOFTCURSOR,
> > which is redundant, and adds yet another level of complexity to an already too
> > complex code.
> 
> I ask you the same question as Jon. Currently several fbdev drivers have a
> optional flag to turn on and off the hardware cursor. Should this functionality

In the current code I don't view that flag as turning the hardware
cursor on/off. Instead I view it as choosing to use the software or
hardware cursor.  In my view the flag should be eliminated form fbdev.
If a driver has a hardware cursor it is always exposed.

fbconsole is then free to implement the flag if it chooses.

> be removed and force all fbdev drivers to always have the hardware cursor
> avaiable. Thus leaving fbcon to control when to use the hardware cursor
> or the software cursor. It all comes down to who controls when the
> hardware driver will use the hardware cursor. As noted several drivers
> have such a flag. You would have to strip that flag out of the drivers as
> well.


-- 
Jon Smirl
jonsmirl@gmail.com


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf