From: Konrad Leszczynski <konrad.leszczynski@intel.com>
To: Vadim Fedorenko <vadim.fedorenko@linux.dev>,
<davem@davemloft.net>, <andrew+netdev@lunn.ch>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<cezary.rojewski@intel.com>, <sebastian.basierski@intel.com>
Subject: Re: [PATCH net-next 0/7] net: stmmac: fixes and new features
Date: Thu, 28 Aug 2025 08:47:02 +0200 [thread overview]
Message-ID: <9e86a642-629d-42e9-9b70-33ea5e04343a@intel.com> (raw)
In-Reply-To: <e4cb25cb-2016-4bab-9cc2-333ea9ae9d3a@linux.dev>
On 26-Aug-25 19:29, Vadim Fedorenko wrote:
> On 26/08/2025 12:32, Konrad Leszczynski wrote:
>> This series starts with three fixes addressing KASAN panic on ethtool
>> usage, Enhanced Descriptor printing and flow stop on TC block setup when
>> interface down.
>> Everything that follows adds new features such as ARP Offload support,
>> VLAN protocol detection and TC flower filter support.
>
> Well, mixing fixes and features in one patchset is not a great idea.
> Fixes patches should have Fixes: tags and go to -net tree while features
> should go to net-next. It's better to split series into 2 and provide
> proper tags for the "fixes" part
Hi Vadim,
Thanks for the review. I've specifically placed the fixes first and the
features afterwards to not intertwine the patches. I can split them into
two patchsets if you think that's the best way to go.
next prev parent reply other threads:[~2025-08-28 6:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 11:32 [PATCH net-next 0/7] net: stmmac: fixes and new features Konrad Leszczynski
2025-08-26 11:32 ` [PATCH net-next 1/7] net: stmmac: replace memcpy with strscpy in ethtool Konrad Leszczynski
2025-08-27 19:13 ` Simon Horman
2025-08-26 11:32 ` [PATCH net-next 2/7] net: stmmac: correct Tx descriptors debugfs prints Konrad Leszczynski
2025-08-26 11:32 ` [PATCH net-next 3/7] net: stmmac: check if interface is running before TC block setup Konrad Leszczynski
2025-08-26 11:32 ` [PATCH net-next 4/7] net: stmmac: enable ARP Offload on mac_link_up() Konrad Leszczynski
2025-08-26 17:05 ` kernel test robot
2025-08-27 19:28 ` Simon Horman
2025-08-26 11:32 ` [PATCH net-next 5/7] net: stmmac: set TE/RE bits for ARP Offload when interface down Konrad Leszczynski
2025-08-26 11:32 ` [PATCH net-next 6/7] net: stmmac: enhance VLAN protocol detection for GRO Konrad Leszczynski
2025-08-27 19:35 ` Simon Horman
2025-08-26 11:32 ` [PATCH net-next 7/7] net: stmmac: add TC flower filter support for IP EtherType Konrad Leszczynski
2025-08-27 19:37 ` Simon Horman
2025-08-28 9:46 ` Konrad Leszczynski
2025-08-26 17:29 ` [PATCH net-next 0/7] net: stmmac: fixes and new features Vadim Fedorenko
2025-08-28 6:47 ` Konrad Leszczynski [this message]
2025-08-28 12:25 ` Andrew Lunn
2025-08-28 12:51 ` Konrad Leszczynski
2025-08-28 13:21 ` Vadim Fedorenko
2025-08-28 14:40 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e86a642-629d-42e9-9b70-33ea5e04343a@intel.com \
--to=konrad.leszczynski@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=cezary.rojewski@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sebastian.basierski@intel.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.