From: Mihai Moldovan <ionic@ionic.de>
To: The development of GNU GRUB <grub-devel@gnu.org>,
Vladimir 'phcoder' Serbinenko <phcoder@gmail.com>
Subject: Re: [PATCH] Warn if MBR gap is small and user uses advanced modules
Date: Tue, 10 Mar 2020 13:30:24 +0100 [thread overview]
Message-ID: <9ea2d681-cec6-29e3-e95a-03b812e1cecd@ionic.de> (raw)
In-Reply-To: <CAEaD8JNeCdWj=roOc-i-MiVunq3WbjJF2c4tSexnqUZLzS4w-A@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1268 bytes --]
* On 3/10/20 1:23 PM, Vladimir 'phcoder' Serbinenko wrote:
> [...]
> diff --git a/include/grub/util/install.h b/include/grub/util/install.h
> index 2631b1074..982115f57 100644
> --- a/include/grub/util/install.h
> +++ b/include/grub/util/install.h
> @@ -193,13 +193,13 @@ grub_util_bios_setup (const char *dir,
> const char *boot_file, const char *core_file,
> const char *dest, int force,
> int fs_probe, int allow_floppy,
> - int add_rs_codes);
> + int add_rs_codes, int warn_short_mbr_gap);
> void
> grub_util_sparc_setup (const char *dir,
> const char *boot_file, const char *core_file,
> const char *dest, int force,
> int fs_probe, int allow_floppy,
> - int add_rs_codes);
> + int add_rs_codes, int warn_short_mbr_gap);
>
> char *
> grub_install_get_image_targets_string (void);
> @@ -265,4 +265,7 @@ grub_util_get_target_name (const struct
> grub_install_image_target_desc *t);
> extern char *grub_install_copy_buffer;
> #define GRUB_INSTALL_COPY_BUFFER_SIZE 1048576
>
> +int
> +grub_install_is_short_mgrgap_supported(void);
Did you mean to use "grub_install_is_short_mbrgap_supported" instead here and in
all the other places?
Mihai
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 899 bytes --]
next prev parent reply other threads:[~2020-03-10 12:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 12:23 [PATCH] Warn if MBR gap is small and user uses advanced modules Vladimir 'phcoder' Serbinenko
2020-03-10 12:30 ` Mihai Moldovan [this message]
2020-03-11 12:43 ` Daniel Kiper
2020-03-11 14:56 ` Javier Martinez Canillas
2020-03-11 15:28 ` Michael Chang
2020-03-11 17:07 ` Didier Spaier
2020-03-11 17:42 ` Vladimir 'phcoder' Serbinenko
2020-04-27 15:41 ` Vladimir 'phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ea2d681-cec6-29e3-e95a-03b812e1cecd@ionic.de \
--to=ionic@ionic.de \
--cc=grub-devel@gnu.org \
--cc=phcoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.