From: Heiner Kallweit <hkallweit1@gmail.com>
To: Simon Horman <horms@kernel.org>
Cc: Realtek linux nic maintainers <nic_swsd@realtek.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] r8169: reconfigure rx unconditionally before chip reset when resuming
Date: Thu, 16 Oct 2025 21:22:55 +0200 [thread overview]
Message-ID: <9ece6040-58fd-4e87-bc05-a33b7341904a@gmail.com> (raw)
In-Reply-To: <aPDlC12BWk6Q_bTY@horms.kernel.org>
On 10/16/2025 2:28 PM, Simon Horman wrote:
> On Wed, Oct 15, 2025 at 10:12:44PM +0200, Heiner Kallweit wrote:
>> There's a good chance that more chip versions suffer from the same
>> hw issue. So let's reconfigure rx unconditionally before the chip reset
>> when resuming. This shouldn't have any side effect on unaffected chip
>> versions.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
> Hi Heiner,
>
> This patch looks good to me. But I think it needs to be reposted - so that
> it applies to net-next - one net has been merged into net-next so the
> following patch is present.
>
Thanks for the review. Right, I was under the impression that net was
already merged back. I'll resubmit.
> commit 70f92ab97042 ("r8169: fix packet truncation after S4 resume on RTL8168H/RTL8111H")
>
> Please feel free to add.
>
> Reviewed-by: Simon Horman <horms@kernel.org>
>
prev parent reply other threads:[~2025-10-16 19:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 20:12 [PATCH net-next] r8169: reconfigure rx unconditionally before chip reset when resuming Heiner Kallweit
2025-10-16 12:28 ` Simon Horman
2025-10-16 19:22 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ece6040-58fd-4e87-bc05-a33b7341904a@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.