From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 581EFCD3430 for ; Mon, 4 May 2026 14:59:08 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJukh-0006ek-1Q; Mon, 04 May 2026 10:58:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJukc-0006eF-Tf for qemu-arm@nongnu.org; Mon, 04 May 2026 10:58:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJuka-0005Qr-0j for qemu-arm@nongnu.org; Mon, 04 May 2026 10:58:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777906703; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=71yVqRbbZQkSWbuB+RkiKwvWO3igM1/EmA0f6JVEUuY=; b=GoKJPI1Q28a+amkxcbL7JZN17J74JBuy6V1nI8hQ5w6t3On30dthKf4D7tpn4UxXK6wdiP Uikbuy6Nb7vLd1Y6Zx66UTo7MRIBVjOW0psOGl4IGUXS1B+WhwNRdUvB5dq7kN7frm1UWQ UxN3QigsZ6lxGrriCsVcxln1PVo8Zgk= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-300-S_kFnQ90OIyY9Ajd8C_-Ug-1; Mon, 04 May 2026 10:58:20 -0400 X-MC-Unique: S_kFnQ90OIyY9Ajd8C_-Ug-1 X-Mimecast-MFC-AGG-ID: S_kFnQ90OIyY9Ajd8C_-Ug_1777906699 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-4470d6d2a4fso4775552f8f.1 for ; Mon, 04 May 2026 07:58:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777906699; x=1778511499; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=71yVqRbbZQkSWbuB+RkiKwvWO3igM1/EmA0f6JVEUuY=; b=RxqtaAk6mafTIZe42BKXqgbwyfyYnFHya1mObgxRnKZO1vejpT/3Z0xrxLrWrP0iNJ c5PCUjkndopoeZxgX+OFCoJnL/5szz1fJ9vRAIi5yRpKP/KfXn9tBsAo68qQ7aBkjdHJ k6FE8JQyW1ZkpkZWxS2qOxoe8CsoIFMt08mwjLK2aelUXlqwZRSbh7om5gIDQptHLzqc Wj7ieCHKtQI4cKz3urxCcXpkfbHwicrdmLs//TMONkIsiRalyhtZHqeEeGjv89qReMqE cufS7vOCKNhArcH/d2+yZpe/L4QqsnQCvumLUNw3A6YmCufy2ujYJL6OLuZYcZUoZUUq Fi8A== X-Forwarded-Encrypted: i=1; AFNElJ/LVq6mfSmcKaU+nTl36/y1k6SmvY6B2lftBgCuKyDT6T3bff57pLPPrwjwaTRXqt80ejllO41rUg==@nongnu.org X-Gm-Message-State: AOJu0YwETP3vRtksIShyKA33ba2IGO8TLOqdDETec6yxAob+YjZM7P/o r8wnx9RLcUozd8I2ugE8/hkjOqJUfWmu51XX2bKhpUlmFaVwvyhNB9tURC4lANnDPXa7tA32eiB h2D3Qm1TQhi8UgRmdNey3OAITXlF271cQQifPPqv2WUKaCTZ7KnKdVA== X-Gm-Gg: AeBDievhnXQb+5RlyoZux+qg1DN10xuJdElx/MmMp4M/zH09d6M+rFmDxg26IbKxPft Z/EaMBkU/iIbnNJCzSdnbSX/p/ZEGmmiXCSVHPpSxUmyV5F+9GttJJK7iBmDyBHPCWizezNfcqA 7TSslvsm/iJQih3oxo+zumj+2g0Hb7DeZzxXAz/tlNbVXAYJK9tSQ9GYJphJJWKDlkEvCgBzeXQ IpsmaJLsVOxRIOQ9dLMGgV5cEP/GQ5yj2JBVk05h7ECCY1nt2Fz1OCiwEqQmpZjDdy9nMJPaBhb W7Qaf8fi629i6Zpe4dM3MlZ4QulFW5nzYeKbwiNAyk/C557KihbQsoulRRTlmOpTLIY8wkXObY5 WOrqMO4WPcYGalSedJDowv2SQsd3XMqsIicEPgqTJkb53o3ZaSppKuTVFZjWjCyDeKeelnys= X-Received: by 2002:a05:600c:5253:b0:48a:5574:3a48 with SMTP id 5b1f17b1804b1-48a9865d948mr159645165e9.16.1777906699391; Mon, 04 May 2026 07:58:19 -0700 (PDT) X-Received: by 2002:a05:600c:5253:b0:48a:5574:3a48 with SMTP id 5b1f17b1804b1-48a9865d948mr159644785e9.16.1777906698877; Mon, 04 May 2026 07:58:18 -0700 (PDT) Received: from ?IPV6:2a01:e0a:280:24f0:9db0:474c:ff43:9f5c? ([2a01:e0a:280:24f0:9db0:474c:ff43:9f5c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a82301ad1sm513642425e9.9.2026.05.04.07.58.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 May 2026 07:58:18 -0700 (PDT) Message-ID: <9ed5337c-abaf-4f5b-b17e-04dc87165ffa@redhat.com> Date: Mon, 4 May 2026 16:58:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/7] hw/arm/smmuv3-accel: Resolve AUTO properties To: Nathan Chen , qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Eric Auger , Peter Maydell , Marcel Apfelbaum , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Yanan Wang , Zhao Liu , Shameer Kolothum , Matt Ochs , Nicolin Chen References: <20260422204335.23116-1-nathanc@nvidia.com> From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Autocrypt: addr=clg@redhat.com; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg// S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71 xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8 VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6 TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7 JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD uVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: <20260422204335.23116-1-nathanc@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: eI78pjZe7uR_VQGpYAU15PxTD35tBKV14W1pwXEQE30_1777906699 X-Mimecast-Originator: redhat.com Content-Language: en-US, fr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Hello Nathan, On 4/22/26 22:43, Nathan Chen wrote: > Hi, > > This series introduces support for resolving 'auto' for arm-smmuv3 > accelerated mode's ATS, RIL, SSIDSIZE, and OAS feature properties based > on host IOMMU capabilities. This is dependent on the series [0] for > changing these property types to accept 'auto' values. > > Accelerated SMMUv3 Address Translation Services support is derived from > IDR0, Range Invalidation support is derived from IDR3, Substream ID > size is derived from IDR1, and output address space is derived from > IDR5. > > The default values are set to 'auto' for all properties. If accel=off > and the values are set to 'auto' or are omitted and resolve to 'auto', > the default property values defined in smmuv3_init_id_regs() for OAS > and RIL will remain unchanged, while SSIDSIZE and ATS values will > remain initialized at 0. > > A complete branch can be found here: > https://github.com/NathanChenNVIDIA/qemu/tree/smmuv3-accel-auto-resolve-v2 > > Please take a look and let me know your feedback. > > Thanks, > Nathan > > [0] https://lore.kernel.org/qemu-arm/20260323182454.1416110-1-nathanc@nvidia.com/ > > Example usage: > qemu-system-aarch64 \ > -object iommufd,id=iommufd0 \ > -machine virt,accel=kvm,gic-version=3,ras=on,highmem-mmio-size=4T \ > -cpu host -smp cpus=4 -m size=16G -nographic \ > -object memory-backend-ram,size=16G,id=m0 \ > -numa node,memdev=m0,cpus=0-3,nodeid=0 \ > -numa node,nodeid=1 -numa node,nodeid=2 -numa node,nodeid=3 -numa node,nodeid=4 \ > -numa node,nodeid=5 -numa node,nodeid=6 -numa node,nodeid=7 -numa node,nodeid=8 \ > -device pxb-pcie,id=pcie.1,bus_nr=1,bus=pcie.0,numa_node=0 \ > -device arm-smmuv3,primary-bus=pcie.1,id=smmuv3.1,accel=on,ats=auto,ssidsize=auto,ril=auto,oas=auto \ > -device pcie-root-port,id=pcie.port1,bus=pcie.1,chassis=1,io-reserve=0 \ > -device vfio-pci-nohotplug,host=0009:06:00.0,bus=pcie.port1,rombar=0,id=dev0,iommufd=iommufd0,ats=auto \ > -object acpi-generic-initiator,id=gi0,pci-dev=dev0,node=1 \ > -object acpi-generic-initiator,id=gi1,pci-dev=dev0,node=2 \ > -object acpi-generic-initiator,id=gi2,pci-dev=dev0,node=3 \ > -object acpi-generic-initiator,id=gi3,pci-dev=dev0,node=4 \ > -object acpi-generic-initiator,id=gi4,pci-dev=dev0,node=5 \ > -object acpi-generic-initiator,id=gi5,pci-dev=dev0,node=6 \ > -object acpi-generic-initiator,id=gi6,pci-dev=dev0,node=7 \ > -object acpi-generic-initiator,id=gi7,pci-dev=dev0,node=8 \ > -bios /usr/share/AAVMF/AAVMF_CODE.fd \ > -device nvme,drive=nvme0,serial=deadbeaf1,bus=pcie.0 \ > -drive file=/var/lib/libvirt/images/guest.qcow2,index=0,media=disk,format=qcow2,if=none,id=nvme0 \ > -device e1000,romfile=/usr/local/share/qemu/efi-e1000.rom,netdev=net0,bus=pcie.0 \ > -netdev user,id=net0,hostfwd=tcp::5558-:22,hostfwd=tcp::5586-:5586 > > Testing: > Basic sanity testing was performed on an NVIDIA Grace platform with GPU > device assignment and running CUDA test apps on the guest. Observed the > feature properties being set based on host IOMMU capabilities. > Verified that the VM boot will fail without a cold-plugged device, and > that a hot-plugged device re-uses the resolved values from the initial > cold-plug. Additional testing and feedback are welcome. It is helpful to have a changelog between different versions of the same series of patches. So, the linux headers and vfio update are not required anymore ? Thanks, C. > > Nathan Chen (7): > hw/arm/smmuv3-accel: Add helper for resolving auto parameters > hw/arm/smmuv3-accel: Implement "auto" value for "ats" > hw/arm/smmuv3-accel: Implement "auto" value for "ril" > hw/arm/smmuv3-accel: Implement "auto" value for "ssidsize" > hw/arm/smmuv3-accel: Implement "auto" value for "oas" > hw/arm/smmuv3: Set default ats, ril, ssidsize, oas to auto > qemu-options.hx: Support "auto" for accel SMMUv3 properties > > hw/arm/smmuv3-accel.c | 80 ++++++++++++++++++++++++++++++++++++++++- > hw/arm/smmuv3-accel.h | 2 ++ > hw/arm/smmuv3.c | 63 +++++++++++++++----------------- > hw/core/machine.c | 8 +++++ > include/hw/arm/smmuv3.h | 2 ++ > qemu-options.hx | 33 +++++++++++------ > 6 files changed, 143 insertions(+), 45 deletions(-) >