Re: [RFC PATCH v4 5/5] s390: implementing CHSC SEI for AP config change

[Thomas Huth <thuth@redhat.com>]

On 14/04/2025 16.37, Rorie Reyes wrote:
> On 4/11/25 2:45 AM, Thomas Huth wrote:
> 
>> #include CONFIG_DEVICES
>>
>> at the beginning of the ioinst.c file. Then you should be able to do:
>>
>> #ifdef CONFIG_VFIO_AP
>>     if (s390_has_feat(S390_FEAT_AP)) {
>>        return ap_chsc_sei_nt0_get_event(res);
>>     }
>> #endif
> This worked
>>
>> (or whatever the code should look like).
>>
>> Alternatively, and this might even be the nicer variant, add a file hw/ 
>> vfio/ap-stub.c and include a dummy ap_chsc_sei_nt0_get_event() function 
>> there. Then in hw/vfio/meson.build add this line:
>>
>> vfio_ss.add(when: 'CONFIG_VFIO_AP', if_false: files('ap-stub.c'))
> This worked as well. Since you mentioned that this is a nicer variant, I'll 
> go with this change. What do you recommend I do for my patches? Should I do 
> an interactive rebase to add the new file hw/vfio/ap-stub.c and updating hw/ 
> vfio/meson.build? Or should I make two new commits for each file (ap-stub.c 
> and meson.build)

Please do a "git rebase -i ..." to fix up the corresponding patch (that's 
what we're doing in the QEMU development workflow).

  Thanks
   Thomas