From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17868C001B0 for ; Tue, 8 Aug 2023 12:02:43 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.579713.907795 (Exim 4.92) (envelope-from ) id 1qTLPm-00005L-Qu; Tue, 08 Aug 2023 12:02:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579713.907795; Tue, 08 Aug 2023 12:02:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTLPm-00005E-Nz; Tue, 08 Aug 2023 12:02:18 +0000 Received: by outflank-mailman (input) for mailman id 579713; Tue, 08 Aug 2023 12:02:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTLPk-00004t-Rh for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 12:02:16 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6a0d092e-35e3-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 14:02:15 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 6B9DC4EE0737; Tue, 8 Aug 2023 14:02:14 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a0d092e-35e3-11ee-8613-37d641c3527e MIME-Version: 1.0 Date: Tue, 08 Aug 2023 14:02:14 +0200 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH v2 5/5] x86: refactor macros in 'xen-mca.h' In-Reply-To: <8df1af6384606d8176525fbffb364ec814d48db1.1691492441.git.nicola.vetrini@bugseng.com> References: <8df1af6384606d8176525fbffb364ec814d48db1.1691492441.git.nicola.vetrini@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <9eea3e6039a72d0502ed1416449e041a@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 08/08/2023 13:08, Nicola Vetrini wrote: > The macros defined 'xen/include/public/arch-x86/xen-mca.h' are revised > to address the following concerns: > - needless underscore prefixes for parameter names; > - the variable 'i' in function 'mce_action' that is shadowed > by the local variable in the macro. > > Therefore, the refactoring aims to resolve present shadowing > issues, which violate MISRA C:2012 Rule 5.3, and lessen the > probability of future ones with some renames. > > No functional change. > > Signed-off-by: Nicola Vetrini > --- > Changes in v2: > - Added missing parentheses. > - Clarified commit message. > --- Missing a Reviewed-by: Stefano Stabellini from the other version, since nothing changed code-wise. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)