From: Tao Chen <chen.dylane@linux.dev>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Eduard <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>,
Matt Bobrowski <mattbobrowski@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
bpf <bpf@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
linux-trace-kernel <linux-trace-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next v4 2/2] bpf: Add show_fdinfo for kprobe_multi
Date: Fri, 20 Jun 2025 10:45:58 +0800 [thread overview]
Message-ID: <9eedd830-9222-4ac0-8ccd-72499fb85b13@linux.dev> (raw)
In-Reply-To: <CAADnVQLyAeo9ztPoJzU1QJUQf6SMptVNoOzZza02xPuXO1ES2g@mail.gmail.com>
在 2025/6/20 01:17, Alexei Starovoitov 写道:
> On Wed, Jun 18, 2025 at 8:44 PM Tao Chen <chen.dylane@linux.dev> wrote:
>>
>> Show kprobe_multi link info with fdinfo, the info as follows:
>>
>> link_type: kprobe_multi
>> link_id: 1
>> prog_tag: a15b7646cb7f3322
>> prog_id: 21
>> type: kprobe_multi
>
> ..
>
>> + seq_printf(seq,
>> + "type:\t%s\n"
>> + "kprobe_cnt:\t%u\n"
>> + "missed:\t%lu\n",
>> + kmulti_link->flags == BPF_F_KPROBE_MULTI_RETURN ? "kretprobe_multi" :
>> + "kprobe_multi",
>
> why print the same info twice ?
> seq_printf(m, "link_type:\t%s\n", bpf_link_type_strs[type]);
> in bpf_link_show_fdinfo() already did it in a cleaner way.
>
link_type only shows 'kprobe_multi', maybe we can show the format like:
// for kretprobe_multi
retprobe: true
// for kprobe_multi
retprobe: false
> Same issue in the other patch.
>
> pw-bot: cr
--
Best Regards
Tao Chen
next prev parent reply other threads:[~2025-06-20 2:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 3:42 [PATCH bpf-next v4 1/2] bpf: Add show_fdinfo for uprobe_multi Tao Chen
2025-06-19 3:42 ` [PATCH bpf-next v4 2/2] bpf: Add show_fdinfo for kprobe_multi Tao Chen
2025-06-19 17:17 ` Alexei Starovoitov
2025-06-20 2:45 ` Tao Chen [this message]
2025-06-20 2:59 ` Alexei Starovoitov
2025-06-20 3:21 ` Tao Chen
2025-06-20 3:31 ` Tao Chen
2025-06-20 18:25 ` Alexei Starovoitov
2025-06-23 2:32 ` Tao Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9eedd830-9222-4ac0-8ccd-72499fb85b13@linux.dev \
--to=chen.dylane@linux.dev \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mathieu.desnoyers@efficios.com \
--cc=mattbobrowski@google.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.