From: Shahar Avidar <ikobh7@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>,
Dan Carpenter <dan.carpenter@linaro.org>
Cc: hverkuil-cisco@xs4all.nl, andriy.shevchenko@linux.intel.com,
robh@kernel.org, felixkimbu1@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: pi433: Use class_create instead of class_register.
Date: Thu, 2 May 2024 11:51:33 +0300 [thread overview]
Message-ID: <9efb9bdf-6f79-486b-ac18-3cf501aeef82@gmail.com> (raw)
In-Reply-To: <2024050158-mutilated-zero-13b0@gregkh>
On 01/05/2024 17:14, Greg KH wrote:
> On Wed, May 01, 2024 at 05:00:44PM +0300, Dan Carpenter wrote:
>> On Wed, May 01, 2024 at 08:58:19AM +0300, Shahar Avidar wrote:
>>> Make use of a higher level API.
>>> Reduce global memory allocation from struct class to pointer size.
>>
>> Doesn't this move the memory in the opposite direction from what we
>> want? Originally, it's static const. Isn't that the simplest best
>> kind of memory?
>
> Our reviews just crossed... This is just a revert (in 2 steps oddly),
> of a previous commit that changed this api call, and for that reason
> alone we can't take it :)
>
Thank you for your input.
I replied to Greg's review on another thread.
I won't pursue this change.
--
Regards,
Shahar
next prev parent reply other threads:[~2024-05-02 8:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 5:58 [PATCH 0/2] staging: pi433: Use class_create API Shahar Avidar
2024-05-01 5:58 ` [PATCH 1/2] staging: pi433: Use class_create instead of class_register Shahar Avidar
2024-05-01 14:00 ` Dan Carpenter
2024-05-01 14:14 ` Greg KH
2024-05-02 8:51 ` Shahar Avidar [this message]
2024-05-01 14:12 ` Greg KH
2024-05-02 8:40 ` Shahar Avidar
2024-05-02 8:54 ` Greg KH
2024-05-01 5:58 ` [PATCH 2/2] staging: pi433: Rename goto label Shahar Avidar
2024-05-01 14:06 ` Dan Carpenter
2024-05-02 8:44 ` Shahar Avidar
2024-05-02 8:59 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9efb9bdf-6f79-486b-ac18-3cf501aeef82@gmail.com \
--to=ikobh7@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dan.carpenter@linaro.org \
--cc=felixkimbu1@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.