All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Tzung-Bi Shih <tzungbi@kernel.org>,
	Triet Hoang <triet.hoang.dev@gmail.com>
Cc: wim@linux-watchdog.org, linux-watchdog@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/8] watchdog: da9062: Convert to DEFINE_SIMPLE_DEV_PM_OPS()
Date: Thu, 27 Aug 2026 06:25:30 -0700	[thread overview]
Message-ID: <9f099c1c-ccc8-41f7-bae4-d0354bb4eec7@roeck-us.net> (raw)
In-Reply-To: <ao_qdLdFmcyIkLM1@google.com>

On 8/27/26 00:42, Tzung-Bi Shih wrote:
> On Wed, Aug 26, 2026 at 01:08:33PM +0700, Triet Hoang wrote:
>> diff --git a/drivers/watchdog/da9062_wdt.c b/drivers/watchdog/da9062_wdt.c
> ...
>> -static SIMPLE_DEV_PM_OPS(da9062_wdt_pm_ops,
>> +static DEFINE_SIMPLE_DEV_PM_OPS(da9062_wdt_pm_ops,
>>   			 da9062_wdt_suspend, da9062_wdt_resume);
> 
> To be neat, it'd probably like to align the parameters to '(' or simply
> combine them into a single line if it fits within the 100-col limit.
> 
> The suggestion applies to all other patches in the series as well.


I agree.

Thanks,
Guenter


  reply	other threads:[~2026-08-27 13:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-26  6:08 [PATCH 0/8] watchdog: Convert drivers to DEFINE_SIMPLE_DEV_PM_OPS() Triet Hoang
2026-08-26  6:08 ` [PATCH 1/8] watchdog: cadence_wdt: Convert " Triet Hoang
2026-08-26  6:08 ` [PATCH 2/8] watchdog: da9062: " Triet Hoang
2026-08-27  7:42   ` Tzung-Bi Shih
2026-08-27 13:25     ` Guenter Roeck [this message]
2026-08-26  6:08 ` [PATCH 3/8] watchdog: keembay_wdt: " Triet Hoang
2026-08-26  6:17   ` sashiko-bot
2026-08-26 21:38     ` Guenter Roeck
2026-08-26  6:08 ` [PATCH 4/8] watchdog: msc313e_wdt: " Triet Hoang
2026-08-26  6:20   ` sashiko-bot
2026-08-27  4:53     ` Tzung-Bi Shih
2026-08-26  6:08 ` [PATCH 5/8] watchdog: of_xilinx_wdt: " Triet Hoang
2026-08-26  6:08 ` [PATCH 6/8] watchdog: pm8916_wdt: " Triet Hoang
2026-08-26  6:08 ` [PATCH 7/8] watchdog: sp805_wdt: " Triet Hoang
2026-08-26  6:18   ` sashiko-bot
2026-08-26  6:08 ` [PATCH 8/8] watchdog: stmp3xxx_rtc_wdt: " Triet Hoang
2026-08-26  6:19   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f099c1c-ccc8-41f7-bae4-d0354bb4eec7@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=triet.hoang.dev@gmail.com \
    --cc=tzungbi@kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.