From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF09E1D5162 for ; Sat, 1 Mar 2025 10:27:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740824821; cv=none; b=CCe9a1in9Zy8NaMBgSlfOaSoNgyYlO9uPxsrhDEhV47HkadiBXozLuiNvj56WLlyiYC7ckzU7bQ0EA/USpT31G4lt9bpUeoDXILk6QPSnvWRtK+g6xOdeHGx1bqjFacn9hJ2UEr4tlck6z8IuxTIGUZfG+doGwUU7nX6Cs2/sqU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740824821; c=relaxed/simple; bh=C9Ao7ldeGPUY2w6AkdCiwXWov6DeqPBEi4i70jq8ZkU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZHwRemXRI9F/3W54PrJ5j/xaSf2k0nn5BFBXmQrkZdRR3/tlDg48qP4q5FgfItmETPUtJ0/1bPvBaDoYfIsqjXeA34ZB3Lkzjbuma05ABpWTlzUKtt3cPrO3wRwwnB5TJZNAtodu/6xNQvVGJiHkl0RqzmKFEHRAKBdZXqDrmx8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DjngzndO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DjngzndO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 712C4C4CEDD; Sat, 1 Mar 2025 10:27:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740824821; bh=C9Ao7ldeGPUY2w6AkdCiwXWov6DeqPBEi4i70jq8ZkU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=DjngzndOHK7nIaXiIyDMnNCu5b8Em/UrUKmeFUCU5rd4KI6uuhuNh3VqiV5uscO7N BlazZnWaVIOu2GhZydCkYXk+mi2Vh7UniumAveEw+UEuTVqN+xwMocAvvojy5ybune roUShqjeSX0RecPuLUgFur1afnAN4MoL8LaeksRwEQ/eVAqqHEpScIj+oXXBjMWXqM 03kckmJzEi8hlun1IC1T4qeiGGa1ZRb4Ha3TWyl3lP6lzh32zpYV3HFl1Y7SMyuRme 6vdjktyPvq8h8KIPqCwfq2e/y8aWf0nyfVv85ceba+m5zu48ovEkkMAw15pcuQQQgy cEIeI8aUiY68g== Message-ID: <9f15a79a-8495-4e73-8249-fa0f2e6d5be0@kernel.org> Date: Sat, 1 Mar 2025 11:26:58 +0100 Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH mptcp-next] tcp: ulp: diag: remove net admin restriction Content-Language: en-GB To: Mat Martineau Cc: mptcp@lists.linux.dev, Davide Caratti References: <20250226-mptcp-tcp-ulp-diag-cap-v1-1-e1a003ad0606@kernel.org> <42c413ff-744d-8b1f-e1ee-31edf0263646@kernel.org> From: Matthieu Baerts Autocrypt: addr=matttbe@kernel.org; keydata= xsFNBFXj+ekBEADxVr99p2guPcqHFeI/JcFxls6KibzyZD5TQTyfuYlzEp7C7A9swoK5iCvf YBNdx5Xl74NLSgx6y/1NiMQGuKeu+2BmtnkiGxBNanfXcnl4L4Lzz+iXBvvbtCbynnnqDDqU c7SPFMpMesgpcu1xFt0F6bcxE+0ojRtSCZ5HDElKlHJNYtD1uwY4UYVGWUGCF/+cY1YLmtfb WdNb/SFo+Mp0HItfBC12qtDIXYvbfNUGVnA5jXeWMEyYhSNktLnpDL2gBUCsdbkov5VjiOX7 CRTkX0UgNWRjyFZwThaZADEvAOo12M5uSBk7h07yJ97gqvBtcx45IsJwfUJE4hy8qZqsA62A nTRflBvp647IXAiCcwWsEgE5AXKwA3aL6dcpVR17JXJ6nwHHnslVi8WesiqzUI9sbO/hXeXw TDSB+YhErbNOxvHqCzZEnGAAFf6ges26fRVyuU119AzO40sjdLV0l6LE7GshddyazWZf0iac nEhX9NKxGnuhMu5SXmo2poIQttJuYAvTVUNwQVEx/0yY5xmiuyqvXa+XT7NKJkOZSiAPlNt6 VffjgOP62S7M9wDShUghN3F7CPOrrRsOHWO/l6I/qJdUMW+MHSFYPfYiFXoLUZyPvNVCYSgs 3oQaFhHapq1f345XBtfG3fOYp1K2wTXd4ThFraTLl8PHxCn4ywARAQABzSRNYXR0aGlldSBC YWVydHMgPG1hdHR0YmVAa2VybmVsLm9yZz7CwZEEEwEIADsCGwMFCwkIBwIGFQoJCAsCBBYC AwECHgECF4AWIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZUDpDAIZAQAKCRD2t4JPQmmgcz33 EACjROM3nj9FGclR5AlyPUbAq/txEX7E0EFQCDtdLPrjBcLAoaYJIQUV8IDCcPjZMJy2ADp7 /zSwYba2rE2C9vRgjXZJNt21mySvKnnkPbNQGkNRl3TZAinO1Ddq3fp2c/GmYaW1NWFSfOmw MvB5CJaN0UK5l0/drnaA6Hxsu62V5UnpvxWgexqDuo0wfpEeP1PEqMNzyiVPvJ8bJxgM8qoC cpXLp1Rq/jq7pbUycY8GeYw2j+FVZJHlhL0w0Zm9CFHThHxRAm1tsIPc+oTorx7haXP+nN0J iqBXVAxLK2KxrHtMygim50xk2QpUotWYfZpRRv8dMygEPIB3f1Vi5JMwP4M47NZNdpqVkHrm jvcNuLfDgf/vqUvuXs2eA2/BkIHcOuAAbsvreX1WX1rTHmx5ud3OhsWQQRVL2rt+0p1DpROI 3Ob8F78W5rKr4HYvjX2Inpy3WahAm7FzUY184OyfPO/2zadKCqg8n01mWA9PXxs84bFEV2mP VzC5j6K8U3RNA6cb9bpE5bzXut6T2gxj6j+7TsgMQFhbyH/tZgpDjWvAiPZHb3sV29t8XaOF BwzqiI2AEkiWMySiHwCCMsIH9WUH7r7vpwROko89Tk+InpEbiphPjd7qAkyJ+tNIEWd1+MlX ZPtOaFLVHhLQ3PLFLkrU3+Yi3tXqpvLE3gO3LM7BTQRV4/npARAA5+u/Sx1n9anIqcgHpA7l 5SUCP1e/qF7n5DK8LiM10gYglgY0XHOBi0S7vHppH8hrtpizx+7t5DBdPJgVtR6SilyK0/mp 9nWHDhc9rwU3KmHYgFFsnX58eEmZxz2qsIY8juFor5r7kpcM5dRR9aB+HjlOOJJgyDxcJTwM 1ey4L/79P72wuXRhMibN14SX6TZzf+/XIOrM6TsULVJEIv1+NdczQbs6pBTpEK/G2apME7vf mjTsZU26Ezn+LDMX16lHTmIJi7Hlh7eifCGGM+g/AlDV6aWKFS+sBbwy+YoS0Zc3Yz8zrdbi Kzn3kbKd+99//mysSVsHaekQYyVvO0KD2KPKBs1S/ImrBb6XecqxGy/y/3HWHdngGEY2v2IP Qox7mAPznyKyXEfG+0rrVseZSEssKmY01IsgwwbmN9ZcqUKYNhjv67WMX7tNwiVbSrGLZoqf Xlgw4aAdnIMQyTW8nE6hH/Iwqay4S2str4HZtWwyWLitk7N+e+vxuK5qto4AxtB7VdimvKUs x6kQO5F3YWcC3vCXCgPwyV8133+fIR2L81R1L1q3swaEuh95vWj6iskxeNWSTyFAVKYYVskG V+OTtB71P1XCnb6AJCW9cKpC25+zxQqD2Zy0dK3u2RuKErajKBa/YWzuSaKAOkneFxG3LJIv Hl7iqPF+JDCjB5sAEQEAAcLBXwQYAQIACQUCVeP56QIbDAAKCRD2t4JPQmmgc5VnD/9YgbCr HR1FbMbm7td54UrYvZV/i7m3dIQNXK2e+Cbv5PXf19ce3XluaE+wA8D+vnIW5mbAAiojt3Mb 6p0WJS3QzbObzHNgAp3zy/L4lXwc6WW5vnpWAzqXFHP8D9PTpqvBALbXqL06smP47JqbyQxj Xf7D2rrPeIqbYmVY9da1KzMOVf3gReazYa89zZSdVkMojfWsbq05zwYU+SCWS3NiyF6QghbW voxbFwX1i/0xRwJiX9NNbRj1huVKQuS4W7rbWA87TrVQPXUAdkyd7FRYICNW+0gddysIwPoa KrLfx3Ba6Rpx0JznbrVOtXlihjl4KV8mtOPjYDY9u+8x412xXnlGl6AC4HLu2F3ECkamY4G6 UxejX+E6vW6Xe4n7H+rEX5UFgPRdYkS1TA/X3nMen9bouxNsvIJv7C6adZmMHqu/2azX7S7I vrxxySzOw9GxjoVTuzWMKWpDGP8n71IFeOot8JuPZtJ8omz+DZel+WCNZMVdVNLPOd5frqOv mpz0VhFAlNTjU1Vy0CnuxX3AM51J8dpdNyG0S8rADh6C8AKCDOfUstpq28/6oTaQv7QZdge0 JY6dglzGKnCi/zsmp2+1w559frz4+IC7j/igvJGX4KDDKUs0mlld8J2u2sBXv7CGxdzQoHaz lzVbFe7fduHbABmYz9cefQpO7wDE/Q== Organization: NGI0 Core In-Reply-To: <42c413ff-744d-8b1f-e1ee-31edf0263646@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Mat, On 28/02/2025 22:39, Mat Martineau wrote: > On Wed, 26 Feb 2025, Matthieu Baerts (NGI0) wrote: > >> Since its introduction in commit 61723b393292 ("tcp: ulp: add functions >> to dump ulp-specific information"), the ULP diag info have been exported >> only if the requester had CAP_NET_ADMIN. >> >> It looks like there is nothing sensitive being exported here by the >> MPTCP and KTLS layers. So it seems safe to remove this restriction in >> order to ease the debugging from the userspace side without requiring >> additional capabilities. >> > > Hi Matthieu - > > I agree the token values aren't sensitive (we definitely wouldn't want > to expose the keys exchanged with MP_CAPABLE, for example). Token values > are like port numbers in terms of what's exposed. > > The DSS mapping and ssn_offset do give all users on the system access to > narrow ranges of values for the subflow TCP sequence numbers and MPTCP- > level DSNs. The diag interface doesn't expose TCP sequence numbers for > TCP sockets, it doesn't seem like a good idea to leak those through the > mapping values either. WDYT? Indeed, I was still thinking about that, and that's why I didn't send this patch to netdev. It sounds safer to let the different layers decide on what can be exposed. In MPTCP case, it sounds indeed better not to expose sequence numbers, only the token, IDs, and flags. I will resurrect my previous version where I passed "net_admin" to the two ULP diag callbacks. Cheers, Matt -- Sponsored by the NGI0 Core fund.