From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6EB76C433F5 for ; Tue, 17 May 2022 09:42:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fHttJpjR1KcFZNz6+FyUE20UHLNo2a6lMo/N3CXLEDI=; b=1xqZY1DlLnnaxN dK51rOANtncz2UWAx2BQ1k0DxCo5vVi/JFz5rR6c5U0LU5HhxhOpCbPTqHVVYfhAB7/VzkqGuTgWa AMatTA3nCTW6VmqQ3UNfyLSkT5U3GgEA+R0cOlq3sE9z5NHE+eBpubvxz3oN4Ri5nkKnnWp98ZTNX /b6PZ6krSTYncdkbm33kJmMj7o4wPMdHLsGxufvDJ8dVRK/chNcQwATRhlIO0GfayphiftO1spA/X hN78bZJKQc0FpyZoZ5tXN1z3yClmD4Sj327EFZnZo54dvrEnsZNGOvzjxCdSTwweV8uflFnWmGm1B RVczP89jUBIWBbMPfg6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqtiJ-00Cp9I-E8; Tue, 17 May 2022 09:41:59 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqthu-00Coyv-9k; Tue, 17 May 2022 09:41:35 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 6C4FE1F4444E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652780492; bh=PPIgkaWPk15dgyzq/HkLMqHpY+oCN4E+hy9YI/AB2gQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SZZBfKPMKBju08Lyb4AOiSQs6ZlnukomJCj4jXKLU2mNyz8OITOLZzAA4hJVeGhRR sySdPoksQFofTHDPdCT8We/pIPDYG8aa7/+T15Wv6ILq7X8k9UIIS/k3/rVKMc4xtM SMiHBMBSzHtFrBmFqLLieAj6+CJyFPJveZN421psOX1TRGHL0I+SviNhejNig4u+zJ KI04i3GQFvMDTu0aZNUqF+HcExc4UaRtIC0lFCBJ6fGt41pdRd6MMowsZqv+caa3tl wEbTLEiSTGcpxOFsF351xVItZjDn2S5vSnLo+HdtELq3qTXpxsmJDU5/1B+vwREv74 8MUO+yL7LHvPQ== Message-ID: <9f197c69-fe04-b636-afb7-8474763c8a3a@collabora.com> Date: Tue, 17 May 2022 11:41:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 1/5] soc: mediatek: pwrap: Use readx_poll_timeout() instead of custom function Content-Language: en-US To: Matthias Brugger Cc: linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, nfraprado@collabora.com, rex-bc.chen@mediatek.com, zhiyong.tao@mediatek.com References: <20220516124659.69484-1-angelogioacchino.delregno@collabora.com> <20220516124659.69484-2-angelogioacchino.delregno@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220517_024134_596423_755023B9 X-CRM114-Status: GOOD ( 20.19 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org SWwgMTcvMDUvMjIgMTE6MjUsIE1hdHRoaWFzIEJydWdnZXIgaGEgc2NyaXR0bzoKPiAKPiAKPiBP biAxNi8wNS8yMDIyIDE0OjQ2LCBBbmdlbG9HaW9hY2NoaW5vIERlbCBSZWdubyB3cm90ZToKPj4g RnVuY3Rpb24gcHdyYXBfd2FpdF9mb3Jfc3RhdGUoKSBpcyBhIGZ1bmN0aW9uIHRoYXQgcG9sbHMg YW4gYWRkcmVzcwo+PiB0aHJvdWdoIGEgaGVscGVyIGZ1bmN0aW9uLCBidXQgdGhpcyBpcyB0aGUg dmVyeSBzYW1lIG9wZXJhdGlvbiB0aGF0Cj4+IHRoZSByZWFkeF9wb2xsX3RpbWVvdXQgbWFjcm8g bWVhbnMgdG8gZG8uCj4+IENvbnZlcnQgYWxsIGluc3RhbmNlcyBvZiBjYWxsaW5nIHB3cmFwX3dh aXRfZm9yX3N0YXRlKCkgdG8gaW5zdGVhZAo+PiB1c2UgdGhlIHJlYWRfcG9sbF90aW1lb3V0IG1h Y3JvLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBBbmdlbG9HaW9hY2NoaW5vIERlbCBSZWdubyA8YW5n ZWxvZ2lvYWNjaGluby5kZWxyZWdub0Bjb2xsYWJvcmEuY29tPgo+PiBSZXZpZXdlZC1ieTogTsOt Y29sYXMgRi4gUi4gQS4gUHJhZG8gPG5mcmFwcmFkb0Bjb2xsYWJvcmEuY29tPgo+PiBUZXN0ZWQt Ynk6IE7DrWNvbGFzIEYuIFIuIEEuIFByYWRvIDxuZnJhcHJhZG9AY29sbGFib3JhLmNvbT4KPj4g LS0tCj4+IMKgIGRyaXZlcnMvc29jL21lZGlhdGVrL210ay1wbWljLXdyYXAuYyB8IDYwICsrKysr KysrKysrKysrKy0tLS0tLS0tLS0tLS0KPj4gwqAgMSBmaWxlIGNoYW5nZWQsIDMzIGluc2VydGlv bnMoKyksIDI3IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zb2MvbWVk aWF0ZWsvbXRrLXBtaWMtd3JhcC5jIAo+PiBiL2RyaXZlcnMvc29jL21lZGlhdGVrL210ay1wbWlj LXdyYXAuYwo+PiBpbmRleCBiZjM5YTY0ZjNlY2MuLjU0YTUzMDBhYjcyYiAxMDA2NDQKPj4gLS0t IGEvZHJpdmVycy9zb2MvbWVkaWF0ZWsvbXRrLXBtaWMtd3JhcC5jCj4+ICsrKyBiL2RyaXZlcnMv c29jL21lZGlhdGVrL210ay1wbWljLXdyYXAuYwo+PiBAQCAtMTMsNiArMTMsOSBAQAo+PiDCoCAj aW5jbHVkZSA8bGludXgvcmVnbWFwLmg+Cj4+IMKgICNpbmNsdWRlIDxsaW51eC9yZXNldC5oPgo+ PiArI2RlZmluZSBQV1JBUF9QT0xMX0RFTEFZX1VTwqDCoMKgIDEwCj4+ICsjZGVmaW5lIFBXUkFQ X1BPTExfVElNRU9VVF9VU8KgwqDCoCAxMDAwMAo+PiArCj4+IMKgICNkZWZpbmUgUFdSQVBfTVQ4 MTM1X0JSSURHRV9JT1JEX0FSQl9FTsKgwqDCoMKgwqDCoMKgIDB4NAo+PiDCoCAjZGVmaW5lIFBX UkFQX01UODEzNV9CUklER0VfV0FDUzNfRU7CoMKgwqDCoMKgwqDCoCAweDEwCj4+IMKgICNkZWZp bmUgUFdSQVBfTVQ4MTM1X0JSSURHRV9JTklUX0RPTkUzwqDCoMKgwqDCoMKgwqAgMHgxNAo+PiBA QCAtMTI0MSwyNyArMTI0NCwxNCBAQCBzdGF0aWMgYm9vbCBwd3JhcF9pc19mc21faWRsZV9hbmRf c3luY19pZGxlKHN0cnVjdCAKPj4gcG1pY193cmFwcGVyICp3cnApCj4+IMKgwqDCoMKgwqDCoMKg wqDCoCAodmFsICYgUFdSQVBfU1RBVEVfU1lOQ19JRExFMCk7Cj4+IMKgIH0KPj4gLXN0YXRpYyBp bnQgcHdyYXBfd2FpdF9mb3Jfc3RhdGUoc3RydWN0IHBtaWNfd3JhcHBlciAqd3JwLAo+PiAtwqDC oMKgwqDCoMKgwqAgYm9vbCAoKmZwKShzdHJ1Y3QgcG1pY193cmFwcGVyICopKQo+PiAtewo+PiAt wqDCoMKgIHVuc2lnbmVkIGxvbmcgdGltZW91dDsKPj4gLQo+PiAtwqDCoMKgIHRpbWVvdXQgPSBq aWZmaWVzICsgdXNlY3NfdG9famlmZmllcygxMDAwMCk7Cj4+IC0KPj4gLcKgwqDCoCBkbyB7Cj4+ IC3CoMKgwqDCoMKgwqDCoCBpZiAodGltZV9hZnRlcihqaWZmaWVzLCB0aW1lb3V0KSkKPj4gLcKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIGZwKHdycCkgPyAwIDogLUVUSU1FRE9VVDsKPj4g LcKgwqDCoMKgwqDCoMKgIGlmIChmcCh3cnApKQo+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBy ZXR1cm4gMDsKPj4gLcKgwqDCoCB9IHdoaWxlICgxKTsKPj4gLX0KPj4gLQo+PiDCoCBzdGF0aWMg aW50IHB3cmFwX3JlYWQxNihzdHJ1Y3QgcG1pY193cmFwcGVyICp3cnAsIHUzMiBhZHIsIHUzMiAq cmRhdGEpCj4+IMKgIHsKPj4gK8KgwqDCoCBib29sIHRtcDsKPj4gwqDCoMKgwqDCoCBpbnQgcmV0 Owo+PiDCoMKgwqDCoMKgIHUzMiB2YWw7Cj4+IC3CoMKgwqAgcmV0ID0gcHdyYXBfd2FpdF9mb3Jf c3RhdGUod3JwLCBwd3JhcF9pc19mc21faWRsZSk7Cj4+ICvCoMKgwqAgcmV0ID0gcmVhZHhfcG9s bF90aW1lb3V0KHB3cmFwX2lzX2ZzbV9pZGxlLCB3cnAsIHRtcCwgdG1wLAo+IAo+IGhtLCBpZiB3 ZSBtYWtlIHRoZSBjb25kICh0bXAgPiAwKSB0aGF0IHdvdWxkIGhlbHAgdG8gdW5kZXJzdGFuZCB0 aGUgY29kZS4gQXQgbGVhc3QgCj4gSSBoYWQgdG8gdGhpbmsgYWJvdXQgaXQgZm9yIGEgbW9tZW50 LiBCdXQgSSBsZWF2ZSBpdCB0byB5b3UgaWYgeW91IHRoaW5rIGl0J3Mgd29ydGggCj4gdGhlIGVm Zm9ydC4KPiAKCkkgd291bGQgcHJlZmVyIHNpemUgb3ZlciByZWFkYWJpbGl0eSBpbiB0aGlzIGNh c2UuLi4gaWYgd2UgZG8gKHRtcCA+IDApLCBpdCB3b3VsZApiZSBpbmNvcnJlY3QgdG8ga2VlcCB0 bXAgYXMgYSBgYm9vbGAsIHdlIHdvdWxkIGhhdmUgdG8gc2V0IGl0IGFzIGFuIGludGVnZXIgdmFy LAp3aGljaCBpcyB1bm5lY2Vzc2FyaWx5IGJpZ2dlciAodGhhdCdzIHRoZSByZWFzb24gd2h5IEkg d3JvdGUgaXQgbGlrZSBzbyEpLgoKQW5vdGhlciB3YXkgdG8gaW5jcmVhc2UgaHVtYW4gcmVhZGFi aWxpdHkgd291bGQgYmUgdG8gZG8gKHRtcCA9PSB0cnVlKSwgYnV0IGl0Cmxvb2tzIGEgYml0IHdl aXJkIHRvIG1lLCBkb2Vzbid0IGl0PwpJZiB5b3UgZGlzYWdyZWUgYWJvdXQgdGhhdCBsb29raW5n IHdlaXJkLCB0aG91Z2gsIEkgY2FuIGdvIHdpdGggdGhhdCBvbmUsIHBlcmhhcHMhCgpDaGVlcnMs CkFuZ2VsbwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K TGludXgtbWVkaWF0ZWsgbWFpbGluZyBsaXN0CkxpbnV4LW1lZGlhdGVrQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1t ZWRpYXRlawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 277AFC433EF for ; Tue, 17 May 2022 09:42:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r7Zzid5QNdcARgxhYYDsgYS782W6vst846L7lII6LhE=; b=Z60yzbnta/jmQt RLrdJetI72f8Pjxs+gt2wVTSoY4kKAwV8WjMbsgal/ZUu7dTr09r31iC7sCQ3FYVB+Fnno/6vV5X4 TZqcWVbRNRW8hjwbnlFLfDJUIThdTydPuUsn2PKIa0B0MD01n8Ht1yqlYRQFgJl/OsGWT8/lOdoOn I/K5ZxkgoT7tjVlxMRnMZVwvlC1JeAIye3vS8qRwALRNQik4Nu7v+pJtmBEB+BG4UxTZ5rRyJt1Us JJDvjMjU4ZGMUudQUooTqDnPsFFT7PocpzRBIckOQI8Y/oQDE5CTEaYw8LMaKr9siIKz0XgfYZjHS oWOVqTgsAS17B/sscwPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqthy-00Cp1A-Ne; Tue, 17 May 2022 09:41:39 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqthu-00Coyv-9k; Tue, 17 May 2022 09:41:35 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 6C4FE1F4444E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652780492; bh=PPIgkaWPk15dgyzq/HkLMqHpY+oCN4E+hy9YI/AB2gQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SZZBfKPMKBju08Lyb4AOiSQs6ZlnukomJCj4jXKLU2mNyz8OITOLZzAA4hJVeGhRR sySdPoksQFofTHDPdCT8We/pIPDYG8aa7/+T15Wv6ILq7X8k9UIIS/k3/rVKMc4xtM SMiHBMBSzHtFrBmFqLLieAj6+CJyFPJveZN421psOX1TRGHL0I+SviNhejNig4u+zJ KI04i3GQFvMDTu0aZNUqF+HcExc4UaRtIC0lFCBJ6fGt41pdRd6MMowsZqv+caa3tl wEbTLEiSTGcpxOFsF351xVItZjDn2S5vSnLo+HdtELq3qTXpxsmJDU5/1B+vwREv74 8MUO+yL7LHvPQ== Message-ID: <9f197c69-fe04-b636-afb7-8474763c8a3a@collabora.com> Date: Tue, 17 May 2022 11:41:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 1/5] soc: mediatek: pwrap: Use readx_poll_timeout() instead of custom function Content-Language: en-US To: Matthias Brugger Cc: linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, nfraprado@collabora.com, rex-bc.chen@mediatek.com, zhiyong.tao@mediatek.com References: <20220516124659.69484-1-angelogioacchino.delregno@collabora.com> <20220516124659.69484-2-angelogioacchino.delregno@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220517_024134_596423_755023B9 X-CRM114-Status: GOOD ( 20.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SWwgMTcvMDUvMjIgMTE6MjUsIE1hdHRoaWFzIEJydWdnZXIgaGEgc2NyaXR0bzoKPiAKPiAKPiBP biAxNi8wNS8yMDIyIDE0OjQ2LCBBbmdlbG9HaW9hY2NoaW5vIERlbCBSZWdubyB3cm90ZToKPj4g RnVuY3Rpb24gcHdyYXBfd2FpdF9mb3Jfc3RhdGUoKSBpcyBhIGZ1bmN0aW9uIHRoYXQgcG9sbHMg YW4gYWRkcmVzcwo+PiB0aHJvdWdoIGEgaGVscGVyIGZ1bmN0aW9uLCBidXQgdGhpcyBpcyB0aGUg dmVyeSBzYW1lIG9wZXJhdGlvbiB0aGF0Cj4+IHRoZSByZWFkeF9wb2xsX3RpbWVvdXQgbWFjcm8g bWVhbnMgdG8gZG8uCj4+IENvbnZlcnQgYWxsIGluc3RhbmNlcyBvZiBjYWxsaW5nIHB3cmFwX3dh aXRfZm9yX3N0YXRlKCkgdG8gaW5zdGVhZAo+PiB1c2UgdGhlIHJlYWRfcG9sbF90aW1lb3V0IG1h Y3JvLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBBbmdlbG9HaW9hY2NoaW5vIERlbCBSZWdubyA8YW5n ZWxvZ2lvYWNjaGluby5kZWxyZWdub0Bjb2xsYWJvcmEuY29tPgo+PiBSZXZpZXdlZC1ieTogTsOt Y29sYXMgRi4gUi4gQS4gUHJhZG8gPG5mcmFwcmFkb0Bjb2xsYWJvcmEuY29tPgo+PiBUZXN0ZWQt Ynk6IE7DrWNvbGFzIEYuIFIuIEEuIFByYWRvIDxuZnJhcHJhZG9AY29sbGFib3JhLmNvbT4KPj4g LS0tCj4+IMKgIGRyaXZlcnMvc29jL21lZGlhdGVrL210ay1wbWljLXdyYXAuYyB8IDYwICsrKysr KysrKysrKysrKy0tLS0tLS0tLS0tLS0KPj4gwqAgMSBmaWxlIGNoYW5nZWQsIDMzIGluc2VydGlv bnMoKyksIDI3IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zb2MvbWVk aWF0ZWsvbXRrLXBtaWMtd3JhcC5jIAo+PiBiL2RyaXZlcnMvc29jL21lZGlhdGVrL210ay1wbWlj LXdyYXAuYwo+PiBpbmRleCBiZjM5YTY0ZjNlY2MuLjU0YTUzMDBhYjcyYiAxMDA2NDQKPj4gLS0t IGEvZHJpdmVycy9zb2MvbWVkaWF0ZWsvbXRrLXBtaWMtd3JhcC5jCj4+ICsrKyBiL2RyaXZlcnMv c29jL21lZGlhdGVrL210ay1wbWljLXdyYXAuYwo+PiBAQCAtMTMsNiArMTMsOSBAQAo+PiDCoCAj aW5jbHVkZSA8bGludXgvcmVnbWFwLmg+Cj4+IMKgICNpbmNsdWRlIDxsaW51eC9yZXNldC5oPgo+ PiArI2RlZmluZSBQV1JBUF9QT0xMX0RFTEFZX1VTwqDCoMKgIDEwCj4+ICsjZGVmaW5lIFBXUkFQ X1BPTExfVElNRU9VVF9VU8KgwqDCoCAxMDAwMAo+PiArCj4+IMKgICNkZWZpbmUgUFdSQVBfTVQ4 MTM1X0JSSURHRV9JT1JEX0FSQl9FTsKgwqDCoMKgwqDCoMKgIDB4NAo+PiDCoCAjZGVmaW5lIFBX UkFQX01UODEzNV9CUklER0VfV0FDUzNfRU7CoMKgwqDCoMKgwqDCoCAweDEwCj4+IMKgICNkZWZp bmUgUFdSQVBfTVQ4MTM1X0JSSURHRV9JTklUX0RPTkUzwqDCoMKgwqDCoMKgwqAgMHgxNAo+PiBA QCAtMTI0MSwyNyArMTI0NCwxNCBAQCBzdGF0aWMgYm9vbCBwd3JhcF9pc19mc21faWRsZV9hbmRf c3luY19pZGxlKHN0cnVjdCAKPj4gcG1pY193cmFwcGVyICp3cnApCj4+IMKgwqDCoMKgwqDCoMKg wqDCoCAodmFsICYgUFdSQVBfU1RBVEVfU1lOQ19JRExFMCk7Cj4+IMKgIH0KPj4gLXN0YXRpYyBp bnQgcHdyYXBfd2FpdF9mb3Jfc3RhdGUoc3RydWN0IHBtaWNfd3JhcHBlciAqd3JwLAo+PiAtwqDC oMKgwqDCoMKgwqAgYm9vbCAoKmZwKShzdHJ1Y3QgcG1pY193cmFwcGVyICopKQo+PiAtewo+PiAt wqDCoMKgIHVuc2lnbmVkIGxvbmcgdGltZW91dDsKPj4gLQo+PiAtwqDCoMKgIHRpbWVvdXQgPSBq aWZmaWVzICsgdXNlY3NfdG9famlmZmllcygxMDAwMCk7Cj4+IC0KPj4gLcKgwqDCoCBkbyB7Cj4+ IC3CoMKgwqDCoMKgwqDCoCBpZiAodGltZV9hZnRlcihqaWZmaWVzLCB0aW1lb3V0KSkKPj4gLcKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIGZwKHdycCkgPyAwIDogLUVUSU1FRE9VVDsKPj4g LcKgwqDCoMKgwqDCoMKgIGlmIChmcCh3cnApKQo+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBy ZXR1cm4gMDsKPj4gLcKgwqDCoCB9IHdoaWxlICgxKTsKPj4gLX0KPj4gLQo+PiDCoCBzdGF0aWMg aW50IHB3cmFwX3JlYWQxNihzdHJ1Y3QgcG1pY193cmFwcGVyICp3cnAsIHUzMiBhZHIsIHUzMiAq cmRhdGEpCj4+IMKgIHsKPj4gK8KgwqDCoCBib29sIHRtcDsKPj4gwqDCoMKgwqDCoCBpbnQgcmV0 Owo+PiDCoMKgwqDCoMKgIHUzMiB2YWw7Cj4+IC3CoMKgwqAgcmV0ID0gcHdyYXBfd2FpdF9mb3Jf c3RhdGUod3JwLCBwd3JhcF9pc19mc21faWRsZSk7Cj4+ICvCoMKgwqAgcmV0ID0gcmVhZHhfcG9s bF90aW1lb3V0KHB3cmFwX2lzX2ZzbV9pZGxlLCB3cnAsIHRtcCwgdG1wLAo+IAo+IGhtLCBpZiB3 ZSBtYWtlIHRoZSBjb25kICh0bXAgPiAwKSB0aGF0IHdvdWxkIGhlbHAgdG8gdW5kZXJzdGFuZCB0 aGUgY29kZS4gQXQgbGVhc3QgCj4gSSBoYWQgdG8gdGhpbmsgYWJvdXQgaXQgZm9yIGEgbW9tZW50 LiBCdXQgSSBsZWF2ZSBpdCB0byB5b3UgaWYgeW91IHRoaW5rIGl0J3Mgd29ydGggCj4gdGhlIGVm Zm9ydC4KPiAKCkkgd291bGQgcHJlZmVyIHNpemUgb3ZlciByZWFkYWJpbGl0eSBpbiB0aGlzIGNh c2UuLi4gaWYgd2UgZG8gKHRtcCA+IDApLCBpdCB3b3VsZApiZSBpbmNvcnJlY3QgdG8ga2VlcCB0 bXAgYXMgYSBgYm9vbGAsIHdlIHdvdWxkIGhhdmUgdG8gc2V0IGl0IGFzIGFuIGludGVnZXIgdmFy LAp3aGljaCBpcyB1bm5lY2Vzc2FyaWx5IGJpZ2dlciAodGhhdCdzIHRoZSByZWFzb24gd2h5IEkg d3JvdGUgaXQgbGlrZSBzbyEpLgoKQW5vdGhlciB3YXkgdG8gaW5jcmVhc2UgaHVtYW4gcmVhZGFi aWxpdHkgd291bGQgYmUgdG8gZG8gKHRtcCA9PSB0cnVlKSwgYnV0IGl0Cmxvb2tzIGEgYml0IHdl aXJkIHRvIG1lLCBkb2Vzbid0IGl0PwpJZiB5b3UgZGlzYWdyZWUgYWJvdXQgdGhhdCBsb29raW5n IHdlaXJkLCB0aG91Z2gsIEkgY2FuIGdvIHdpdGggdGhhdCBvbmUsIHBlcmhhcHMhCgpDaGVlcnMs CkFuZ2VsbwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31A2BC433F5 for ; Tue, 17 May 2022 09:42:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245040AbiEQJmL (ORCPT ); Tue, 17 May 2022 05:42:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239753AbiEQJll (ORCPT ); Tue, 17 May 2022 05:41:41 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 356CB3DA68 for ; Tue, 17 May 2022 02:41:40 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 6C4FE1F4444E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652780492; bh=PPIgkaWPk15dgyzq/HkLMqHpY+oCN4E+hy9YI/AB2gQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SZZBfKPMKBju08Lyb4AOiSQs6ZlnukomJCj4jXKLU2mNyz8OITOLZzAA4hJVeGhRR sySdPoksQFofTHDPdCT8We/pIPDYG8aa7/+T15Wv6ILq7X8k9UIIS/k3/rVKMc4xtM SMiHBMBSzHtFrBmFqLLieAj6+CJyFPJveZN421psOX1TRGHL0I+SviNhejNig4u+zJ KI04i3GQFvMDTu0aZNUqF+HcExc4UaRtIC0lFCBJ6fGt41pdRd6MMowsZqv+caa3tl wEbTLEiSTGcpxOFsF351xVItZjDn2S5vSnLo+HdtELq3qTXpxsmJDU5/1B+vwREv74 8MUO+yL7LHvPQ== Message-ID: <9f197c69-fe04-b636-afb7-8474763c8a3a@collabora.com> Date: Tue, 17 May 2022 11:41:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 1/5] soc: mediatek: pwrap: Use readx_poll_timeout() instead of custom function Content-Language: en-US To: Matthias Brugger Cc: linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, nfraprado@collabora.com, rex-bc.chen@mediatek.com, zhiyong.tao@mediatek.com References: <20220516124659.69484-1-angelogioacchino.delregno@collabora.com> <20220516124659.69484-2-angelogioacchino.delregno@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 17/05/22 11:25, Matthias Brugger ha scritto: > > > On 16/05/2022 14:46, AngeloGioacchino Del Regno wrote: >> Function pwrap_wait_for_state() is a function that polls an address >> through a helper function, but this is the very same operation that >> the readx_poll_timeout macro means to do. >> Convert all instances of calling pwrap_wait_for_state() to instead >> use the read_poll_timeout macro. >> >> Signed-off-by: AngeloGioacchino Del Regno >> Reviewed-by: Nícolas F. R. A. Prado >> Tested-by: Nícolas F. R. A. Prado >> --- >>   drivers/soc/mediatek/mtk-pmic-wrap.c | 60 +++++++++++++++------------- >>   1 file changed, 33 insertions(+), 27 deletions(-) >> >> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c >> b/drivers/soc/mediatek/mtk-pmic-wrap.c >> index bf39a64f3ecc..54a5300ab72b 100644 >> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c >> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c >> @@ -13,6 +13,9 @@ >>   #include >>   #include >> +#define PWRAP_POLL_DELAY_US    10 >> +#define PWRAP_POLL_TIMEOUT_US    10000 >> + >>   #define PWRAP_MT8135_BRIDGE_IORD_ARB_EN        0x4 >>   #define PWRAP_MT8135_BRIDGE_WACS3_EN        0x10 >>   #define PWRAP_MT8135_BRIDGE_INIT_DONE3        0x14 >> @@ -1241,27 +1244,14 @@ static bool pwrap_is_fsm_idle_and_sync_idle(struct >> pmic_wrapper *wrp) >>           (val & PWRAP_STATE_SYNC_IDLE0); >>   } >> -static int pwrap_wait_for_state(struct pmic_wrapper *wrp, >> -        bool (*fp)(struct pmic_wrapper *)) >> -{ >> -    unsigned long timeout; >> - >> -    timeout = jiffies + usecs_to_jiffies(10000); >> - >> -    do { >> -        if (time_after(jiffies, timeout)) >> -            return fp(wrp) ? 0 : -ETIMEDOUT; >> -        if (fp(wrp)) >> -            return 0; >> -    } while (1); >> -} >> - >>   static int pwrap_read16(struct pmic_wrapper *wrp, u32 adr, u32 *rdata) >>   { >> +    bool tmp; >>       int ret; >>       u32 val; >> -    ret = pwrap_wait_for_state(wrp, pwrap_is_fsm_idle); >> +    ret = readx_poll_timeout(pwrap_is_fsm_idle, wrp, tmp, tmp, > > hm, if we make the cond (tmp > 0) that would help to understand the code. At least > I had to think about it for a moment. But I leave it to you if you think it's worth > the effort. > I would prefer size over readability in this case... if we do (tmp > 0), it would be incorrect to keep tmp as a `bool`, we would have to set it as an integer var, which is unnecessarily bigger (that's the reason why I wrote it like so!). Another way to increase human readability would be to do (tmp == true), but it looks a bit weird to me, doesn't it? If you disagree about that looking weird, though, I can go with that one, perhaps! Cheers, Angelo