From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BD52C001B0 for ; Wed, 19 Jul 2023 06:28:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 05B17866F7; Wed, 19 Jul 2023 08:28:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="pm3cTnf+"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D03DD86709; Wed, 19 Jul 2023 08:28:55 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on20607.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eb2::607]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7697F85813 for ; Wed, 19 Jul 2023 08:28:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D3x/0UICrKxu3cF9EeTKXw4t5Qzay/Uf9/zodFkLdh8s9ikNxN5SZMa80oQrF9sKPQN8piFuX9FzKBJHT8emehqVoff6UghZT4nu8IEAb1uEMDFIBbY5Wy1B6ydzQ/KC1N9RVbw1/gfJjB+V3dAwR9X/+PFo47zYVQGQhL5pR7FzyUxgegarPvI5s5/xiQVL0ldY7dOUoXDXVKSifkXNjNAiIayn/lexo0E6//Dcn/fdAED4h/S93gNlkT9t59cydmQ9ACmp//5O2QBca8+oMf/qXGTLWLNOdv40nPc6soEHyGTNh7xAxaFYVUHnyvsGEz02VgmdHWBSNydIa6fxFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iA8/aP+gpPZWqh4rlOzx+KEDU1yucFvFNhl8V5Ubp/Q=; b=DLJVEBxvYSQY4nQUUXvVgDpEPLm/CVBVtC9VwvL3qdFmcO3tQM0ZoBfr3+Zi8CV/K5wZJMXJq3eCQQ7gFjVViqX1CE6IqE2L2jQfqIys7DFwqABIk6sX0jdRr8L/hS9i1bfjJonFt7Zxv8Dp6sq3VifevJpZehtFCFerELGjoywUJH3a44v5xGXk9Y19vHZLmK4hUDlwZA5H7zlu4MNzvGEnDtWGItr0gBV27LYHkenztqQyuhC/IHQ3NkEaGX02ND0LqHntz8U28kHh+nFgPT6psyu/tvyam9EiESa951uh9bImYFubRho6Jcyltn2DIQ3CNDkhhgVIXoknrjGXTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iA8/aP+gpPZWqh4rlOzx+KEDU1yucFvFNhl8V5Ubp/Q=; b=pm3cTnf+cweBc0MU7aY5lYxJjCx8A+AO2+DwWaM5bbZGz+iTokQ7lVCH3ctrncv4Z8vCDHvxcvLBemKdgazazs8KF5NA/lZcGbFOq4WfdZTKBmysNE0adci8TQxEdMN5gCuj30GvRmqwsj9k3KkFv0X8pIunQ7kxqdRfBHbFCWA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from BYAPR12MB4758.namprd12.prod.outlook.com (2603:10b6:a03:a5::28) by DS7PR12MB6069.namprd12.prod.outlook.com (2603:10b6:8:9f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Wed, 19 Jul 2023 06:28:46 +0000 Received: from BYAPR12MB4758.namprd12.prod.outlook.com ([fe80::be39:45a4:cd9b:4684]) by BYAPR12MB4758.namprd12.prod.outlook.com ([fe80::be39:45a4:cd9b:4684%3]) with mapi id 15.20.6588.031; Wed, 19 Jul 2023 06:28:46 +0000 Message-ID: <9f2b578b-9e10-bf3a-2ce5-229f64b37fd3@amd.com> Date: Wed, 19 Jul 2023 08:28:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Heinrich Schuchardt Cc: Ilias Apalodimas , u-boot@lists.denx.de, git@xilinx.com References: Content-Language: en-US From: Michal Simek Subject: Re: [PATCH] efi_loader: Allow also empty capsule to be process In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0164.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::14) To BYAPR12MB4758.namprd12.prod.outlook.com (2603:10b6:a03:a5::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR12MB4758:EE_|DS7PR12MB6069:EE_ X-MS-Office365-Filtering-Correlation-Id: 0727c91f-83f2-41a8-29c5-08db88216791 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NPvbnAZTrQ5g4ihk6bxnLGj4xw6qUHUacZqDn0Rr1/QOas9LH2x/d8/aBGAugfonO5aQLsXFBc0/avuuasQJa+lUsp4zz6mBNM0mVOGeU9SR7Seq89A6LSkb3YG4COClaf/PzHI4ld2QQAvfykkIWtED+kpRrgc6eruE84BJSz0VIwRdurLuDxv1yFeeE4JuZw6GSclSc+R9hG98N9UvzzwbSKIdzZzLYTV2u5zjMPSVsi97t1+MSm+jOu4nHTC8HHYjXpx3p2lRSocWqSxNdflQemzBDVyjGWlkV+WYC+KqxXZdPuB78nPFpcplbYb6wPKLIzsf/py6y6zzl2eQGY+994hiFAtE98q7IYa4vJw2Wiy5MMsgnv28lh/C2jo1uQU6QSHcpVJyZ2CVZBcNFtpmj1ljdMD/c734gHkHLK9OT2nQtJ/4yWbe2f0NYbxM/n5NsLoC6kmCIuREEPVLqlJDYKUiFes/acolJNrY5cnNEcj0bcw8zPFQgduP5tm6LSfl5AJcBdL+kZ32iQq8RmkIxuHiQhbKVkXJ2Vw4PyvFrWJi4EkE2X8Fqqhjb07HMwLpmSWbE861thfxixjOPqfXBMIGXJx7Ow40PhCUEtpTQf9OgjXt+SUlsIOeVde9JxbEwsn7OeSruyl15E6DXQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB4758.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(396003)(136003)(376002)(366004)(39860400002)(451199021)(86362001)(478600001)(83380400001)(186003)(38100700002)(41300700001)(26005)(31696002)(31686004)(316002)(53546011)(8936002)(6916009)(8676002)(2906002)(4326008)(44832011)(66556008)(6512007)(66946007)(66476007)(6486002)(6666004)(6506007)(2616005)(36756003)(5660300002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N041cndJMWNZVVd4Y095UU40b1Zhb2VEcDFiendlREN5b0tOS3VXN1RlaXFV?= =?utf-8?B?KzVGaEtocVJTMlkxT3F2MHVSZUticXZValppdW9XWExTbHQ2V3h1RW9vaGlK?= =?utf-8?B?QnFQR3NUdjBtSWVvNnBabnRzWDZsMjJERVlZeWJQbVdJNXFKN200cXJEYXRh?= =?utf-8?B?cG9PcEVyZGFVVDJDWVJWVDRTTFR3SHYwN3VEdFdiTXI4VmRBblNOOGtDd1BU?= =?utf-8?B?MzZ2eTVkMFBPTFRZNlhyYllxcEtDZ2pUekhMK01wZmZVYlRRU1lQazlpT3R1?= =?utf-8?B?aEFGaDNoTkxtRUZTOGxLeG16QXNiandycm5iUjFETndpRGd5VnhmaG50dUl5?= =?utf-8?B?elZRTndUZ0tSNWdlRlBtK2JxS255ZnU3WUZWNTU3eVkrcXNmbTJDdHl1Y01y?= =?utf-8?B?QUFJRFdaWlp4VVdNNmo2QW52dXBZL0Y1UTJ0SjVUck1xK3hxdVQveC9MOGp0?= =?utf-8?B?anVuWm9zL1BHSkQ3L2hycS9WcWd3SFVyMzJkNnFFRnZOMnd0ZzJvS1J5VEc2?= =?utf-8?B?SEdJS1Y0MlZTWFFKbjc3NHZMeGNaNWYxdnNhR0ZuZW8yY1pqU2NxOGtDVVFQ?= =?utf-8?B?WDR0ak9yVU94U3V5VVQ5b3FvSUE0b0VtQzk5STc2Rld6VEZSdEYxSFJDckNn?= =?utf-8?B?blkycERlQWVQZ0ZlRnRHa2tkRmZ5QUJ3emV2cXo5ZmFmN0hwWVQ0ZlNlR3pY?= =?utf-8?B?OW1kMTFUMy9zUGRTRmVQdmZEcVVtZDdxQngwMm5yNkJ4VWhqMWhzS3kvaVh4?= =?utf-8?B?WmVLMmNQM0V4M2ZTUGc1clJERGZnaUtYSHcxOExkUU43N1ZkNWRFdEVBVFlu?= =?utf-8?B?b2o0N0dPVHUyUFFHT2N2cVppV3hLeHBycjVDM01XT3hjQ1dKRkltK0Z6T1lV?= =?utf-8?B?amttZ1ZzVzhrTjZCYTRHdGU1eUxybFRNNmxjQ0pqRXdmMHRaNy80WXRNeW8r?= =?utf-8?B?OEM0SmlTNmhwSlhQMVlDNHl1UWp5U0IvMjdBWGJ0V1FXSUtLQ3VhenREMDRI?= =?utf-8?B?dXNRTUpyblgveEVwdTFXOTk4TG1udWpnSFV1WjMxQ0xzYjRLaEFUdW9GZTVj?= =?utf-8?B?ZitGbUFwSWdTQnZzZkY0Vk9XanJhRmpoWFNIWWs4MXNQdWQzY1Q1ejhFQWRp?= =?utf-8?B?ZWg0cnRMT0tUNm1KUzJhQWJXYXFGZS9WZ1ZqbmxoNEltRHVpRnZKd3F4M2Vm?= =?utf-8?B?aldyTm9sVTBTcEJNdDhUaDZXcGtuL2pDZi9KR0ZIWGZpdnpCNWhLWThKUERC?= =?utf-8?B?ZUNnOGNWeGJtS0ZsY1htVm5nMUx3YjlxVWV2ajRVTi82ZzJsa0g4blJmbWto?= =?utf-8?B?VUxGaUUxSkpqaEk5cVVqcjlqRldCY3dkVTZSbWhaakpnbGo4RE1DSTREb2V6?= =?utf-8?B?a0NoS1YrWVEraWd5cjVvUFZ6dFFoam15YzViR1FvcDBZTWdBdDVEWE5QTHQv?= =?utf-8?B?SUdVTE1ibFNoSU1EeW1vY3FtSnpxYjFXeElIb0NaUE1ydnZxaXZYSkc3ZjN3?= =?utf-8?B?SlREbHhudGp5MW0yWmRxWFpsME1WNUkvU0l3VFpKUjZTbmE0eGZSOGtvM2x5?= =?utf-8?B?Sm51OEVrY1VDSEVmbU9xSGNiRjViTnlLTERmUERGS3VkckFEYnpMbm5QNnFC?= =?utf-8?B?OHcyYXhRY1g1NUlGb3A3QXM5c01GQlQrY3FrcDFGbXZpUkZCVmF5REQvK0Ra?= =?utf-8?B?cFdFQklEU3QvV1Vza25Fa0FUWGdYQkdFSGlQUkZDY1ZGSWpaMGZQU3Y0SlQ5?= =?utf-8?B?ZXY2dDBqVTRUdkY2b2RpblB0eEdWMm5QQ0RsckErckR5SndMSDByeU45V2Z1?= =?utf-8?B?eWhuQlZzY2phQmhFYStOSG5wNUpPZ0lqN29lOEpwaGJkTXRSVlhVd0luVWhm?= =?utf-8?B?MDZCaFhqMWN6WDA1WVRUL3pKYjdMWUorRmhyYkw5RE1EMUM1d0FiL081aFZT?= =?utf-8?B?aDltN3AzTVlQa1ZZMHhJR2JkdFlUNlZUNEppcDBRRTNORDJwTUR2bFA4VzJH?= =?utf-8?B?UHNoKzYwN0VvZ0FObmZRdDZic0dFVndMRHE2TVVFWFFwMUNLMXRiV2JKS0No?= =?utf-8?B?UVdKWUkyd1UwWk80YURWOXF0UUJYSFBRRHBjMGp2UGxsNEtsbEl0cEFJV1Vv?= =?utf-8?Q?3gR+cvUWDl7uO0Lo9L6wEqDIa?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0727c91f-83f2-41a8-29c5-08db88216791 X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2023 06:28:45.8791 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D0c+HFTClDsMWXZJlObBZKvvgaVg+z8U3Mce0aHO6SrC3yA0dsi71iXZNRrfhq9X X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6069 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 7/18/23 17:41, Heinrich Schuchardt wrote: > On 13.07.23 16:35, Michal Simek wrote: >> Empty capsule are also allowed to be process. Without it updated images >> can't change their Image Acceptance state from no to yes. > > Is there any documentation describing the usage of empty capsule to set > the image acceptance state? I actually don't know about documentation. I was talking to Ilias to make sure that documentation is up2date because there are missing couple of things there. I am testing A/B update and if you setup oemflags to 0x8000 then capsules are not automatically accepted and waiting for acceptance capsule to be passed. When I tested it I found out that they are not process that's why I created this patch. But definitely someone should check that logic that the patch is right based on intention how these empty capsules should be used. I am actually not quite sure how revert capsules should be used and how to revert only certain image if you use multiple images in the same bank. Thanks, Michal