From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01252105A583 for ; Thu, 12 Mar 2026 11:15:57 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1252046.1548831 (Exim 4.92) (envelope-from ) id 1w0e17-00047v-Aj; Thu, 12 Mar 2026 11:15:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1252046.1548831; Thu, 12 Mar 2026 11:15:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1w0e17-00047o-6o; Thu, 12 Mar 2026 11:15:49 +0000 Received: by outflank-mailman (input) for mailman id 1252046; Thu, 12 Mar 2026 11:15:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1w0e15-0002tK-D4 for xen-devel@lists.xenproject.org; Thu, 12 Mar 2026 11:15:47 +0000 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [2a00:1450:4864:20::433]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cecb0d8c-1e04-11f1-9ccf-f158ae23cfc8; Thu, 12 Mar 2026 12:15:42 +0100 (CET) Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-439aeed8a5bso938364f8f.3 for ; Thu, 12 Mar 2026 04:15:42 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854b0ea7easm87259465e9.5.2026.03.12.04.15.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Mar 2026 04:15:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cecb0d8c-1e04-11f1-9ccf-f158ae23cfc8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1773314142; x=1773918942; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=/YgVZzVAUCkiwt1usxKtFwmZSlfoYoGgDkLJLubAeSQ=; b=DNW+8l+cyIxe7mIeflQNt2+bsKSo2a5qAjxxf9ETwil+9rhtOJbb1IWSgZzV/HWKm0 pa65cp/mIVIR9uuaTjuswys/cZA8QpHuqPKpBN/SWAysem3B26ajo4QL9IutTxLPCRuy su8RS5SXyzjIkMgz2Jc8OhAOuyZdZ4BC2WJHjwU5/yxdRONiQCKKTBVRAu8LYaLRpRc+ WDnDBOd1GBY00sUSDHFCx5mdD8RtV67m++JolXEHPj51UVyBDD1jfShezfBGyEa9lqEd 7xYNp51YQXL8/FOGOG13O8ordF4HjJ14zSvgq0x2isYTT0nW9lcPFZ8WSxXcMMUaeFSo GmIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773314142; x=1773918942; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/YgVZzVAUCkiwt1usxKtFwmZSlfoYoGgDkLJLubAeSQ=; b=SEN5Gn5sVBTVsoKLRAsg23VSrQBbZWQqCmxqeFJzVt+PapWpY+imYf/SM7lPZ8tk4S dLG0YMSmlC8k9tgDu88icHK5Xus6ormGCx6zhLPQ3BpPtgypD0mwBNdGbDcjeOAXUwIO KTklVtpp+9PHc86SCXl1R7SUFWAjqi/PbK/JkhokkoMW5nw6zXCu4BKZn9o+tAkHf6fF MG4IG6fdogcUvjdLsTqc0KFApH5SpUlIxQKw+jHGmzyw+OBXachyzDC1i8yLr9ft4dud qyJa1dqccnTF/F+EgdxVCPl76s1AVLl/sIcYTLMfG8+R67KZeGxRliXOdsBkn3tE86Iw k6SQ== X-Forwarded-Encrypted: i=1; AJvYcCXj8ONRsJnCKu76X32+6zhzZ4THANqbSHAOrf2U+1bQnBSvPUF3zQJNdMYKud/ZUn6jSiUt6HTfFzA=@lists.xenproject.org X-Gm-Message-State: AOJu0YyNwpUifX6OZb1DPLNXXKwvReH3hkY4d0Xqm1p/GK9I3+26Vg4j d+J7VevcuWfgY76lo/+0bmIN96/mz8lvpmIFd552hPwAbov/JKV/pWShrOGUHGe+hQ== X-Gm-Gg: ATEYQzxHga7TXib01jXfR3mc2oCVV91WcOzNXQ6CdNwLV5Y/uB6SpW0WszOY2EsddfA DbXY5rYpf9/unhcuzJSOQuLUBVEjCsjS/G/8Lj1wUu/S6hgWmuvz1RgFj6kjwddEyEfGtDaiOqV JnBt6QBQ/kxT5EtCtrsV8yzPcPbPqIImM0YMc5Zu/fEii19azRMQzhUa8/lHivcefq3Y3RfJYfl 1r55QdmAy+D6DauPkHuwD/8olofp3MTbCKNO2k3aLNEZM6VH4DIzrK+P5B6f17d4uqQZCpTEuZI 5l1ZM1hj/R05iqQKUtLpn5VTqQeRfghganzhfFn7e2I1KKOzWEAKcAYPPktAHDS3wKFQPXg1TXX 2rtkCO1C9lh5xlyb6Isf7NxCfAKx9T7ogO5PHOQQpqTG7Oq/Uemswd4DEgl65vphR9OP0RWK+GI 127+XYTxMVVf5CYVjoAAvgyt7Q5f7oCEWVj7s8EYG41be7Q//N5FxFhACl+NTcJzSdJnE0WIcHW 8DqJRpvAu+NSiA= X-Received: by 2002:a05:600c:8b62:b0:485:4388:348b with SMTP id 5b1f17b1804b1-4854ad76aa7mr99817925e9.0.1773314141785; Thu, 12 Mar 2026 04:15:41 -0700 (PDT) Message-ID: <9f40fbec-008f-4a50-bfb2-27c35d88f2a2@suse.com> Date: Thu, 12 Mar 2026 12:15:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/7] x86/hvm: Support extended destination IDs in virtual MSI and IO-APIC From: Jan Beulich To: Julian Vetter Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Anthony PERARD , Michal Orzel , Stefano Stabellini , Juergen Gross , Julien Grall , xen-devel@lists.xenproject.org References: <20260309123055.880050-1-julian.vetter@vates.tech> <20260309123055.880050-3-julian.vetter@vates.tech> <1e371e65-ca79-42a0-93f9-804f73084033@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <1e371e65-ca79-42a0-93f9-804f73084033@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11.03.2026 16:27, Jan Beulich wrote: > On 09.03.2026 13:31, Julian Vetter wrote: >> @@ -618,6 +620,21 @@ static int cf_check ioapic_check(const struct domain *d, hvm_domain_context_t *h >> e->fields.reserved[0] || e->fields.reserved[1] || >> e->fields.reserved[2] || e->fields.reserved2 ) >> return -EINVAL; >> + >> + /* >> + * An RTE in the saved state has ext_dest_id bits set. Check that >> + * the destination Xen has extended destination ID support enabled, >> + * otherwise interrupt routing to APIC IDs > 255 would be broken >> + * after restore. >> + */ >> + if ( e->fields.ext_dest_id && !d->arch.hvm.ext_dest_id_enabled ) > > This won't build, as the ext_dest_id_enabled field appears only in patch 6. > But yes, that looks to be the opt-in mechanism I mentioned above. Actually no, how could it be. That's for the DM to invoke. Jan