From: Yanling song <yanling.song@linux.dev>
To: Bart Van Assche <bvanassche@acm.org>,
Yanling Song <songyl@ramaxel.com>,
martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, yujiang@ramaxel.com,
xuyun@ramaxel.com, yanggan@ramaxel.com
Subject: Re: [PATCH V2] scsi:spraid: initial commit of Ramaxel spraid driver
Date: Sun, 12 Dec 2021 03:04:34 +0000 [thread overview]
Message-ID: <9f492efa-4e8c-f135-d922-1e02fbc602ed@linux.dev> (raw)
In-Reply-To: <6207ff07-b64b-a147-ed49-f194c81bb9ac@acm.org>
On 12/10/21 9:40 PM, Bart Van Assche wrote:
> On 11/25/21 11:33 PM, Yanling Song wrote:
>> +/* bsg dispatch user command */
>> +static int spraid_bsg_host_dispatch(struct bsg_job *job)
>> +{
>> + struct Scsi_Host *shost = dev_to_shost(job->dev);
>> + struct spraid_dev *hdev = shost_priv(shost);
>> + struct request *rq = blk_mq_rq_from_pdu(job);
>> + struct spraid_bsg_request *bsg_req = (struct spraid_bsg_request *)(job->request);
>
> Since job->request has type 'void *', no cast is necessary when assigning job->request to
> bsg_req. Hence please leave out the cast.
>
Ok. The cast will be removed in the next verison.
> Thanks,
>
> Bart.
prev parent reply other threads:[~2021-12-12 3:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 7:33 [PATCH V2] scsi:spraid: initial commit of Ramaxel spraid driver Yanling Song
2021-11-26 16:21 ` James Bottomley
2021-11-26 19:24 ` Randy Dunlap
[not found] ` <20211130113449.45751209@songyl>
2021-12-01 0:26 ` Yanling song
2021-11-29 13:04 ` Hannes Reinecke
[not found] ` <20211130113836.1bb8e91c@songyl>
2021-11-30 11:55 ` Hannes Reinecke
2021-12-02 13:56 ` Yanling song
2021-12-06 17:00 ` Bart Van Assche
2021-12-09 23:15 ` Bart Van Assche
2021-12-12 2:56 ` yanling.song
2021-12-27 7:55 ` Yanling Song
2021-12-10 17:42 ` Bart Van Assche
2021-12-12 3:02 ` Yanling song
2021-12-10 21:40 ` Bart Van Assche
2021-12-12 3:04 ` Yanling song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f492efa-4e8c-f135-d922-1e02fbc602ed@linux.dev \
--to=yanling.song@linux.dev \
--cc=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=songyl@ramaxel.com \
--cc=xuyun@ramaxel.com \
--cc=yanggan@ramaxel.com \
--cc=yujiang@ramaxel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.