From: Phillip Wood <phillip.wood123@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jun 2024, #04; Wed, 12)
Date: Thu, 13 Jun 2024 14:35:08 +0100 [thread overview]
Message-ID: <9f4aa9cc-fa63-4137-acba-14e41ea8fe78@gmail.com> (raw)
In-Reply-To: <xmqqcyolofar.fsf@gitster.g>
Hi Junio
On 13/06/2024 01:30, Junio C Hamano wrote:
> * pw/rebase-i-error-message (2024-05-30) 2 commits
> - rebase -i: improve error message when picking merge
> - rebase -i: pass struct replay_opts to parse_insn_line()
>
> When the user adds to "git rebase -i" instruction to "pick" a merge
> commit, the error experience is not pleasant. Such an error is now
> caught earlier in the process that parses the todo list.
>
> Expecting a reroll.
> cf. <88bc0787-e7ae-49e5-99e8-97f6c55ea8c6@gmail.com>
> source: <pull.1672.v3.git.1717076630.gitgitgadget@gmail.com>
I think this comment is out of date. c.f. <xmqq7cfbp6pb.fsf@gitster.g>
where you said
Thanks, will replace. Let's see if we see comments from
others and then mark it for 'next' soonish.
It has been a while and no one has commented so maybe it is time to
merge this to 'next'?
Thanks
Phillip
next prev parent reply other threads:[~2024-06-13 13:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 0:30 What's cooking in git.git (Jun 2024, #04; Wed, 12) Junio C Hamano
2024-06-13 5:52 ` Patrick Steinhardt
2024-06-13 15:22 ` Junio C Hamano
2024-06-14 5:52 ` Patrick Steinhardt
2024-06-13 13:35 ` Phillip Wood [this message]
2024-06-13 16:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f4aa9cc-fa63-4137-acba-14e41ea8fe78@gmail.com \
--to=phillip.wood123@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.