From: Jens Axboe <axboe@kernel.dk>
To: Vincent Fu <vincent.fu@samsung.com>,
Ankit Kumar <ankit.kumar@samsung.com>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>,
"krish.reddy@samsung.com" <krish.reddy@samsung.com>,
"joshi.k@samsung.com" <joshi.k@samsung.com>,
"anuj20.g@samsung.com" <anuj20.g@samsung.com>
Subject: Re: [PATCH v2 8/8] examples: add 2 example job file for io_uring_cmd engine
Date: Fri, 27 May 2022 12:05:34 -0600 [thread overview]
Message-ID: <9f503041-380a-2e62-cf0e-96f42fbf9147@kernel.dk> (raw)
In-Reply-To: <3f857eda853f4c4187482a6695e6a025@samsung.com>
On 5/27/22 11:30 AM, Vincent Fu wrote:
>> -----Original Message-----
>> From: Ankit Kumar [mailto:ankit.kumar@samsung.com]
>> Sent: Thursday, May 26, 2022 10:48 AM
>> To: axboe@kernel.dk
>> Cc: fio@vger.kernel.org; krish.reddy@samsung.com;
>> joshi.k@samsung.com; anuj20.g@samsung.com
>> Subject: [PATCH v2 8/8] examples: add 2 example job file for
>> io_uring_cmd engine
>>
>> From: Anuj Gupta <anuj20.g@samsung.com>
>>
>> examples/uring-cmd-ng.fio has usage for conventional nvme-ns char
>> device
>> examples/uring-cmd-zoned.fio has usage for ZNS nvme-ns char device
>>
>> Signed-off-by: Anuj Gupta <anuj20.g@samsung.com>
>> Co-authored-by: Ankit Kumar <ankit.kumar@samsung.com>
>> ---
>
> A minor nit: consider putting ioengine=io_uring_cmd and cmd_type=nvme
> directly in the job file.
Seconded - mixed job files generally only make sense for some kind of
testing framework, the example job files should be runnable directly
without using any args of environment variables.
--
Jens Axboe
next prev parent reply other threads:[~2022-05-27 18:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220526145343epcas5p362cd1b702fc0d11d21bca2880d6e288c@epcas5p3.samsung.com>
2022-05-26 14:48 ` [PATCH v2 0/8] Add support for uring passthrough commands Ankit Kumar
2022-05-26 14:48 ` [PATCH v2 1/8] io_uring.h: add IORING_SETUP_SQE128 and IORING_SETUP_CQE32 Ankit Kumar
2022-05-26 14:48 ` [PATCH v2 2/8] configure: check nvme uring command support Ankit Kumar
2022-05-26 14:48 ` [PATCH v2 3/8] nvme: add nvme opcodes, structures and helper functions Ankit Kumar
2022-05-27 7:29 ` Kanchan Joshi
2022-05-27 12:24 ` Jens Axboe
2022-05-27 13:21 ` Ankit Kumar
2022-05-27 14:45 ` Vincent Fu
2022-05-27 14:54 ` Jens Axboe
2022-05-27 18:07 ` Jens Axboe
2022-05-26 14:48 ` [PATCH v2 4/8] engines/io_uring: add new I/O engine for uring passthrough support Ankit Kumar
2022-05-27 6:37 ` Kanchan Joshi
2022-05-26 14:48 ` [PATCH v2 5/8] docs: document options for io_uring_cmd I/O engine Ankit Kumar
2022-05-27 6:54 ` Kanchan Joshi
2022-05-27 13:26 ` Ankit Kumar
2022-05-27 15:19 ` Vincent Fu
2022-05-26 14:48 ` [PATCH v2 6/8] zbd: Check for direct flag only if its block device Ankit Kumar
2022-05-27 16:15 ` Vincent Fu
2022-05-30 10:14 ` Shinichiro Kawasaki
2022-05-26 14:48 ` [PATCH v2 7/8] engines/io_uring: Enable zone device support for io_uring_cmd I/O engine Ankit Kumar
2022-05-27 17:23 ` Vincent Fu
2022-05-26 14:48 ` [PATCH v2 8/8] examples: add 2 example job file for io_uring_cmd engine Ankit Kumar
2022-05-27 17:30 ` Vincent Fu
2022-05-27 18:05 ` Jens Axboe [this message]
2022-05-27 7:02 ` [PATCH v2 0/8] Add support for uring passthrough commands Kanchan Joshi
2022-05-27 13:24 ` Ankit Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f503041-380a-2e62-cf0e-96f42fbf9147@kernel.dk \
--to=axboe@kernel.dk \
--cc=ankit.kumar@samsung.com \
--cc=anuj20.g@samsung.com \
--cc=fio@vger.kernel.org \
--cc=joshi.k@samsung.com \
--cc=krish.reddy@samsung.com \
--cc=vincent.fu@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.