Re: [PATCH v5 5/5] prserv: add bitbake selftests

[Michael Opdenacker <michael.opdenacker@bootlin.com>]

Hi Joshua

Many thanks for the review!

On 4/29/24 at 23:08, Joshua Watt wrote:
>> +
>> +class PRBasicTests(PRTestSetup, unittest.TestCase):
>> +
>> +    def setUp(self):
>> +        dbfile = "prtest-basic.sqlite3"
> It's generally considered bad form to dump test files in the users CWD
> and also blindly os.remove() things there :)
>
> In the hash server tests, we create a temporary directory and clean it
> up when the test ends by doing this in setUp():
>
>          self.temp_dir = tempfile.TemporaryDirectory(prefix='bb-hashserv')
>          self.addCleanup(self.temp_dir.cleanup)
>
> Then use self.temp_dir as the base whenever you need a path, e.g:
>
>          dbfile = os.path.join(self.temp_dir, "prtest-basic.sqlite3")

Done! Good catch.
I remember now keeping the database files when I was implementing the 
tests so that I could inspect the databases manually.

At least with this approach, I don't have to remove the database file if 
it exists! This almost makes the code smaller :)
This will be included in my next branch update.

Thanks!
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com