From: Hannes Reinecke <hare@suse.de>
To: Sergey Shtylyov <s.shtylyov@omprussia.ru>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 3/3] aha1542: fix multi-line comment style
Date: Tue, 12 Jan 2021 16:39:44 +0100 [thread overview]
Message-ID: <9f6278b6-7aa1-a867-e8b1-772e5bf1a02e@suse.de> (raw)
In-Reply-To: <08c231e5-d86f-9d0b-19ac-ad46fa0c0b58@omprussia.ru>
On 1/10/21 5:49 PM, Sergey Shtylyov wrote:
> Some comments in this driver don't comply with the preferred multi-line
> comment style, as reported by 'scripts/checkpatch.pl':
>
> WARNING: Block comments use * on subsequent lines
> WARNING: Block comments use a trailing */ on a separate line
>
> Fix those comments, along with the (unreported for some reason?) starts
> of the multi-line comments not being /* on their own line...
>
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
>
> ---
> drivers/scsi/aha1542.c | 119 ++++++++++++++++++++++++++++++-------------------
> 1 file changed, 75 insertions(+), 44 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
next prev parent reply other threads:[~2021-01-12 15:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-10 16:45 [PATCH 0/3] Improve comments in Adaptec AHA-154x driver Sergey Shtylyov
2021-01-10 16:46 ` [PATCH 1/3] aha1542: clarify 'struct ccb' comments Sergey Shtylyov
2021-01-12 15:38 ` Hannes Reinecke
2021-01-10 16:48 ` [PATCH 2/3] aha1542: kill trailing whitespace Sergey Shtylyov
2021-01-12 15:39 ` Hannes Reinecke
2021-01-10 16:49 ` [PATCH 3/3] aha1542: fix multi-line comment style Sergey Shtylyov
2021-01-12 15:39 ` Hannes Reinecke [this message]
2021-01-12 16:09 ` [PATCH 0/3] Improve comments in Adaptec AHA-154x driver James Bottomley
2021-01-12 16:36 ` Sergey Shtylyov
2021-01-13 5:32 ` Martin K. Petersen
2021-01-15 4:08 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f6278b6-7aa1-a867-e8b1-772e5bf1a02e@suse.de \
--to=hare@suse.de \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=s.shtylyov@omprussia.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.