All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Elliott Mitchell <ehem+xen@m5p.com>
Cc: xen-devel@lists.xenproject.org, Neowutran <xen@neowutran.ovh>
Subject: Re: [BUG] x2apic broken with current AMD hardware
Date: Mon, 20 Mar 2023 16:52:15 +0100	[thread overview]
Message-ID: <9fc0babb-c3c3-1896-c5fa-e7f5ae2ede27@suse.com> (raw)
In-Reply-To: <ZBh9sueCbOSX8iUu@mattapan.m5p.com>

On 20.03.2023 16:37, Elliott Mitchell wrote:
> On Mon, Mar 20, 2023 at 09:14:17AM +0100, Jan Beulich wrote:
>> On 17.03.2023 18:26, Elliott Mitchell wrote:
>>> I'm tempted to propose allowing _Static_assert() since it is valuable
>>> functionality for preventing issues.
>>
>> How does _Static_assert() come into play here? Also note that we already
>> use it when available ...
> 
> This is more in relation to the patch.  Appears GCC's C90 mode disables
> _Static_assert(), so the _Static_assert(ARRAY_SIZE(args) == 8) had to be
> dropped.

I'm puzzled by this. It's been for a long time that we've been building
with -std=gnu99. Plus you simply open-coded BUILD_BUG_ON() - if you had
used it, it would have taken care of the necessary abstraction for you
anyway.

Jan


      reply	other threads:[~2023-03-20 15:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-08 15:23 [BUG] x2apic broken with current AMD hardware Elliott Mitchell
2023-03-08 15:37 ` Andrew Cooper
2023-03-08 15:50 ` Jan Beulich
2023-03-08 23:08   ` Elliott Mitchell
2023-03-09  9:03     ` Jan Beulich
2023-03-10  3:25       ` Elliott Mitchell
2023-03-10  8:22         ` Jan Beulich
2023-03-11  0:09       ` Elliott Mitchell
2023-03-13  7:01         ` Jan Beulich
2023-03-16 22:03           ` Elliott Mitchell
2023-03-17  8:22             ` Jan Beulich
2023-03-17 17:26               ` Elliott Mitchell
2023-03-20  8:14                 ` Jan Beulich
2023-03-20  8:28                   ` Jan Beulich
2023-03-20 17:50                     ` Andrew Cooper
2023-03-21  4:19                     ` Elliott Mitchell
2023-03-21  7:13                       ` Jan Beulich
2023-03-21 22:19                         ` Elliott Mitchell
2023-03-21 14:34                       ` Neowutran
2023-03-21 10:46                     ` Marek Marczykowski-Górecki
2023-04-30 17:16                     ` Elliott Mitchell
2023-05-02  5:59                       ` Jan Beulich
2023-03-20 15:37                   ` Elliott Mitchell
2023-03-20 15:52                     ` Jan Beulich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9fc0babb-c3c3-1896-c5fa-e7f5ae2ede27@suse.com \
    --to=jbeulich@suse.com \
    --cc=ehem+xen@m5p.com \
    --cc=xen-devel@lists.xenproject.org \
    --cc=xen@neowutran.ovh \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.