From: Ihor Solodrai <ihor.solodrai@linux.dev>
To: Emil Tsalapatis <emil@etsalapatis.com>, bpf@vger.kernel.org
Cc: ast@kernel.org, andrii@kernel.org, memxor@gmail.com,
daniel@iogearbox.net, eddyz87@gmail.com,
mattbobrowski@google.com, song@kernel.org
Subject: Re: [PATCH bpf-next 1/5] libarena/selftests: Replace leftover st_ prefix with test_
Date: Tue, 30 Jun 2026 12:21:02 -0700 [thread overview]
Message-ID: <9fc9896b-cd48-4df8-a311-b2d4d266fcdd@linux.dev> (raw)
In-Reply-To: <20260618085626.19633-2-emil@etsalapatis.com>
On 6/18/26 1:56 AM, Emil Tsalapatis wrote:
> ---
> .../selftests/{st_asan_buddy.bpf.c => test_asan_buddy.bpf.c} | 2 +-
> .../libarena/selftests/{st_asan_common.h => test_asan_common.h} | 0
> .../bpf/libarena/selftests/{st_buddy.bpf.c => test_buddy.bpf.c} | 0
> 3 files changed, 1 insertion(+), 1 deletion(-)
> rename tools/testing/selftests/bpf/libarena/selftests/{st_asan_buddy.bpf.c => test_asan_buddy.bpf.c} (99%)
> rename tools/testing/selftests/bpf/libarena/selftests/{st_asan_common.h => test_asan_common.h} (100%)
> rename tools/testing/selftests/bpf/libarena/selftests/{st_buddy.bpf.c => test_buddy.bpf.c} (100%)
Acked-by: Ihor Solodrai <ihor.solodrai@linux.dev>
nit: An empty commit message is weird.
The short message is self-explanatory here, but still...
Maybe a brief comment on *why* this is done?
>
> diff --git a/tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c b/tools/testing/selftests/bpf/libarena/selftests/test_asan_buddy.bpf.c
> similarity index 99%
> rename from tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c
> rename to tools/testing/selftests/bpf/libarena/selftests/test_asan_buddy.bpf.c
> index 686caba2c643..256d62a03ce7 100644
> --- a/tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c
> +++ b/tools/testing/selftests/bpf/libarena/selftests/test_asan_buddy.bpf.c
> @@ -12,7 +12,7 @@ extern struct buddy __arena buddy;
>
> #ifdef BPF_ARENA_ASAN
>
> -#include "st_asan_common.h"
> +#include "test_asan_common.h"
>
> static __always_inline int asan_test_buddy_oob_single(size_t alloc_size)
> {
> diff --git a/tools/testing/selftests/bpf/libarena/selftests/st_asan_common.h b/tools/testing/selftests/bpf/libarena/selftests/test_asan_common.h
> similarity index 100%
> rename from tools/testing/selftests/bpf/libarena/selftests/st_asan_common.h
> rename to tools/testing/selftests/bpf/libarena/selftests/test_asan_common.h
> diff --git a/tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c b/tools/testing/selftests/bpf/libarena/selftests/test_buddy.bpf.c
> similarity index 100%
> rename from tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c
> rename to tools/testing/selftests/bpf/libarena/selftests/test_buddy.bpf.c
next prev parent reply other threads:[~2026-06-30 19:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 8:56 [PATCH bpf-next 0/5] selftests/bpf: libarena cleanup and bitmap struct Emil Tsalapatis
2026-06-18 8:56 ` [PATCH bpf-next 1/5] libarena/selftests: Replace leftover st_ prefix with test_ Emil Tsalapatis
2026-06-30 19:21 ` Ihor Solodrai [this message]
2026-07-01 4:23 ` Emil Tsalapatis
2026-06-18 8:56 ` [PATCH bpf-next 2/5] selftests/bpf: libarena: Fix can-loop zero variable definition Emil Tsalapatis
2026-06-18 9:09 ` sashiko-bot
2026-06-25 19:15 ` Eduard Zingerman
2026-06-30 19:28 ` Ihor Solodrai
2026-07-01 4:28 ` Emil Tsalapatis
2026-06-18 8:56 ` [PATCH bpf-next 3/5] selftests/bpf: libarena: Clean up allocation state before buddy tests Emil Tsalapatis
2026-06-18 9:47 ` bot+bpf-ci
2026-06-23 23:42 ` Emil Tsalapatis
2026-06-30 20:23 ` Ihor Solodrai
2026-06-18 8:56 ` [PATCH bpf-next 4/5] selftests/bpf: Add arena-based bitmap data structure Emil Tsalapatis
2026-06-18 9:08 ` sashiko-bot
2026-06-23 23:30 ` Emil Tsalapatis
2026-06-18 9:47 ` bot+bpf-ci
2026-06-30 21:44 ` Ihor Solodrai
2026-07-01 4:33 ` Emil Tsalapatis
2026-06-18 8:56 ` [PATCH bpf-next 5/5] selftests/bpf: libarena: Add bitmap selftets Emil Tsalapatis
2026-06-30 21:46 ` Ihor Solodrai
2026-07-01 4:33 ` Emil Tsalapatis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fc9896b-cd48-4df8-a311-b2d4d266fcdd@linux.dev \
--to=ihor.solodrai@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=mattbobrowski@google.com \
--cc=memxor@gmail.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.